diff --git a/system/web/Renderer.cfc b/system/web/Renderer.cfc index 72d910b29..3380abc8a 100755 --- a/system/web/Renderer.cfc +++ b/system/web/Renderer.cfc @@ -250,11 +250,16 @@ component // Do we have a view To render? Else throw exception if ( NOT len( arguments.view ) ) { + var viewNotSetDetail = "Please remember to use the 'event.setView()' method in your handler or pass in a view to render." + // Implicit views are disabled by default, so point at the most likely cause + if ( !variables.controller.getSetting( name = "ImplicitViews", defaultValue = false ) ) { + viewNotSetDetail &= " The ""implicitViews"" setting is disabled (the default since 8.3.0), so the view is not discovered from the event ('#event.getCurrentEvent()#'). Either set the view explicitly with event.setView(), or enable implicit views with the ""implicitViews = true"" setting in your config/Coldbox.cfc." + } throw( message = "The ""currentview"" variable has not been set, therefore there is no view to render.", - detail = "Please remember to use the 'event.setView()' method in your handler or pass in a view to render.", + detail = viewNotSetDetail, type = "Renderer.ViewNotSetException" - ); + ) } // Cleanup leading / in views, just in case diff --git a/tests/specs/web/RendererTest.cfc b/tests/specs/web/RendererTest.cfc index 86d9f297a..69adf4d8e 100755 --- a/tests/specs/web/RendererTest.cfc +++ b/tests/specs/web/RendererTest.cfc @@ -153,6 +153,30 @@ component extends="tests.resources.BaseIntegrationTest" { } } ) + it( "explains that implicit views are disabled when no view is set", () => { + var controller = getController() + var originalSetting = controller.getSetting( "ImplicitViews" ) + controller.setSetting( "ImplicitViews", false ) + + try { + var event = getRequestContext() + event.overrideEvent( "main.index" ) + event.setView( "" ) + var thrown = "" + try { + renderer.renderView( view = "" ) + } catch ( any e ) { + thrown = e + } + expect( thrown ).notToBeEmpty( "renderView() should have thrown" ) + expect( thrown.type ).toBe( "Renderer.ViewNotSetException" ) + expect( thrown.detail ).toInclude( "implicitViews" ) + expect( thrown.detail ).toInclude( "main.index" ) + } finally { + controller.setSetting( "ImplicitViews", originalSetting ) + } + } ) + describe( "Discovery Cache", () => { it( "viewDiscoveryCaching setting defaults to true", () => { expect( getController().getSetting( "viewDiscoveryCaching" ) ).toBeTrue();