From c90ec9de18afcd9ace5b773c204e63c80bea43ef Mon Sep 17 00:00:00 2001
From: seonghobae <8172694+seonghobae@users.noreply.github.com>
Date: Mon, 31 Aug 2026 16:22:40 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[MEDIUM]=20?=
 =?UTF-8?q?Fix=20integer=20coercion=20vulnerability=20in=20readline?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Replaced weak regex `^[0-9]+$` with bounded regex `^[12]$` to prevent large integers from coercing to `NA` and causing script crashes.
- Documented findings in `.jules/sentinel.md`.
---
 .jules/sentinel.md | 4 ++++
 R/aFIPC.R          | 6 +++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.jules/sentinel.md b/.jules/sentinel.md
index a8207a48..dd0c6a23 100644
--- a/.jules/sentinel.md
+++ b/.jules/sentinel.md
@@ -2,3 +2,7 @@
 **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
 **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
 **Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
+## 2024-07-13 - Prevent Integer Coercion DoS in readline
+**Vulnerability:** Weak regex `^[0-9]+$` allows large numbers that coerce to `NA` when parsed by `as.integer()`, causing a crash/DoS in subsequent `if` condition checks.
+**Learning:** Always use strictly bounded exact-match regex like `^[12]$` to prevent coercion crashes when reading integer inputs via `readline()` in R.
+**Prevention:** Use strictly bounded exact-match regex like `^[12]$` instead of `^[0-9]+$` for menu choices.
diff --git a/R/aFIPC.R b/R/aFIPC.R
index 62546519..918e19b1 100644
--- a/R/aFIPC.R
+++ b/R/aFIPC.R
@@ -141,7 +141,7 @@ autoFIPC <-
       }
       for (attempt in seq_len(3)) {
         n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
-        if (grepl("^[0-9]+$", n)) {
+        if (grepl("^[12]$", n)) {
           return(as.integer(n))
         }
       }
@@ -171,7 +171,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }
@@ -390,7 +390,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }