feat(advisor): surface schema in recommendations and grants

Advisor scans non-public schemas, emits schema-qualified CREATE INDEX
SQL, and Performance/privileges/dashboard skill copy follow suit.

Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>

Author: cursoragent

agent/skills/dashboard-design/SKILL.md

@@ -51,7 +51,7 @@ Hard rules:
 ## Procedure
 
 1. **Ground.** `get_brain_context`, `get_schema`, `list_business_rules`, `get_relationships`. Obey business rules about which table/column/filter/currency a concept uses — quote them; don't guess a similar-looking table.
-2. **Design.** Decide the KPIs, charts, tables, and controls (date range, dropdowns) the request calls for. Sketch the SQL for each — table-qualified, read-only.
+2. **Design.** Decide the KPIs, charts, tables, and controls (date range, dropdowns) the request calls for. Sketch the SQL for each — **schema-qualified** (`crm.orders`, not bare `orders` when the DB has multiple schemas), table-qualified columns, read-only.
 3. **Handle dates correctly.** Check the column's type in the schema. If it's a real DATE/DATETIME, filter with `BETWEEN '2026-07-01' AND '2026-07-08'`. **If it's a Unix-epoch integer** (seconds), filter on the epoch: `col >= UNIX_TIMESTAMP('2026-07-01 00:00:00') AND col < UNIX_TIMESTAMP('2026-07-09 00:00:00')`. Build these strings in JS from the picker's values.
 4. **Verify.** Run every query with `execute_sql` and READ the rows: date windows bounded and inside range (never the future), KPI value types right (name = text, money = currency), totals plausible vs a `COUNT(*)`. Fix and re-run until correct.
 5. **Intent checklist.** Before emitting, list every explicit ask (each chart, each metric, each control like "a date range picker defaulting to today") and confirm the HTML satisfies ALL of them. An unmet ask is a failed dashboard even if the data is perfect.

backend/src/main/java/com/dbaagent/service/DatabaseAdvisorService.java

@@ -281,7 +281,7 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
 
         try (Connection connection = connectionService.getConnection(connectionId, connRequest)) {
 
-            // Query 1: Tables with high sequential scans
+            // Query 1: Tables with high sequential scans (all non-system schemas)
             String query1 = """
                 SELECT
                     schemaname,
@@ -296,7 +296,7 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
                         ELSE 0
                     END as avg_seq_tup_read
                 FROM pg_stat_user_tables
-                WHERE schemaname = 'public'
+                WHERE schemaname NOT IN ('pg_catalog', 'information_schema', 'pg_toast')
                   AND seq_scan > 1000
                   AND n_live_tup > 10000
                   AND (idx_scan IS NULL OR seq_scan > idx_scan * 2)
@@ -308,11 +308,13 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
                  ResultSet rs = stmt.executeQuery(query1)) {
 
                 while (rs.next()) {
+                    String schemaName = rs.getString("schemaname");
                     String tableName = rs.getString("tablename");
                     long seqScans = rs.getLong("seq_scan");
                     long seqTupRead = rs.getLong("seq_tup_read");
                     long liveRows = rs.getLong("n_live_tup");
                     double avgSeqRead = rs.getDouble("avg_seq_tup_read");
+                    String qualifiedTable = "public".equals(schemaName) ? tableName : schemaName + "." + tableName;
 
                     // Get candidate columns
                     List<String> candidateColumns = getPostgresCandidateColumns(
@@ -325,7 +327,7 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
                             .id(UUID.randomUUID().toString())
                             .connectionId(connectionId)
                             .tableName(tableName)
-                            .schemaName("public")
+                            .schemaName(schemaName)
                             .columns(candidateColumns)
                             .indexType("BTREE")
                             .priority(seqScans > 10000 ?
@@ -334,13 +336,13 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
                             .reasoning(String.format(
                                 "Table '%s' has %,d sequential scans reading %,d rows (avg %.0f rows/scan). " +
                                 "Current row count: %,d. An index would significantly improve query performance.",
-                                tableName, seqScans, seqTupRead, avgSeqRead, liveRows
+                                qualifiedTable, seqScans, seqTupRead, avgSeqRead, liveRows
                             ))
                             .suggestedSQL(String.format(
                                 "CREATE INDEX CONCURRENTLY idx_%s_%s ON %s(%s)",
                                 tableName,
                                 String.join("_", candidateColumns),
-                                tableName,
+                                qualifiedTable,
                                 String.join(", ", candidateColumns)
                             ))
                             .metrics(IndexRecommendation.IndexRecommendationMetrics.builder()
@@ -358,9 +360,10 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
                 }
             }
 
-            // Query 2: Foreign keys without indexes
+            // Query 2: Foreign keys without indexes (all non-system schemas)
             String query2 = """
                 SELECT
+                    tc.table_schema,
                     tc.table_name,
                     kcu.column_name,
                     ccu.table_name AS foreign_table_name
@@ -371,11 +374,11 @@ private List<IndexRecommendation> detectPostgresMissingIndexes(String connection
                 JOIN information_schema.constraint_column_usage AS ccu
                   ON ccu.constraint_name = tc.constraint_name
                 WHERE tc.constraint_type = 'FOREIGN KEY'
-                  AND tc.table_schema = 'public'
+                  AND tc.table_schema NOT IN ('pg_catalog', 'information_schema', 'pg_toast')
                   AND NOT EXISTS (
                       SELECT 1
                       FROM pg_indexes
-                      WHERE schemaname = 'public'
+                      WHERE schemaname = tc.table_schema
                         AND tablename = tc.table_name
                         AND indexdef LIKE '%' || kcu.column_name || '%'
                   )
@@ -385,15 +388,17 @@ AND NOT EXISTS (
                  ResultSet rs = stmt.executeQuery(query2)) {
 
                 while (rs.next()) {
+                    String schemaName = rs.getString("table_schema");
                     String tableName = rs.getString("table_name");
                     String columnName = rs.getString("column_name");
                     String foreignTable = rs.getString("foreign_table_name");
+                    String qualifiedTable = "public".equals(schemaName) ? tableName : schemaName + "." + tableName;
 
                     IndexRecommendation rec = IndexRecommendation.builder()
                         .id(UUID.randomUUID().toString())
                         .connectionId(connectionId)
                         .tableName(tableName)
-                        .schemaName("public")
+                        .schemaName(schemaName)
                         .columns(Collections.singletonList(columnName))
                         .indexType("BTREE")
                         .priority(IndexRecommendation.RecommendationPriority.HIGH)
@@ -404,7 +409,7 @@ AND NOT EXISTS (
                         ))
                         .suggestedSQL(String.format(
                             "CREATE INDEX CONCURRENTLY idx_%s_%s ON %s(%s)",
-                            tableName, columnName, tableName, columnName
+                            tableName, columnName, qualifiedTable, columnName
                         ))
                         .metrics(IndexRecommendation.IndexRecommendationMetrics.builder()
                             .estimatedImprovementPercent(70)

src/components/ConnectionWizard/components/PrivilegesAccordion.js

@@ -19,19 +19,23 @@ export function PrivilegesAccordion({ dbType }) {
 -- Replace 'your_user' with your database username
 -- Replace 'your_database' with your database name
 
--- Basic read access to all tables
+-- Basic read access (repeat GRANT block per schema you want DeepSQL to see)
 GRANT SELECT ON ALL TABLES IN SCHEMA public TO your_user;
 GRANT SELECT ON ALL SEQUENCES IN SCHEMA public TO your_user;
+ALTER DEFAULT PRIVILEGES IN SCHEMA public
+  GRANT SELECT ON TABLES TO your_user;
+
+-- Multi-schema example (crm / sales / …)
+-- GRANT USAGE ON SCHEMA crm TO your_user;
+-- GRANT SELECT ON ALL TABLES IN SCHEMA crm TO your_user;
+-- GRANT SELECT ON ALL SEQUENCES IN SCHEMA crm TO your_user;
+-- ALTER DEFAULT PRIVILEGES IN SCHEMA crm GRANT SELECT ON TABLES TO your_user;
 
 -- Access to system views for monitoring
 GRANT pg_read_all_stats TO your_user;
 
 -- Enable pg_stat_statements extension (if not already enabled)
-CREATE EXTENSION IF NOT EXISTS pg_stat_statements;
-
--- For future tables
-ALTER DEFAULT PRIVILEGES IN SCHEMA public
-  GRANT SELECT ON TABLES TO your_user;`
+CREATE EXTENSION IF NOT EXISTS pg_stat_statements;`
     }
 
     if (dbType === 'mysql') {

src/components/tabs/Core/DatabaseAdvisorTab.js

@@ -196,7 +196,7 @@ export default function DatabaseAdvisorTab({ connectionId }) {
                                                 <span>{rec.priority}</span>
                                             </div>
                                             <div className={styles.issueTitle}>
-                                                {rec.tableName ? `Table: ${rec.tableName}` : rec.title}
+                                                {rec.tableName ? `Table: ${rec.schemaName ? `${rec.schemaName}.${rec.tableName}` : rec.tableName}` : rec.title}
                                             </div>
                                         </div>
                                         <div className={styles.issueReasoning}>

src/components/tabs/Performance/ExplainPlanTab.js

@@ -1741,9 +1741,9 @@ export default function ExplainPlanTab({ connectionId }) {
                                 <div className={styles.indexSection}>
                                     <h3>Index Recommendations ({indexRecommendations.length})</h3>
                                     {indexRecommendations.map((rec, idx) => (
-                                        <div key={`${rec.tableName}-${idx}`} className={styles.indexCard}>
+                                        <div key={`${rec.schemaName || ''}.${rec.tableName}-${idx}`} className={styles.indexCard}>
                                             <div className={styles.indexHeader}>
-                                                <span className={styles.indexTable}>{rec.tableName}</span>
+                                                <span className={styles.indexTable}>{rec.schemaName ? `${rec.schemaName}.${rec.tableName}` : rec.tableName}</span>
                                                 {rec.priority && (
                                                     <span className={styles.indexPriority}>{rec.priority}</span>
                                                 )}

src/components/tabs/Performance/SlowQueryAnalysisTab.js

@@ -1772,7 +1772,7 @@ export default function SlowQueryAnalysisTab({ connectionId }) {
           : "";
         const statement =
           rec.suggestedSQL ||
-          `CREATE INDEX ON ${rec.tableName} ${columns}`.trim();
+          `CREATE INDEX ON ${rec.schemaName ? `${rec.schemaName}.${rec.tableName}` : rec.tableName} ${columns}`.trim();
         items.push({ label: "Index", text: statement });
       });
     }

src/components/tabs/Performance/WorkloadAnalysisPanel.js

@@ -251,7 +251,7 @@ export default function WorkloadAnalysisPanel({ connectionId }) {
                       {rec.kind === "DROP_INDEX" ? "DROP" : "CREATE"}
                     </span>
                     <code className={styles.recTitle}>
-                      {rec.tableName} ({rec.columnNames})
+                      {rec.schemaName ? `${rec.schemaName}.${rec.tableName}` : rec.tableName} ({rec.columnNames})
                     </code>
                     {rec.priority && (
                       <span className={`${styles.prio} ${styles[`prio_${(rec.priority || "").toLowerCase()}`] || ""}`}>

src/components/tabs/Performance/components/TableHeatmap.js

@@ -107,7 +107,7 @@ export default function TableHeatmap({ data = [], caption = 'Based on scan frequ
                 {data.slice(0, 10).map((item, idx) => {
                     const widthPercent = Math.max((item.usageScore / maxScore) * 100, 8)
                     const opacity = 0.3 + (item.usageScore / 100) * 0.7
-                    const displayName = item.tableName?.split('.').pop() || item.tableName
+                    const displayName = item.tableName || ''
                     const tooltipContent = getTableTooltipContent(displayName, item.usageScore)
 
                     return (