Commit 7a32024
fix(ci): drop the CodeQL visibility guard that blocked every merge
`if: github.event.repository.visibility == 'public'` sat on a matrix job. A
job-level `if:` is evaluated before the matrix expands, so every skipped run
reported one check under the raw template name, `analyze (${{ matrix.language
}})`, instead of `analyze (java-kotlin)` and `analyze (javascript-typescript)`.
While the repository was private that phantom name was the only CodeQL check
anyone had seen, so it was pinned as a required status check in the `Protect
main branch` ruleset. When the repository went public the job began running for
real and reporting the two expanded names, leaving the required phantom with
nothing to report it. Every pull request then stalled on "Expected — waiting
for status to be reported": unmergeable, and with no failing job to point at,
indistinguishable from CI being stuck.
The guard has served its purpose — the repository is public and code scanning
is free, which is the condition its own comment named for deleting it. The
replacement comment records the failure mode so the `if:` is not reintroduced,
and says to fix a future private repository in the ruleset instead.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 471e17e commit 7a32024
1 file changed
Lines changed: 13 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
| |||
0 commit comments