|
| 1 | +package com.dbaagent.repository; |
| 2 | + |
| 3 | +import com.dbaagent.model.McpToken; |
| 4 | +import com.dbaagent.model.User; |
| 5 | +import org.junit.jupiter.api.Test; |
| 6 | +import org.springframework.beans.factory.annotation.Autowired; |
| 7 | +import org.springframework.boot.test.context.SpringBootTest; |
| 8 | +import org.springframework.test.context.ActiveProfiles; |
| 9 | +import org.springframework.transaction.annotation.Transactional; |
| 10 | + |
| 11 | +import java.time.LocalDateTime; |
| 12 | + |
| 13 | +import static org.junit.jupiter.api.Assertions.assertEquals; |
| 14 | +import static org.junit.jupiter.api.Assertions.assertTrue; |
| 15 | + |
| 16 | +/** |
| 17 | + * Regression cover for the FK that made {@code POST /users/admin/reset} return 500. |
| 18 | + * |
| 19 | + * <p>{@code mcp_tokens.user_id} is a non-null FK with no cascade, so deleting a user |
| 20 | + * who holds a token failed with |
| 21 | + * {@code ConstraintViolationException: update or delete on table "users" violates |
| 22 | + * foreign key constraint "fkhm5walli9xtthjoek1ia4paqg" on table "mcp_tokens"}. |
| 23 | + * |
| 24 | + * <p>Reachable on every self-host install: {@code setup-agent.sh} mints an MCP token |
| 25 | + * for the admin on each run, so setting up the agent was enough to permanently break |
| 26 | + * the admin-reset escape hatch — exactly when an operator locked out of the UI needs |
| 27 | + * it most. {@code UserController} now clears a user's tokens before deleting them. |
| 28 | + */ |
| 29 | +@SpringBootTest |
| 30 | +@ActiveProfiles("test") |
| 31 | +@Transactional |
| 32 | +class McpTokenUserDeletionTest { |
| 33 | + |
| 34 | + @Autowired |
| 35 | + private UserRepository userRepository; |
| 36 | + |
| 37 | + @Autowired |
| 38 | + private McpTokenRepository mcpTokenRepository; |
| 39 | + |
| 40 | + private User persistUser(String username) { |
| 41 | + User user = new User(); |
| 42 | + user.setUsername(username); |
| 43 | + user.setPassword("not-a-real-hash"); |
| 44 | + user.setEmail(username + "@example.invalid"); |
| 45 | + user.setRole("ADMIN"); |
| 46 | + return userRepository.saveAndFlush(user); |
| 47 | + } |
| 48 | + |
| 49 | + private void persistToken(User user, String publicId) { |
| 50 | + McpToken token = new McpToken(); |
| 51 | + token.setUser(user); |
| 52 | + token.setName("self-host-agent"); |
| 53 | + token.setPublicId(publicId); |
| 54 | + token.setTokenPrefix("dsql_test"); |
| 55 | + token.setTokenHash(new byte[] { 1, 2, 3, 4 }); |
| 56 | + token.setStatus(McpToken.Status.ACTIVE); |
| 57 | + token.setCreatedAt(LocalDateTime.now()); |
| 58 | + mcpTokenRepository.saveAndFlush(token); |
| 59 | + } |
| 60 | + |
| 61 | + @Test |
| 62 | + void deleteByUserIdClearsTheWayForUserDeletion() { |
| 63 | + User user = persistUser("admin-reset-ok"); |
| 64 | + persistToken(user, "pub-reset-1"); |
| 65 | + persistToken(user, "pub-reset-2"); |
| 66 | + Long userId = user.getId(); |
| 67 | + |
| 68 | + assertEquals(2, mcpTokenRepository.findByUserIdOrderByCreatedAtDesc(userId).size()); |
| 69 | + |
| 70 | + long revoked = mcpTokenRepository.deleteByUserId(userId); |
| 71 | + assertEquals(2, revoked, "both of the user's tokens must be removed"); |
| 72 | + |
| 73 | + // The delete that used to throw a FK ConstraintViolationException. |
| 74 | + userRepository.delete(user); |
| 75 | + userRepository.flush(); |
| 76 | + |
| 77 | + assertTrue(userRepository.findById(userId).isEmpty(), "user must be gone"); |
| 78 | + assertTrue(mcpTokenRepository.findByUserIdOrderByCreatedAtDesc(userId).isEmpty(), |
| 79 | + "the user's tokens must not outlive them"); |
| 80 | + } |
| 81 | + |
| 82 | + @Test |
| 83 | + void deleteByUserIdLeavesOtherUsersTokensAlone() { |
| 84 | + User keep = persistUser("keeper"); |
| 85 | + User drop = persistUser("dropped"); |
| 86 | + persistToken(keep, "pub-keep"); |
| 87 | + persistToken(drop, "pub-drop"); |
| 88 | + |
| 89 | + long revoked = mcpTokenRepository.deleteByUserId(drop.getId()); |
| 90 | + assertEquals(1, revoked); |
| 91 | + |
| 92 | + assertEquals(1, mcpTokenRepository.findByUserIdOrderByCreatedAtDesc(keep.getId()).size(), |
| 93 | + "deleting one user's tokens must not touch another's"); |
| 94 | + assertTrue(mcpTokenRepository.findByUserIdOrderByCreatedAtDesc(drop.getId()).isEmpty()); |
| 95 | + } |
| 96 | + |
| 97 | + @Test |
| 98 | + void deleteByUserIdIsSafeForAUserWithNoTokens() { |
| 99 | + User user = persistUser("tokenless"); |
| 100 | + assertEquals(0, mcpTokenRepository.deleteByUserId(user.getId())); |
| 101 | + |
| 102 | + userRepository.delete(user); |
| 103 | + userRepository.flush(); |
| 104 | + assertTrue(userRepository.findById(user.getId()).isEmpty()); |
| 105 | + } |
| 106 | +} |
0 commit comments