From 1629fc7a1b641a31d5fb5dc34762c3f4e8f27c00 Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 10:55:09 -0300 Subject: [PATCH 1/7] fix(Mobile): Keep drawers, segment rules and the feature summary usable on phones - Drawers grow with their content (min-height), so the lower half no longer renders without a background over the page. Dialogs stay content-sized cards. - Feature drawer tabs get the desktop spacing on phones. - Segment rule fields stack at full width; AND / AND NOT buttons are full width and evenly spaced, with the click on the button itself. - The feature drawer title shows just the flag name on phones, with the copy button beside it. - The environment summary shows two metrics per row on phones. Co-Authored-By: Claude Opus 5.5 --- .../components/feature-summary/FeatureRow.tsx | 14 +++++--- .../metrics/EnvironmentMetricsList.tsx | 10 +----- .../web/components/modals/CreateSegment.tsx | 33 +++++++++---------- .../Rule/components/RuleConditionRow.tsx | 12 +++---- frontend/web/styles/components/_metrics.scss | 9 +++++ frontend/web/styles/project/_modals.scss | 17 ++++++++-- 6 files changed, 56 insertions(+), 39 deletions(-) diff --git a/frontend/web/components/feature-summary/FeatureRow.tsx b/frontend/web/components/feature-summary/FeatureRow.tsx index 84a75d20f4c1..31863079ab53 100644 --- a/frontend/web/components/feature-summary/FeatureRow.tsx +++ b/frontend/web/components/feature-summary/FeatureRow.tsx @@ -235,7 +235,7 @@ const FeatureRow: FC = (props) => { : [] openModal( - + {!!cameFrom && ( = (props) => { )} - - {permission ? 'Edit Feature' : 'Feature'}: {projectFlag.name} + + {/* Phones show just the name so the copy button stays beside it */} + + {permission ? 'Edit Feature' : 'Feature'}:{' '} + + {projectFlag.name} = (props) => { onClick={() => { Utils.copyToClipboard(projectFlag.name) }} - className='ms-2' + className='ms-2 flex-shrink-0' > {ownerChips.length > 0 && ( -
+
{ownerChips.slice(0, 3).map((chip) => ( diff --git a/frontend/web/components/metrics/EnvironmentMetricsList.tsx b/frontend/web/components/metrics/EnvironmentMetricsList.tsx index 4b02f89d6726..1a9fd52fd89e 100644 --- a/frontend/web/components/metrics/EnvironmentMetricsList.tsx +++ b/frontend/web/components/metrics/EnvironmentMetricsList.tsx @@ -25,9 +25,6 @@ const EnvironmentMetricsList: FC = ({ }, ) - const MAX_COLUMNS = 6 - const columns = Math.min(data?.metrics?.length || 0, MAX_COLUMNS) || 1 - const extraMetricsData = getExtraMetricsData(projectId, environmentId) useEffect(() => { @@ -48,12 +45,7 @@ const EnvironmentMetricsList: FC = ({ } >
-
+
{data?.metrics.map((metric) => ( = ({ : 'Add at least one AND/NOT rule to create a segment.'} )} - - {!isReadOnly && ( -
+ -
- )} - {!isReadOnly && topLevelRuleType !== 'ANY' && ( -
addRule('NONE')} className='text-center'> + {topLevelRuleType === 'ANY' + ? 'Add OR Condition' + : 'Add AND Condition'} + + {topLevelRuleType !== 'ANY' && ( -
- )} -
+ )} +
+ )}
) diff --git a/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx b/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx index 1d5529525466..f3df50516f2e 100644 --- a/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx +++ b/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx @@ -84,9 +84,9 @@ const RuleConditionRow: React.FC = ({ )} -
-
-
+
+
+
= ({ setRuleProperty(ruleIndex, 'operator', value) }} options={operators} - className='col-10 col-sm-3 col-md-3' + className='col-12 col-sm-3 col-md-3' /> )} = ({ }) }} isValid={Utils.validateRule(rule) && !ruleErrors?.value} - className='col-10 col-sm-4 col-md-4' + className='col-12 col-sm-4 col-md-4' />
diff --git a/frontend/web/styles/components/_metrics.scss b/frontend/web/styles/components/_metrics.scss index d16f0f2ed29a..e1eabb09f487 100644 --- a/frontend/web/styles/components/_metrics.scss +++ b/frontend/web/styles/components/_metrics.scss @@ -16,4 +16,13 @@ display: grid; justify-content: center; row-gap: 12px; + // Phones: two per row + grid-template-columns: repeat(2, 1fr); + + // Wider screens: every metric on one row + @include media-breakpoint-up(md) { + grid-auto-columns: 1fr; + grid-auto-flow: column; + grid-template-columns: none; + } } \ No newline at end of file diff --git a/frontend/web/styles/project/_modals.scss b/frontend/web/styles/project/_modals.scss index 2459465c393d..12fcad6b49b3 100644 --- a/frontend/web/styles/project/_modals.scss +++ b/frontend/web/styles/project/_modals.scss @@ -345,11 +345,24 @@ $side-width: 800px; } @include media-breakpoint-down(md) { - .modal-dialog { + // Only drawers fill the screen; dialogs stay cards sized to their content + .side-modal .modal-dialog { margin:0; .modal-content { border-radius:0; - height: 100vh; + // min-height, not height: taller content must grow the panel, or it + // renders past its background on top of the page + min-height: 100vh; + } + } + + // Same spacing as the desktop side modal: none above the tabs, some below + .side-modal.create-feature-modal { + .modal-body { + padding-top: 0; + } + .tabs .tab-item:not(.p-0) { + padding-top: 24px; } } } From 43e83ad6641af4161e3040aebfe626b8cfabfb42 Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 11:18:45 -0300 Subject: [PATCH 2/7] fix(Mobile): Add the missing newline at the end of _metrics.scss Co-Authored-By: Claude Opus 5.5 --- frontend/web/styles/components/_metrics.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/web/styles/components/_metrics.scss b/frontend/web/styles/components/_metrics.scss index e1eabb09f487..7ff4f87bf0e8 100644 --- a/frontend/web/styles/components/_metrics.scss +++ b/frontend/web/styles/components/_metrics.scss @@ -25,4 +25,4 @@ grid-auto-flow: column; grid-template-columns: none; } -} \ No newline at end of file +} From b98c708a36e0f62bf9dfdf53a9521e72943486df Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 11:20:23 -0300 Subject: [PATCH 3/7] refactor(Mobile): Simplify the drawer spacing and mobile height rules The feature drawer's tab spacing matches desktop, so it no longer needs a breakpoint, and .p-0 is already !important. Co-Authored-By: Claude Opus 5.5 --- frontend/web/styles/project/_modals.scss | 30 +++++++++++------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/frontend/web/styles/project/_modals.scss b/frontend/web/styles/project/_modals.scss index 12fcad6b49b3..a3ecbec99e5e 100644 --- a/frontend/web/styles/project/_modals.scss +++ b/frontend/web/styles/project/_modals.scss @@ -119,7 +119,6 @@ $side-width: 800px; .tabs { .tab-item { - padding-top: 24px; padding-bottom: 24px; overflow-y: auto; height: calc(100vh - 110px); @@ -344,27 +343,26 @@ $side-width: 800px; } } +// Feature drawer: no space above the tabs, 24px below, at every width +.side-modal.create-feature-modal { + .modal-body { + padding-top: 0; + } + .tabs .tab-item { + padding-top: 24px; + } +} + @include media-breakpoint-down(md) { - // Only drawers fill the screen; dialogs stay cards sized to their content + // Only drawers fill the screen, growing with their content (min-height); + // dialogs stay cards sized to their content .side-modal .modal-dialog { - margin:0; + margin: 0; .modal-content { - border-radius:0; - // min-height, not height: taller content must grow the panel, or it - // renders past its background on top of the page + border-radius: 0; min-height: 100vh; } } - - // Same spacing as the desktop side modal: none above the tabs, some below - .side-modal.create-feature-modal { - .modal-body { - padding-top: 0; - } - .tabs .tab-item:not(.p-0) { - padding-top: 24px; - } - } } .modal-full-screen { From 0303388f5df47c12bd6d323d4458158d690e5dcc Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 11:22:54 -0300 Subject: [PATCH 4/7] fix(Mobile): Keep drawers full width between 544px and 768px Bootstrap caps .modal-dialog at --bs-modal-width from 544px, so below the md breakpoint the drawer turned into a narrow card. Co-Authored-By: Claude Opus 5.5 --- frontend/web/styles/project/_modals.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/frontend/web/styles/project/_modals.scss b/frontend/web/styles/project/_modals.scss index a3ecbec99e5e..fcb6d15c2b0a 100644 --- a/frontend/web/styles/project/_modals.scss +++ b/frontend/web/styles/project/_modals.scss @@ -358,6 +358,8 @@ $side-width: 800px; // dialogs stay cards sized to their content .side-modal .modal-dialog { margin: 0; + // Bootstrap caps .modal-dialog width from 544px; drawers stay full width + max-width: none; .modal-content { border-radius: 0; min-height: 100vh; From 15b53f96e334c6bdb807d3cb8007dc44196a7000 Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 11:59:59 -0300 Subject: [PATCH 5/7] fix(Mobile): Let long drawer titles truncate and keep rule fields inside their row Co-Authored-By: Claude Opus 5.5 --- .../components/segments/Rule/components/RuleConditionRow.tsx | 2 +- frontend/web/styles/project/_modals.scss | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx b/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx index f3df50516f2e..176c54bfa811 100644 --- a/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx +++ b/frontend/web/components/segments/Rule/components/RuleConditionRow.tsx @@ -85,7 +85,7 @@ const RuleConditionRow: React.FC = ({ )}
-
+
Date: Tue, 17 Nov 2026 12:22:50 -0300 Subject: [PATCH 6/7] fix(Mobile): Fit drawers to the visible screen when the browser toolbar shows Co-Authored-By: Claude Opus 5.5 --- frontend/web/styles/project/_modals.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/frontend/web/styles/project/_modals.scss b/frontend/web/styles/project/_modals.scss index 0a87093dc575..add584b64897 100644 --- a/frontend/web/styles/project/_modals.scss +++ b/frontend/web/styles/project/_modals.scss @@ -368,6 +368,8 @@ $side-width: 800px; .modal-content { border-radius: 0; min-height: 100vh; + // Fits the visible screen when the mobile browser toolbar shows + min-height: 100dvh; } } } From c34e2b3c02f6c0ba5f6385ce447577155b421355 Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 12:26:54 -0300 Subject: [PATCH 7/7] chore(Mobile): Trim comments that repeat the code Co-Authored-By: Claude Opus 5.5 --- frontend/web/styles/components/_metrics.scss | 1 - frontend/web/styles/project/_modals.scss | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/frontend/web/styles/components/_metrics.scss b/frontend/web/styles/components/_metrics.scss index 7ff4f87bf0e8..2ec69cd9d9cc 100644 --- a/frontend/web/styles/components/_metrics.scss +++ b/frontend/web/styles/components/_metrics.scss @@ -16,7 +16,6 @@ display: grid; justify-content: center; row-gap: 12px; - // Phones: two per row grid-template-columns: repeat(2, 1fr); // Wider screens: every metric on one row diff --git a/frontend/web/styles/project/_modals.scss b/frontend/web/styles/project/_modals.scss index add584b64897..b4be88b90a47 100644 --- a/frontend/web/styles/project/_modals.scss +++ b/frontend/web/styles/project/_modals.scss @@ -348,7 +348,6 @@ $side-width: 800px; min-width: 0; } -// Feature drawer: no space above the tabs, 24px below, at every width .side-modal.create-feature-modal { .modal-body { padding-top: 0; @@ -359,8 +358,7 @@ $side-width: 800px; } @include media-breakpoint-down(md) { - // Only drawers fill the screen, growing with their content (min-height); - // dialogs stay cards sized to their content + // Drawers fill the screen; dialogs stay cards .side-modal .modal-dialog { margin: 0; // Bootstrap caps .modal-dialog width from 544px; drawers stay full width