From 8fef7d641ecbe68da01c675415eb59094bccef71 Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 15:56:03 -0300 Subject: [PATCH 1/2] feat(Chip): Add a warning variant Co-Authored-By: Claude Opus 5.5 --- frontend/documentation/components/Chip.stories.tsx | 5 +++++ frontend/web/components/base/Chip/Chip.scss | 4 ++++ frontend/web/components/base/Chip/Chip.tsx | 6 ++++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/frontend/documentation/components/Chip.stories.tsx b/frontend/documentation/components/Chip.stories.tsx index 6261d8b0ba7b..91b453ed2ae4 100644 --- a/frontend/documentation/components/Chip.stories.tsx +++ b/frontend/documentation/components/Chip.stories.tsx @@ -29,6 +29,10 @@ export const Accent: Story = { args: { children: '"hello"', variant: 'accent' }, } +export const Warning: Story = { + args: { children: '1/2', variant: 'warning' }, +} + export const Sizes: Story = { render: () => (
@@ -56,6 +60,7 @@ export const Group: Story = {
Development Staging + Paused undefined}>Production
), diff --git a/frontend/web/components/base/Chip/Chip.scss b/frontend/web/components/base/Chip/Chip.scss index a521448124f6..6d7460f52a78 100644 --- a/frontend/web/components/base/Chip/Chip.scss +++ b/frontend/web/components/base/Chip/Chip.scss @@ -13,6 +13,10 @@ border-color: var(--color-border-action); } + &--warning { + border-color: var(--color-border-warning); + } + // Sizes (default is the base above). &--sm { padding: 3px 8px; diff --git a/frontend/web/components/base/Chip/Chip.tsx b/frontend/web/components/base/Chip/Chip.tsx index 8407b5cd9f3f..fbf66200b2a7 100644 --- a/frontend/web/components/base/Chip/Chip.tsx +++ b/frontend/web/components/base/Chip/Chip.tsx @@ -6,7 +6,7 @@ import { toHexColour } from 'common/utils/hexColour' import './Chip.scss' export type ChipSize = 'default' | 'sm' | 'xs' -export type ChipVariant = 'neutral' | 'accent' | 'tinted' +export type ChipVariant = 'neutral' | 'accent' | 'warning' | 'tinted' type TokenVariant = Exclude // 'tinted' takes a 6-digit hex colour; the token variants take none. @@ -37,6 +37,7 @@ export type ChipProps = ChipVariantProps & { const VARIANT_UTILITIES: Record = { accent: 'bg-surface-action-subtle text-action', neutral: 'bg-surface-subtle text-default', + warning: 'bg-surface-warning text-warning', } // Token-based chip primitive. Uses `ds-chip` rather than the legacy `.chip` @@ -79,8 +80,9 @@ const Chip = ({ 'ds-chip--accent': !tint && tokenVariant === 'accent', 'ds-chip--clickable': interactive, 'ds-chip--tinted': !!tint, - [`ds-chip--${size}`]: size !== 'default', 'ds-chip--truncate': truncate, + [`ds-chip--${size}`]: size !== 'default', + 'ds-chip--warning': !tint && tokenVariant === 'warning', }, className, )} From 46590d3d4faac215d901cd5dc9736a6aec218f79 Mon Sep 17 00:00:00 2001 From: Talisson Costa Date: Tue, 17 Nov 2026 16:48:15 -0300 Subject: [PATCH 2/2] feat(Chip): Add a success variant Co-Authored-By: Claude Opus 5.5 --- frontend/documentation/components/Chip.stories.tsx | 5 +++++ frontend/web/components/base/Chip/Chip.scss | 4 ++++ frontend/web/components/base/Chip/Chip.tsx | 9 ++++++++- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/frontend/documentation/components/Chip.stories.tsx b/frontend/documentation/components/Chip.stories.tsx index 91b453ed2ae4..b13a76a4afe8 100644 --- a/frontend/documentation/components/Chip.stories.tsx +++ b/frontend/documentation/components/Chip.stories.tsx @@ -29,6 +29,10 @@ export const Accent: Story = { args: { children: '"hello"', variant: 'accent' }, } +export const Success: Story = { + args: { children: 'View feature', variant: 'success' }, +} + export const Warning: Story = { args: { children: '1/2', variant: 'warning' }, } @@ -60,6 +64,7 @@ export const Group: Story = {
Development Staging + Live Paused undefined}>Production
diff --git a/frontend/web/components/base/Chip/Chip.scss b/frontend/web/components/base/Chip/Chip.scss index 6d7460f52a78..3f14717314d3 100644 --- a/frontend/web/components/base/Chip/Chip.scss +++ b/frontend/web/components/base/Chip/Chip.scss @@ -13,6 +13,10 @@ border-color: var(--color-border-action); } + &--success { + border-color: var(--color-border-success); + } + &--warning { border-color: var(--color-border-warning); } diff --git a/frontend/web/components/base/Chip/Chip.tsx b/frontend/web/components/base/Chip/Chip.tsx index fbf66200b2a7..b03f87386546 100644 --- a/frontend/web/components/base/Chip/Chip.tsx +++ b/frontend/web/components/base/Chip/Chip.tsx @@ -6,7 +6,12 @@ import { toHexColour } from 'common/utils/hexColour' import './Chip.scss' export type ChipSize = 'default' | 'sm' | 'xs' -export type ChipVariant = 'neutral' | 'accent' | 'warning' | 'tinted' +export type ChipVariant = + | 'neutral' + | 'accent' + | 'success' + | 'warning' + | 'tinted' type TokenVariant = Exclude // 'tinted' takes a 6-digit hex colour; the token variants take none. @@ -37,6 +42,7 @@ export type ChipProps = ChipVariantProps & { const VARIANT_UTILITIES: Record = { accent: 'bg-surface-action-subtle text-action', neutral: 'bg-surface-subtle text-default', + success: 'bg-surface-success text-success', warning: 'bg-surface-warning text-warning', } @@ -79,6 +85,7 @@ const Chip = ({ { 'ds-chip--accent': !tint && tokenVariant === 'accent', 'ds-chip--clickable': interactive, + 'ds-chip--success': !tint && tokenVariant === 'success', 'ds-chip--tinted': !!tint, 'ds-chip--truncate': truncate, [`ds-chip--${size}`]: size !== 'default',