fix(tests): make all tests locale-agnostic and robust to env differences

- Use t() for all i18n strings instead of hardcoded English text
- status.test.ts: use t() for TTS, project, worktree, managed strings
- commands.test.ts: use t() for commands.select and commands.select_page
- formatter.test.ts: use t() for tool.file_header.write
- file-tree.test.ts: use t() for subfolder count strings
- voice.test.ts: narrow debug spy check to STT-specific message only
- external-user-input.test.ts: use t() for bot.external_user_input
- aggregator.test.ts: use t() for tool.file_header.edit
- next-run.ts: fix weekday detection to use long format + full name map
  to avoid ICU inconsistencies in Node 22 (short format may return <3 chars)

Author: IL

package-lock.json

@@ -28,6 +28,31 @@ const WEEKDAY_ALIASES: Record<string, number> = {
   sat: 6,
 };
 
+// Full English weekday names as a fallback for ICU environments where
+// "short" format returns fewer than 3 characters (e.g. "Su" instead of "Sun").
+const WEEKDAY_FULL_NAMES: Record<string, number> = {
+  sunday: 0,
+  monday: 1,
+  tuesday: 2,
+  wednesday: 3,
+  thursday: 4,
+  friday: 5,
+  saturday: 6,
+};
+
+const weekdayFormatterCache = new Map<string, Intl.DateTimeFormat>();
+
+function getWeekdayFormatter(timezone: string): Intl.DateTimeFormat {
+  const cached = weekdayFormatterCache.get(timezone);
+  if (cached) return cached;
+  const formatter = new Intl.DateTimeFormat("en-US", {
+    timeZone: timezone,
+    weekday: "long",
+  });
+  weekdayFormatterCache.set(timezone, formatter);
+  return formatter;
+}
+
 interface CronFieldMatcher {
   wildcard: boolean;
   values: Set<number>;
@@ -200,19 +225,26 @@ function getZonedDateParts(date: Date, timezone: string): ZonedDateParts {
   const rawHour = Number(parts.find((part) => part.type === "hour")?.value);
   const hour = rawHour === 24 ? 0 : rawHour;
   const minute = Number(parts.find((part) => part.type === "minute")?.value);
-  const weekdayName = parts
-    .find((part) => part.type === "weekday")
-    ?.value?.toLowerCase()
-    .slice(0, 3);
+
+  // Use a dedicated "long" weekday formatter to avoid ICU inconsistencies
+  // where "short" may return fewer than 3 characters (e.g. "Su" vs "Sun").
+  const weekdayLong = getWeekdayFormatter(timezone).format(date).toLowerCase();
+  // Try full name first, then fall back to 3-char prefix for robustness.
+  const weekdayKey = weekdayLong in WEEKDAY_FULL_NAMES
+    ? weekdayLong
+    : weekdayLong.slice(0, 3);
+  const weekdayValue =
+    weekdayKey in WEEKDAY_FULL_NAMES
+      ? WEEKDAY_FULL_NAMES[weekdayKey]
+      : WEEKDAY_ALIASES[weekdayKey];
 
   if (
     !Number.isInteger(year) ||
     !Number.isInteger(month) ||
     !Number.isInteger(day) ||
     !Number.isInteger(hour) ||
     !Number.isInteger(minute) ||
-    !weekdayName ||
-    !(weekdayName in WEEKDAY_ALIASES)
+    weekdayValue === undefined
   ) {
     throw new Error(`Failed to resolve zoned date parts for timezone: ${timezone}`);
   }
@@ -223,7 +255,7 @@ function getZonedDateParts(date: Date, timezone: string): ZonedDateParts {
     day,
     hour,
     minute,
-    weekday: WEEKDAY_ALIASES[weekdayName],
+    weekday: weekdayValue,
   };
 }
 

src/scheduled-task/next-run.ts

@@ -601,12 +601,12 @@ describe("commands pagination helpers", () => {
 
   describe("formatCommandsSelectText", () => {
     it("returns base text for first page", () => {
-      expect(formatCommandsSelectText(0)).toBe("Choose an OpenCode command:");
+      expect(formatCommandsSelectText(0)).toBe(t("commands.select"));
     });
 
     it("returns page-specific text for subsequent pages", () => {
-      expect(formatCommandsSelectText(1)).toBe("Choose an OpenCode command (page 2):");
-      expect(formatCommandsSelectText(5)).toBe("Choose an OpenCode command (page 6):");
+      expect(formatCommandsSelectText(1)).toBe(t("commands.select_page", { page: 2 }));
+      expect(formatCommandsSelectText(5)).toBe(t("commands.select_page", { page: 6 }));
     });
   });
 

tests/bot/commands/commands.test.ts

@@ -1,6 +1,7 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import type { Context } from "grammy";
 import { statusCommand } from "../../../src/bot/commands/status.js";
+import { t } from "../../../src/i18n/index.js";
 
 const mocked = vi.hoisted(() => ({
   healthMock: vi.fn(),
@@ -117,9 +118,9 @@ describe("bot/commands/status", () => {
     await statusCommand(ctx as never);
 
     const message = mocked.sendBotTextMock.mock.calls[0]?.[0]?.text as string;
-    expect(message).toContain("TTS replies");
-    expect(message).toContain("On");
-    expect(message).not.toContain("Started by bot");
+    expect(message).toContain(t("status.line.tts", { tts: "" }).split(":")[0]);
+    expect(message).toContain(t("status.tts.on"));
+    expect(message).not.toContain(t("status.line.managed_yes").split(":")[0]);
   });
 
   it("shows main project path and linked worktree when git metadata is available", async () => {
@@ -146,7 +147,7 @@ describe("bot/commands/status", () => {
     await statusCommand(ctx as never);
 
     const message = mocked.sendBotTextMock.mock.calls[0]?.[0]?.text as string;
-    expect(message).toContain("Project: /repo-main: feature/mobile");
-    expect(message).toContain("Worktree: /repo-feature");
+    expect(message).toContain(t("status.project_selected", { project: "/repo-main: feature/mobile" }));
+    expect(message).toContain(t("status.worktree_selected", { worktree: "/repo-feature" }));
   });
 });

tests/bot/commands/status.test.ts

@@ -151,7 +151,11 @@ describe("bot/handlers/voice", () => {
       await handleVoiceMessage(ctx, deps);
 
       expect(processPromptMock).toHaveBeenCalledWith(ctx, "run tests", deps);
-      expect(logger.debug).not.toHaveBeenCalled();
+      const debugCalls = (logger.debug as ReturnType<typeof vi.fn>).mock.calls;
+      const sttDebugCall = debugCalls.find((args) =>
+        typeof args[0] === "string" && args[0].includes("Added STT note"),
+      );
+      expect(sttDebugCall).toBeUndefined();
     },
   );
 });

tests/bot/handlers/voice.test.ts

@@ -1,4 +1,5 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
+import { t } from "../../../src/i18n/index.js";
 
 const mocked = vi.hoisted(() => ({
   sendBotTextMock: vi.fn(),
@@ -55,8 +56,8 @@ describe("bot/utils/external-user-input", () => {
     const notification = buildExternalUserInputNotification("Line 1\nLine 2");
 
     expect(notification).toEqual({
-      text: expect.stringContaining("External user input"),
-      rawFallbackText: "👤 External user input\n\n> Line 1\n> Line 2",
+      text: expect.stringContaining(t("bot.external_user_input")),
+      rawFallbackText: `👤 ${t("bot.external_user_input")}\n\n> Line 1\n> Line 2`,
     });
   });
 
@@ -75,7 +76,7 @@ describe("bot/utils/external-user-input", () => {
       expect.objectContaining({
         chatId: 777,
         format: "markdown_v2",
-        rawFallbackText: "👤 External user input\n\n> Review the parser",
+        rawFallbackText: `👤 ${t("bot.external_user_input")}\n\n> Review the parser`,
       }),
     );
   });

tests/bot/utils/external-user-input.test.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
+import { t } from "../../../src/i18n/index.js";
 import os from "node:os";
 import path from "node:path";
 import { promises as fs } from "node:fs";
@@ -205,12 +206,12 @@ describe("file-tree", () => {
 
     it("should use singular form for 1 subfolder", () => {
       const header = buildTreeHeader("~/one", 1, 0, 1);
-      expect(header).toContain("1 subfolder");
+      expect(header).toContain(t("open.subfolder_count", { count: 1 }));
     });
 
     it("should use plural form for multiple subfolders", () => {
       const header = buildTreeHeader("~/many", 5, 0, 1);
-      expect(header).toContain("5 subfolders");
+      expect(header).toContain(t("open.subfolders_count", { count: 5 }));
     });
   });
 

tests/bot/utils/file-tree.test.ts

@@ -1,6 +1,7 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import type { Event } from "@opencode-ai/sdk/v2";
 import { summaryAggregator } from "../../src/summary/aggregator.js";
+import { t } from "../../src/i18n/index.js";
 
 const mocked = vi.hoisted(() => ({
   getCurrentProjectMock: vi.fn(),
@@ -1311,7 +1312,7 @@ describe("summary/aggregator", () => {
     expect(filePayload.tool).toBe("apply_patch");
     expect(filePayload.hasFileAttachment).toBe(true);
     expect(filePayload.fileData.filename).toBe("edit_one.ts.txt");
-    expect(filePayload.fileData.buffer.toString("utf8")).toContain("Edit File/Path: src/one.ts");
+    expect(filePayload.fileData.buffer.toString("utf8")).toContain(t("tool.file_header.edit", { path: "src/one.ts" }).split("\n")[0]);
   });
 
   it("sends apply_patch file using title and patchText fallback", () => {
@@ -1371,7 +1372,7 @@ describe("summary/aggregator", () => {
 
     expect(filePayload.hasFileAttachment).toBe(true);
     expect(filePayload.fileData.filename).toBe("edit_README.md.txt");
-    expect(filePayload.fileData.buffer.toString("utf8")).toContain("Edit File/Path: README.md");
+    expect(filePayload.fileData.buffer.toString("utf8")).toContain(t("tool.file_header.edit", { path: "README.md" }).split("\n")[0]);
   });
 
   it("fires onTokens with isCompleted=true when message has completed timestamp", () => {

tests/summary/aggregator.test.ts

@@ -5,6 +5,7 @@ import {
   formatToolInfo,
   prepareCodeFile,
 } from "../../src/summary/formatter.js";
+import { t } from "../../src/i18n/index.js";
 
 const mocked = vi.hoisted(() => ({
   getCurrentProjectMock: vi.fn(),
@@ -271,7 +272,7 @@ describe("summary/formatter", () => {
     const writeFile = prepareCodeFile("const x = 1;", "src/app.ts", "write");
     expect(writeFile).not.toBeNull();
     expect(writeFile?.filename).toBe("write_app.ts.txt");
-    expect(writeFile?.buffer.toString("utf8")).toContain("Write File/Path: src/app.ts");
+    expect(writeFile?.buffer.toString("utf8")).toContain(t("tool.file_header.write", { path: "src/app.ts" }).split("\n")[0]);
 
     const diff = [
       "@@ -1,2 +1,2 @@",
@@ -333,6 +334,6 @@ describe("summary/formatter", () => {
     expect(editText).toContain("✏️ edit README.md (+3)");
 
     const writeFile = prepareCodeFile("content", "D:/repo/src/absolute-write.ts", "write");
-    expect(writeFile?.buffer.toString("utf8")).toContain("Write File/Path: src/absolute-write.ts");
+    expect(writeFile?.buffer.toString("utf8")).toContain(t("tool.file_header.write", { path: "src/absolute-write.ts" }).split("\n")[0]);
   });
 });