Repository navigation
Vouch request: atishay-kasliwal #5594
atishay-kasliwal
started this conversation in
Vouch Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
Hi, I'm a software engineer and I've been getting more involved in NVIDIA's open source projects, including nodewright, nvke, and workload-map. I'd like to contribute to OpenShell as well.
I was looking at issue #5588. From what I understand, when a workload Pod is being deleted, it reports
Ready=FalsewithPodTerminating, but OpenShell treats that as a permanent failure. This leaves the sandbox in Error even though it's just shutting down normally.I'd like to fix this by treating
PodTerminatingas temporary inis_terminal_failure_reason(), allowing the sandbox to eventually reach Stopped while keeping actual failures in Error. I'd also add unit tests for the temporary, real failure, and unknown failure cases.I use AI tools during development, but I review and understand the changes I submit. Since #5588 is still in triage, would this be a good issue to pick up?
Why this change?
I want to fix #5588 because a normal sandbox shutdown shouldn't end up as an Error. Right now, PodTerminating gets treated as a permanent failure, leaving the sandbox stuck even after it stops. This can be especially problematic when managing multiple agents, since it requires manual intervention. I think treating it as a temporary state would make shutdowns more reliable without hiding real failures.
Checklist
All reactions