From 1d87097833356d7a189d152d73e1d3cf31e7d671 Mon Sep 17 00:00:00 2001 From: Derek Lewis Date: Tue, 25 Aug 2026 21:29:20 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8F=97=EF=B8=8F=F0=9F=9A=AE=EF=BC=9Adrop?= =?UTF-8?q?=20the=20queue=20label's=20plain=20spelling?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The label is `🚀 Status: Commit Queue` now, so the plain name the condition also accepted no longer exists and nothing can carry it. The handbook names the label a reader has to apply, so it says the same. The condition is quoted whole: the name contains a colon, and an unquoted scalar reads that as a mapping. Signed-off-by: Derek Lewis Assisted-by: Claude-Code:claude-opus-5 --- .github/workflows/commit-queue.yml | 13 +++++-------- collections/_docs/handbook/style/commit-messages.md | 6 +++--- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/commit-queue.yml b/.github/workflows/commit-queue.yml index c4d6797f3..a59140bcf 100644 --- a/.github/workflows/commit-queue.yml +++ b/.github/workflows/commit-queue.yml @@ -29,12 +29,9 @@ concurrency: jobs: land: name: Land - # Both spellings, so the label can be renamed without a window in - # which nothing lands: the workflow that runs is the one on the base - # branch, not the one under review. - if: >- - github.event.label.name == 'commit-queue' || - github.event.label.name == '🚀 Status: Commit Queue' + # Quoted whole: the label name contains a colon, which an unquoted + # scalar would read as a mapping. + if: "github.event.label.name == '🚀 Status: Commit Queue'" runs-on: ubuntu-latest steps: - name: Mint a token for the app @@ -97,8 +94,8 @@ jobs: NUMBER: ${{ github.event.pull_request.number }} LABEL: ${{ github.event.label.name }} run: | - # Whichever spelling triggered this, percent-encoded: the name sits - # in a URL path and an emoji one would not survive it raw. + # The name sits in a URL path, where an emoji would not survive + # being interpolated raw. gh api --silent -X DELETE \ "repos/${GITHUB_REPOSITORY}/issues/${NUMBER}/labels/$(jq -rn --arg l "$LABEL" '$l|@uri')" \ || true diff --git a/collections/_docs/handbook/style/commit-messages.md b/collections/_docs/handbook/style/commit-messages.md index 8b4a0311f..a7784850c 100644 --- a/collections/_docs/handbook/style/commit-messages.md +++ b/collections/_docs/handbook/style/commit-messages.md @@ -11,9 +11,9 @@ request. Nothing here is a matter of taste that the checker is unaware of: if it passes, the message conforms. What lands is built from these messages rather than typed again at merge time. -Labelling a pull request `commit-queue` squashes it into one commit whose body -keeps every message it contained, with the trailers gathered where git reads -them and `PR-URL` added. +Labelling a pull request `🚀 Status: Commit Queue` squashes it into one commit +whose body keeps every message it contained, with the trailers gathered where +git reads them and `PR-URL` added. ## Subject