From ab457c8bca71b1186772ffba0e32cc15f7c7f932 Mon Sep 17 00:00:00 2001 From: Derek Lewis Date: Mon, 7 Sep 2026 02:55:24 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8F=97=EF=B8=8F=F0=9F=94=A7=EF=BC=9Afix?= =?UTF-8?q?=20the=20settings=20that=20quietly=20do=20nothing?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ported from OpenINF/.github, which carries the corrected spelling of each of these. .ecrc.json said `SpacesAftertabs`. That spelling was deprecated and then removed by editorconfig-checker, which this project pins at 7.0.0, so the key is read by nothing. It is not a behavior change today: the value it sets, `false`, is also the default, so the checker does the same thing either way. What it is is a line that reads as though it configures something and does not, and that stops being harmless the moment the default moves. package.json said `"private": "true"` -- the string, not the boolean. Every consumer of that field tests it for truthiness, so a non-empty string happens to work, and it will keep working right up until something reads it as the boolean the schema says it is. `homepage` said `open.inf.is`, which is a hostname rather than a URL. .deepsource.toml never enabled the shell analyzer, so post-create.sh and post-start.sh -- the two files here most likely to be wrong in a way that only shows up on somebody else's machine -- were analyzed by nothing. Enabled here, along with the explicit `enabled` flags the upstream file carries, test-coverage off because there is none to report, and the prettier transformer off because this project formats with its own prettier configuration and does not want a second opinion committed on top of it. The `[analyzers.meta]` blocks stay where they were relative to the analyzers they belong to; in TOML each attaches to the array entry above it, so the shell analyzer is added before them rather than between one and its meta. .editorconfig now leaves Markdown's indent size unset, because a `1. ` list item continues at three columns and no whole-file indent size describes that. Signed-off-by: Derek Lewis Assisted-by: Claude-Code:claude-opus-5 --- .deepsource.toml | 15 +++++++++++++++ .ecrc.json | 2 +- .editorconfig | 6 ++++++ package.json | 4 ++-- 4 files changed, 24 insertions(+), 3 deletions(-) diff --git a/.deepsource.toml b/.deepsource.toml index abc9d2fcb..d3ce8a3a5 100644 --- a/.deepsource.toml +++ b/.deepsource.toml @@ -4,11 +4,21 @@ exclude_patterns = [ "pnpm-lock.yaml", ] +[[analyzers]] +name = "test-coverage" +enabled = false + +[[analyzers]] +name = "shell" +enabled = true + [[analyzers]] name = "secrets" +enabled = true [[analyzers]] name = "javascript" +enabled = true [analyzers.meta] environment = [ @@ -18,6 +28,11 @@ environment = [ [[analyzers]] name = "docker" +enabled = true [analyzers.meta] dockerfile_paths = [".devcontainer/Dockerfile"] + +[[transformers]] +name = "prettier" +enabled = false diff --git a/.ecrc.json b/.ecrc.json index 8dd8c1e0b..d12afe614 100644 --- a/.ecrc.json +++ b/.ecrc.json @@ -2,7 +2,7 @@ "Verbose": false, "Debug": false, "IgnoreDefaults": true, - "SpacesAftertabs": false, + "SpacesAfterTabs": false, "NoColor": false, "Exclude": [ "js/vendor/", diff --git a/.editorconfig b/.editorconfig index bbee437d7..a19a134af 100644 --- a/.editorconfig +++ b/.editorconfig @@ -9,3 +9,9 @@ indent_size = 2 indent_style = space insert_final_newline = true trim_trailing_whitespace = true + +[*.md] +# Markdown decides its own indentation: a `1. ` list item continues at three +# columns, which is not a multiple of anything above. Left to the linters, +# which read the document as Markdown rather than as lines. +indent_size = unset diff --git a/package.json b/package.json index 68efa370a..f1cce2872 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@openinf/portal", "author": "The OpenINF Authors & Friends", - "private": "true", + "private": true, "description": "The front door to everything OpenINF makes", "packageManager": "pnpm@11.25.0", "engines": { @@ -16,7 +16,7 @@ "./build/pull-request": "./build/shared/pull-request.mts", "./build/utils": "./build/utils.mts" }, - "homepage": "open.inf.is", + "homepage": "https://open.inf.is", "repository": "OpenINF/openinf.github.io", "scripts": { "build": "nps build",