test: write test output to tmp_path, untrack generated FITS artifacts

test_autoarray wrote test *output* into tracked paths, so any change to the
autonerves FITS writer rewrote a committed binary and dirtied the tree for every
contributor. #483 demonstrated it: the PyAutoNerves#155 header-comment fix
([""] -> "") silently modified structures/arrays/files/array/output_test/array.fits
the moment the autonerves floor moved -- identical cards, values, data and byte
size, but a modified tracked file that had to be committed into an unrelated PR.

Applies the durable fix uniformly rather than patching file-by-file again: the
nine tests that wrote into an output_test/ directory now take pytest's tmp_path
and drop their rmtree/makedirs preamble. After a full run no output_test/
directory is created anywhere in the source tree.

Untracks the 13 exposed artifacts. Only one of them was a live output -- the
array.fits that #483 flipped. The other twelve were orphans: no test referenced
their paths, and a repo-wide grep for their basenames returned nothing. They
were residue from tests deleted long ago, as were the two file-by-file
.gitignore lines, now replaced by a test_autoarray/**/output_test/ pattern that
serves as a backstop against a future writer regressing this.

Two incidental fixes fall out. test_uniform_1d and test_uniform_2d both rmtree'd
the same shared output directory, an ordering hazard tmp_path removes. And the
three imaging tests that took the test_data_path fixture wrote their generated
FITS into the source tree via that fixture; they now use tmp_path and the
fixture is gone.

Verified from a clean checkout: 1177 passed, 55 skipped, run twice in a row with
git status clean after each -- the second run is what would catch a test that
had silently depended on a committed artifact.

Closes #494

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QoAeGsJyiaLG4oqXb9n3dM

Author: claude

.gitignore

@@ -6,8 +6,10 @@ test_autoarray/mask/files/mask/mask_out.fits
 test_autoarray/plot/wrap/base/files/
 test_autoarray/structures/grids/files/grid_2d.fits
 
-test_autoarray/dataset/files/array/output_test/uv_wavelengths.fits
-test_autoarray/dataset/files/array/output_test/visibilities.fits
+# Test output: tests write results into output_test/ dirs and read them back.
+# Never track them -- a change to the autonerves FITS writer would otherwise
+# rewrite a committed binary and dirty every contributor's tree (PyAutoArray#483).
+test_autoarray/**/output_test/
 test_autoarray/dataset/plot/files/
 test_autoarray/fit/plot/files/
 test_autoarray/structures/arrays/one_d/files/array/

test_autoarray/dataset/files/array/output_test/noise_map.fits

@@ -1,9 +1,7 @@
 import copy
-import os
 
 import numpy as np
 import pytest
-import shutil
 
 import autoarray as aa
 
@@ -13,18 +11,6 @@
 test_data_path = Path(Path(__file__).resolve().parent) / "files"
 
 
-@pytest.fixture(name="test_data_path")
-def make_test_data_path():
-    test_data_path = Path(__file__).resolve().parent / "files" / "array" / "output_test"
-
-    if test_data_path.exists():
-        shutil.rmtree(test_data_path)
-
-    os.makedirs(test_data_path)
-
-    return test_data_path
-
-
 def test__grid__uses_mask_and_settings__lp_grid_matches_grid_2d_7x7(
     image_7x7,
     noise_map_7x7,
@@ -162,27 +148,25 @@ def test__from_fits__all_data_in_one_fits_file_multiple_hdus__loads_data_psf_noi
     assert dataset.noise_map.mask.pixel_scales == (0.1, 0.1)
 
 
-def test__from_fits__small_datasets_env_caps_data_and_noise_map(
-    test_data_path, monkeypatch
-):
+def test__from_fits__small_datasets_env_caps_data_and_noise_map(tmp_path, monkeypatch):
     """When PYAUTO_SMALL_DATASETS=1, Imaging.from_fits center-crops data and
     noise_map to (15, 15) at pixel_scales=0.6 so they stay shape-consistent
     with masks built via Mask2D.circular under the same env var. PSF is left
     alone."""
     from astropy.io import fits
 
     fits.writeto(
-        Path(test_data_path) / "data_30x30.fits",
+        tmp_path / "data_30x30.fits",
         data=np.ones((30, 30), dtype=np.float64),
         overwrite=True,
     )
     fits.writeto(
-        Path(test_data_path) / "noise_map_30x30.fits",
+        tmp_path / "noise_map_30x30.fits",
         data=2.0 * np.ones((30, 30), dtype=np.float64),
         overwrite=True,
     )
     fits.writeto(
-        Path(test_data_path) / "psf_5x5.fits",
+        tmp_path / "psf_5x5.fits",
         data=(1.0 / 25.0) * np.ones((5, 5), dtype=np.float64),
         overwrite=True,
     )
@@ -191,9 +175,9 @@ def test__from_fits__small_datasets_env_caps_data_and_noise_map(
 
     dataset = aa.Imaging.from_fits(
         pixel_scales=0.08,
-        data_path=Path(test_data_path) / "data_30x30.fits",
-        psf_path=Path(test_data_path) / "psf_5x5.fits",
-        noise_map_path=Path(test_data_path) / "noise_map_30x30.fits",
+        data_path=tmp_path / "data_30x30.fits",
+        psf_path=tmp_path / "psf_5x5.fits",
+        noise_map_path=tmp_path / "noise_map_30x30.fits",
     )
 
     assert dataset.data.shape_native == (16, 16)
@@ -202,20 +186,18 @@ def test__from_fits__small_datasets_env_caps_data_and_noise_map(
     assert dataset.psf.kernel.shape_native == (5, 5)
 
 
-def test__from_fits__small_datasets_env_unset__shape_unchanged(
-    test_data_path, monkeypatch
-):
+def test__from_fits__small_datasets_env_unset__shape_unchanged(tmp_path, monkeypatch):
     """Sanity: with the env var unset, from_fits returns the on-disk shape
     unchanged, even for files larger than the cap."""
     from astropy.io import fits
 
     fits.writeto(
-        Path(test_data_path) / "data_30x30.fits",
+        tmp_path / "data_30x30.fits",
         data=np.ones((30, 30), dtype=np.float64),
         overwrite=True,
     )
     fits.writeto(
-        Path(test_data_path) / "noise_map_30x30.fits",
+        tmp_path / "noise_map_30x30.fits",
         data=2.0 * np.ones((30, 30), dtype=np.float64),
         overwrite=True,
     )
@@ -224,34 +206,32 @@ def test__from_fits__small_datasets_env_unset__shape_unchanged(
 
     dataset = aa.Imaging.from_fits(
         pixel_scales=0.08,
-        data_path=Path(test_data_path) / "data_30x30.fits",
-        noise_map_path=Path(test_data_path) / "noise_map_30x30.fits",
+        data_path=tmp_path / "data_30x30.fits",
+        noise_map_path=tmp_path / "noise_map_30x30.fits",
     )
 
     assert dataset.data.shape_native == (30, 30)
     assert dataset.noise_map.shape_native == (30, 30)
     assert dataset.pixel_scales == (0.08, 0.08)
 
 
-def test__output_to_fits__round_trips_data_psf_noise_map_correctly(
-    imaging_7x7, test_data_path
-):
+def test__output_to_fits__round_trips_data_psf_noise_map_correctly(imaging_7x7, tmp_path):
 
     from autoarray.dataset.plot.imaging_plots import fits_imaging
 
     fits_imaging(
         dataset=imaging_7x7,
-        data_path=Path(test_data_path) / "data.fits",
-        psf_path=Path(test_data_path) / "psf.fits",
-        noise_map_path=Path(test_data_path) / "noise_map.fits",
+        data_path=tmp_path / "data.fits",
+        psf_path=tmp_path / "psf.fits",
+        noise_map_path=tmp_path / "noise_map.fits",
         overwrite=True,
     )
 
     dataset = aa.Imaging.from_fits(
         pixel_scales=0.1,
-        data_path=Path(test_data_path) / "data.fits",
-        psf_path=Path(test_data_path) / "psf.fits",
-        noise_map_path=Path(test_data_path) / "noise_map.fits",
+        data_path=tmp_path / "data.fits",
+        psf_path=tmp_path / "psf.fits",
+        noise_map_path=tmp_path / "noise_map.fits",
     )
 
     assert (dataset.data.native == np.ones((7, 7))).all()