Skip to content

Commit caabe2d

Browse files
author
James Nightingale
authored
Merge pull request #504 from PyAutoLabs/feature/pixelization-fit-cpu-users-docs
docs: correct the config-fallback comments on the NNLS warm-start settings (#506)
2 parents e7e3e3c + 7e4ce98 commit caabe2d

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

‎autoarray/settings.py‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,9 +239,11 @@ def nnls_warm_start_memo(self) -> bool:
239239
try:
240240
return conf.instance["general"]["inversion"]["nnls_warm_start_memo"]
241241
except KeyError:
242-
# Workspaces ship their own general.yaml that shadows autoarray's
243-
# and will not carry this key, so in practice this fallback *is*
244-
# the production default: on, matching the packaged value.
242+
# A workspace `general.yaml` normally omits this key, so autoconf's
243+
# config-path list falls through to autoarray's packaged value (`true`).
244+
# This fallback fires only when the workspace config is the sole config
245+
# path (isolated test configs push one dir) and returns that same value,
246+
# so both routes resolve identically.
245247
return True
246248

247249
return self._nnls_warm_start_memo
@@ -261,9 +263,11 @@ def nnls_warm_start_error_tolerance(self) -> float:
261263
"nnls_warm_start_error_tolerance"
262264
]
263265
except KeyError:
264-
# Workspaces ship their own general.yaml that shadows autoarray's
265-
# and will not carry this key, so in practice this fallback *is*
266-
# the production default, matching the packaged value.
266+
# A workspace `general.yaml` normally omits this key, so autoconf's
267+
# config-path list falls through to autoarray's packaged value (`1.5`).
268+
# This fallback fires only when the workspace config is the sole config
269+
# path (isolated test configs push one dir) and returns that same value,
270+
# so both routes resolve identically.
267271
return 1.5
268272

269273
return self._nnls_warm_start_error_tolerance

0 commit comments

Comments
 (0)