Skip to content

Commit eddc3ba

Browse files
rustyconoverclaude
andcommitted
tests(conformance): add visibility and write_contract checklists
The C++ integration tree has visibility/ and write_contract/ areas with no Python counterpart, which test_directory_parity flags when the vgi checkout is present. Add skip_area stubs listing their .test files, including the new example_table_only, example_insert_finalize and example_decimal_width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 6da4391 commit eddc3ba

2 files changed

Lines changed: 56 additions & 0 deletions

File tree

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# Copyright 2025, 2026 Query Farm LLC - https://query.farm
2+
3+
"""Conformance stub for ``vgi/test/sql/integration/visibility/``.
4+
5+
Protocol 3.3 function visibility (``table_only`` scan and write functions) is
6+
an extension-side contract: the C++ suite checks that a ``table_only`` scan
7+
keeps its capabilities while staying out of ``duckdb_functions()``, against
8+
the ``visfix`` fixture and, in ``example_table_only.test``, against this SDK's
9+
standard example worker (``example.contract``, see
10+
``vgi/_test_fixtures/contract.py``). The worker side, listing table-referenced
11+
functions ``table_only``, is unit-tested by
12+
``tests/catalog/test_function_visibility.py``.
13+
"""
14+
15+
from __future__ import annotations
16+
17+
from tests.conformance._stub import skip_area
18+
19+
skip_area(
20+
"visibility",
21+
[
22+
"example_table_only.test",
23+
"invalid_visibility.test",
24+
"table_only.test",
25+
],
26+
)
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Copyright 2025, 2026 Query Farm LLC - https://query.farm
2+
3+
"""Conformance stub for ``vgi/test/sql/integration/write_contract/``.
4+
5+
Protocol 3.3 write-path contracts the C++ extension enforces: CTAS
6+
``created``, the table-create reply, delete row-id dedupe, MERGE without a
7+
row id, required scan branches, decimal widths on write input, and (in the
8+
``example_*`` files, against this SDK's standard example worker's
9+
``example.contract`` schema, see ``vgi/_test_fixtures/contract.py``) an INSERT
10+
whose count comes from finalize only, worker-enforced NOT NULL, and decimal32 /
11+
decimal64 / decimal128 columns re-encoded at their declared widths.
12+
"""
13+
14+
from __future__ import annotations
15+
16+
from tests.conformance._stub import skip_area
17+
18+
skip_area(
19+
"write_contract",
20+
[
21+
"ctas_not_created.test",
22+
"decimal_width.test",
23+
"delete_rowid_dedupe.test",
24+
"example_decimal_width.test",
25+
"example_insert_finalize.test",
26+
"merge_no_rowid.test",
27+
"scan_branches_required.test",
28+
"table_create_reply.test",
29+
],
30+
)

0 commit comments

Comments
 (0)