From 2ca5d01c0f757f0a93126e6cea81edde5cbeeea7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?I=C3=B1aki=20=C3=9Acar?= Date: Tue, 1 Sep 2026 16:08:04 +0200 Subject: [PATCH 1/2] add -Werror to CXXFLAGS for dev CI job --- .github/workflows/ci.yaml | 4 ++++ ChangeLog | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e8ad0ffa7..3503d6553 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -52,6 +52,7 @@ jobs: - name: dev cntr: rcpp/ci-dev r: RD + cxxflags: -Werror steps: - uses: actions/checkout@v6 @@ -62,6 +63,9 @@ jobs: - name: Build run: ${{matrix.r }} CMD build --no-build-vignettes --no-manual . + - name: Set flags + run: mkdir -p ~/.R && echo "CXXFLAGS += ${{ matrix.cxxflags }}" >> ~/.R/Makevars + - name: Check run: CI=true ${{ matrix.r }} CMD check --no-vignettes --no-manual Rcpp_*.tar.gz diff --git a/ChangeLog b/ChangeLog index a7f24e628..ec6c09ffe 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2026-09-01 Iñaki Ucar + + * .github/workflows/ci.yaml: Add -Werror to CXXFLAGS for dev CI job + 2026-08-08 Dirk Eddelbuettel * DESCRIPTION (Version, Date): Roll micro version and date From ec3e68ed9521e6360406a2d703fcacf2b207ada0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?I=C3=B1aki=20=C3=9Acar?= Date: Tue, 1 Sep 2026 17:03:37 +0200 Subject: [PATCH 2/2] implement this in a new yaml file instead --- .github/workflows/ci.yaml | 4 ---- .github/workflows/warnings.yaml | 36 +++++++++++++++++++++++++++++++++ ChangeLog | 2 +- 3 files changed, 37 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/warnings.yaml diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3503d6553..e8ad0ffa7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -52,7 +52,6 @@ jobs: - name: dev cntr: rcpp/ci-dev r: RD - cxxflags: -Werror steps: - uses: actions/checkout@v6 @@ -63,9 +62,6 @@ jobs: - name: Build run: ${{matrix.r }} CMD build --no-build-vignettes --no-manual . - - name: Set flags - run: mkdir -p ~/.R && echo "CXXFLAGS += ${{ matrix.cxxflags }}" >> ~/.R/Makevars - - name: Check run: CI=true ${{ matrix.r }} CMD check --no-vignettes --no-manual Rcpp_*.tar.gz diff --git a/.github/workflows/warnings.yaml b/.github/workflows/warnings.yaml new file mode 100644 index 000000000..357b5b4ae --- /dev/null +++ b/.github/workflows/warnings.yaml @@ -0,0 +1,36 @@ +# Run CI for R using https://eddelbuettel.github.io/r-ci/ + +name: warnings + +on: + push: + pull_request: + +env: + _R_CHECK_FORCE_SUGGESTS_: "false" + RCPP_CXXFLAGS: "-Werror" + +jobs: + ci: + runs-on: ubuntu-latest + container: rocker/drd + + steps: + - name: Checkout + uses: actions/checkout@v7 + + - name: Setup + uses: eddelbuettel/github-actions/r-ci@master + + - name: Dependencies + run: ./run.sh install_deps + + - name: Set flags + run: mkdir -p ~/.R && echo "CXXFLAGS += $RCPP_CXXFLAGS" >> ~/.R/Makevars + + - name: Test + run: ./run.sh run_tests + + - name: Logs + run: ./run.sh dump_logs + if: failure() diff --git a/ChangeLog b/ChangeLog index ec6c09ffe..81c32a802 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,6 @@ 2026-09-01 Iñaki Ucar - * .github/workflows/ci.yaml: Add -Werror to CXXFLAGS for dev CI job + * .github/workflows/warnings.yaml: Add new CI file with -Werror enabled 2026-08-08 Dirk Eddelbuettel