From d72e21a425366ad62aa7739b9daf460f97cb776c Mon Sep 17 00:00:00 2001 From: Gianluca Petrillo Date: Mon, 2 Nov 2026 11:24:28 -0600 Subject: [PATCH] CMakeLists.txt: larsim dependency EXPORTed, removed unused dk2nu* dk2nugenie is not used in sbncode codebase; however, it was EXPORTed so that dependent repositories could use it without explicitly including it. CMake's dk2nugenie finding function is provided in nufinder package, which was not included: sbncode relied on other dependencies (namely, larsim) to export it. However larsim dependency is not EXPORTed. The net result is that sbncode builds, but a package including only sbncode won't: since sbncode exports dk2nugenie, CMake implicitly tries to import it; but nufinder is not implicitly imported, so importing dk2nugenie will fail. nufinder may happen to be indirectly imported by other packaged (larsim above), in which case building still forks. Otherwise, a CMake error occurs. This commit removes dk2nugenie explicit import since it is not used directly. To make sure that dependent packages can keep using it without breakage, larsim itself is EXPORTed. --- CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a1a441be4..1bf756fd0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -58,7 +58,7 @@ find_package( lardataalg REQUIRED ) find_package( larcore REQUIRED ) find_package( lardata REQUIRED ) find_package( larevt REQUIRED ) -find_package( larsim REQUIRED ) +find_package( larsim EXPORT REQUIRED ) find_package( larreco REQUIRED ) find_package( larrecodnn REQUIRED ) find_package( larpandora REQUIRED ) @@ -71,7 +71,6 @@ find_package( ifdh_art REQUIRED ) find_package( ifbeam REQUIRED ) find_package( libwda REQUIRED ) find_package( dk2nudata REQUIRED ) -find_package( dk2nugenie EXPORT REQUIRED ) find_package( log4cpp REQUIRED ) find_package( LibXml2 REQUIRED ) find_package( CLHEP REQUIRED )