fix: load materializations before destroy snapshot reads

Signed-off-by: lafirm <136463254+lafirm@users.noreply.github.com>

Author: lafirm

sqlmesh/core/context.py

@@ -1019,6 +1019,9 @@ def run_janitor(
 
     @python_api_analytics
     def destroy(self) -> bool:
+        # Load materializations before any state writes so a failure aborts destroy without invalidating environments
+        self._load_materializations()
+
         success = False
 
         # Collect resources to be deleted
@@ -3158,9 +3161,6 @@ def _context_diff(
         )
 
     def _destroy(self) -> bool:
-        # Load materializations before any state writes so a failure aborts destroy without invalidating environments
-        self._load_materializations()
-
         # Invalidate all environments, including prod
         for environment in self.state_reader.get_environments():
             self.state_sync.invalidate_environment(name=environment.name, protect_prod=False)

tests/core/integration/test_aux_commands.py

@@ -125,7 +125,7 @@ def test_destroy_fails_before_invalidating_environments_on_materialization_error
     context._materializations_loaded = False
 
     with pytest.raises(SQLMeshError, match="broken materialization"):
-        context._destroy()
+        context.destroy()
 
     assert context.state_reader.get_environment("prod").expiration_ts is None
 

tests/core/test_context.py

@@ -363,6 +363,34 @@ def test_diff(sushi_context: Context, mocker: MockerFixture):
     assert success
 
 
+def test_destroy_loads_materializations_before_reading_state(mocker: MockerFixture):
+    context = Context(config=Config(), load=False)
+    calls = []
+    environment = mocker.Mock(snapshots=[])
+
+    with (
+        patch.object(
+            context,
+            "_load_materializations",
+            side_effect=lambda: calls.append("materializations"),
+        ),
+        patch.object(
+            context.state_reader,
+            "get_environments",
+            side_effect=lambda: calls.append("environments") or [environment],
+        ),
+        patch.object(
+            context.state_reader,
+            "get_snapshots",
+            side_effect=lambda _: calls.append("snapshots") or {},
+        ),
+        patch.object(context.console, "start_destroy", return_value=False),
+    ):
+        context.destroy()
+
+    assert calls == ["materializations", "environments", "snapshots"]
+
+
 @pytest.mark.slow
 def test_evaluate_limit():
     context = Context(config=Config())