From bd412d22cc9d44ccac63eb0033d3acdf769f26dc Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Tue, 17 Nov 2026 15:56:50 +0100 Subject: [PATCH 1/4] Fix: use `zarr.storage.LocalStore()` instead of `str()` (#4945) --- src/spikeinterface/core/tests/test_zarrextractors.py | 9 +++++++++ src/spikeinterface/core/zarr_tools.py | 12 ++++++++++++ src/spikeinterface/core/zarrextractors.py | 8 ++++---- 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a/src/spikeinterface/core/tests/test_zarrextractors.py b/src/spikeinterface/core/tests/test_zarrextractors.py index e8c76018de..b0b69d1313 100644 --- a/src/spikeinterface/core/tests/test_zarrextractors.py +++ b/src/spikeinterface/core/tests/test_zarrextractors.py @@ -186,3 +186,12 @@ def test_ZarrSortingExtractor_lazy_search(tmp_path): test_ZarrSortingExtractor(tmp_path) test_ZarrSampleIndexSearch(tmp_path) test_ZarrSortingExtractor_lazy_search(tmp_path) + + +def test_zarr_path_with_hash(tmp_path): + # zarr 3 parses str paths as URLs, truncating them at '#' + folder = tmp_path / "Record Node 103#Probe.zarr" + sorting = generate_sorting(durations=[2], num_units=3) + ZarrSortingExtractor.write_sorting(sorting, folder) + loaded = ZarrSortingExtractor(folder) + assert loaded.get_num_units() == 3 diff --git a/src/spikeinterface/core/zarr_tools.py b/src/spikeinterface/core/zarr_tools.py index a12c4ceec2..9bffd3e3bc 100644 --- a/src/spikeinterface/core/zarr_tools.py +++ b/src/spikeinterface/core/zarr_tools.py @@ -537,3 +537,15 @@ def build_codec_pipeline(filters=None, compressors=None): codec_kwargs["serializer"] = serializers[0] if len(serializers) == 1 else "auto" codec_kwargs["compressors"] = byte_compressors return codec_kwargs + + +def local_zarr_store(path): + """ + Return a zarr LocalStore for local paths (remote paths are returned as str). + Passing a plain str to zarr 3 parses it as a URL, so characters like '#' truncate the path. + """ + from .core_tools import is_path_remote + + if is_path_remote(str(path)): + return str(path) + return zarr.storage.LocalStore(path) diff --git a/src/spikeinterface/core/zarrextractors.py b/src/spikeinterface/core/zarrextractors.py index 9f06b80e3e..002a5c756a 100644 --- a/src/spikeinterface/core/zarrextractors.py +++ b/src/spikeinterface/core/zarrextractors.py @@ -17,7 +17,7 @@ is_path_remote, ) from .job_tools import split_job_kwargs, fix_job_kwargs -from .zarr_tools import iterate_zarr_group, adjust_chunks_shards_and_job_kwargs, build_codec_pipeline +from .zarr_tools import local_zarr_store, iterate_zarr_group, adjust_chunks_shards_and_job_kwargs, build_codec_pipeline from .time_series_tools import _write_time_series_to_zarr # The spike vector uses the numcodecs Delta filter (not in the zarr v3 spec) because it greatly @@ -97,7 +97,7 @@ def super_zarr_open(folder_path: str | Path, mode: str = "r", storage_options: d raise ValueError(f"Folder {folder_path} does not exist") for use_consolidated in use_consolidated_options: try: - root = zarr.open(str(folder_path), mode=mode, use_consolidated=use_consolidated) + root = zarr.open(local_zarr_store(folder_path), mode=mode, use_consolidated=use_consolidated) break except Exception as e: exception = e @@ -266,7 +266,7 @@ def write_recording( **kwargs, ): folder_path = create_zarr_path_for_write(folder_path, overwrite=overwrite) - zarr_root = zarr.open(str(folder_path), mode="w", storage_options=storage_options) + zarr_root = zarr.open(local_zarr_store(folder_path), mode="w", storage_options=storage_options) zarr_root.attrs["zarr_class_info"] = retrieve_importing_provenance(ZarrRecordingExtractor) add_recording_to_zarr_group(recording, zarr_root, **kwargs) return ZarrRecordingExtractor(folder_path, storage_options=storage_options) @@ -676,7 +676,7 @@ def write_sorting( Write a sorting extractor to zarr format. """ folder_path = create_zarr_path_for_write(folder_path, overwrite=overwrite) - zarr_root = zarr.open(str(folder_path), mode="w", storage_options=storage_options) + zarr_root = zarr.open(local_zarr_store(folder_path), mode="w", storage_options=storage_options) zarr_root.attrs["zarr_class_info"] = retrieve_importing_provenance(ZarrSortingExtractor) add_sorting_to_zarr_group(sorting, zarr_root, relative_to=relative_to, **kwargs) return ZarrSortingExtractor(folder_path, storage_options=storage_options) From 8db42867be7c3bbd2357c941689a998e377a0645 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Tue, 17 Nov 2026 16:19:36 +0100 Subject: [PATCH 2/4] Prepare 0.106.1 patch release --- doc/releases/0.106.1.rst | 17 +++++++++++++++++ doc/whatisnew.rst | 21 +++++++++++++++++++-- pyproject.toml | 2 +- 3 files changed, 37 insertions(+), 3 deletions(-) create mode 100644 doc/releases/0.106.1.rst diff --git a/doc/releases/0.106.1.rst b/doc/releases/0.106.1.rst new file mode 100644 index 0000000000..1d2e22fafc --- /dev/null +++ b/doc/releases/0.106.1.rst @@ -0,0 +1,17 @@ +.. _release0.106.1: + +SpikeInterface 0.106.1 release notes +------------------------------------ + +November 17th 2026 + +Minor release with bug fixes + +core: + +* Fix: use ``zarr.storage.LocalStore()`` instead of ``str()`` (#4945) + + +Contributors: + +* @alejoe91 diff --git a/doc/whatisnew.rst b/doc/whatisnew.rst index b37180599b..39c01c2c2f 100644 --- a/doc/whatisnew.rst +++ b/doc/whatisnew.rst @@ -8,6 +8,7 @@ Release notes .. toctree:: :maxdepth: 1 + releases/0.106.1.rst releases/0.106.0.rst releases/0.105.4.rst releases/0.105.3.rst @@ -68,8 +69,24 @@ Release notes releases/0.9.1.rst -Versions 0.105.1 -================ +Version 0.106.1 +=============== + +Minor releases with bug fixes + +Version 0.106.0 +=============== + +* Added support for Zarr v3, with zarr shards computed one chunk at a time and waveforms extracted directly to Zarr datasets (#4260, #4907, #4708) +* Added session displacement generation to the generators and motion correction modules (#3231) +* Added the ``VanillaSort`` external sorter and the ``NeuroExplorerSortingExtractor`` (#4832, #4825) +* Added support for Python 3.14 (#4173) +* Removed the ``BaseSnippets`` class (#4839) +* Reduced peak memory usage in several preprocessors (``gaussian_filter``, filters) and in extensions through ``SpikeRetriever`` and ``UnitSelectionSorting`` optimizations (#4903, #4840, #4809, #4783) +* Significant speedups in template similarity (#4785), amplitude scalings (#4870), phase shift and ``gaussian_filter`` FFTs (#4802, #4853), and Wobble peak search (#4782) + +Versions 0.105.1/4 +================== * Minor releases with bug fixes and performance improvements diff --git a/pyproject.toml b/pyproject.toml index 27e99729e7..8b748550ca 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "spikeinterface" -version = "0.106.0" +version = "0.106.1" authors = [ { name="Alessio Buccino", email="alessiop.buccino@gmail.com" }, { name="Samuel Garcia", email="sam.garcia.die@gmail.com" }, From 9a99b7ca65a74d27c80e4760da245c1bea615a55 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Wed, 18 Nov 2026 12:23:41 +0100 Subject: [PATCH 3/4] Dartsort: fix passing pre-computed `si_motion` (#4953) --- src/spikeinterface/sorters/external/dartsort.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/spikeinterface/sorters/external/dartsort.py b/src/spikeinterface/sorters/external/dartsort.py index 8e66f7929b..3667e80d5f 100644 --- a/src/spikeinterface/sorters/external/dartsort.py +++ b/src/spikeinterface/sorters/external/dartsort.py @@ -4,7 +4,7 @@ import numpy as np from ..basesorter import BaseSorter -from ...core import load +from ...core import load, Motion class DartsortSorter(BaseSorter): @@ -41,6 +41,9 @@ def _dynamic_params(cls): for k, props in schema["$defs"]["DARTsortUserConfig"]["properties"].items(): default_params_descriptions[k] = props["title"] + default_params.update({"si_motion": None}) + default_params_descriptions.update({"si_motion": "SpikeInterface motion object (optional)"}) + return default_params, default_params_descriptions @classmethod @@ -67,7 +70,9 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): recording = cls.load_recording_from_folder(sorter_output_folder.parent, with_warnings=False) # Dartsort can be given the motion object optionaly - motion = params.pop("motion", None) + si_motion = params.pop("si_motion", None) + if si_motion is not None: + si_motion = Motion.from_dict(si_motion) # dartsort config are set using dataclass we need to map this cfg = DARTsortUserConfig(**params) @@ -76,7 +81,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): recording, sorter_output_folder, cfg, - motion=motion, + si_motion=si_motion, ) # the DARTsortSorting is not the spikeinterface sorting dartsort_sorting = ret["sorting"] From 85076b23b14e6dc61b5f18360e61740e7ef8d5d5 Mon Sep 17 00:00:00 2001 From: Siddhardha Nanda <99672439+SID-6921@users.noreply.github.com> Date: Wed, 18 Nov 2026 04:40:02 -0500 Subject: [PATCH 4/4] Fix compute_amplitude_cutoffs() default num_histogram_bins left at 500 after #4415 (#4943) --- src/spikeinterface/metrics/quality/misc_metrics.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spikeinterface/metrics/quality/misc_metrics.py b/src/spikeinterface/metrics/quality/misc_metrics.py index 016a2d24f9..9da3db160b 100644 --- a/src/spikeinterface/metrics/quality/misc_metrics.py +++ b/src/spikeinterface/metrics/quality/misc_metrics.py @@ -922,7 +922,7 @@ def compute_amplitude_cutoffs( sorting_analyzer, unit_ids=None, periods=None, - num_histogram_bins=500, + num_histogram_bins=100, histogram_smoothing_value=3, amplitudes_bins_min_ratio=5, ): @@ -1639,7 +1639,7 @@ def amplitude_cutoff( ---------- amplitudes : ndarray_like The amplitudes (in µV) of the spikes for one unit. - num_histogram_bins : int, default: 500 + num_histogram_bins : int, default: 100 The number of bins to use to compute the amplitude histogram. histogram_smoothing_value : int, default: 3 Controls the smoothing applied to the amplitude histogram.