From f80dec458c2035b9fea35a97da9af17b0bce3a98 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Wed, 18 Nov 2026 12:23:41 +0100 Subject: [PATCH 1/2] Dartsort: fix passing pre-computed `si_motion` (#4953) --- src/spikeinterface/sorters/external/dartsort.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/spikeinterface/sorters/external/dartsort.py b/src/spikeinterface/sorters/external/dartsort.py index daad3ec555..17c1e7a4f0 100644 --- a/src/spikeinterface/sorters/external/dartsort.py +++ b/src/spikeinterface/sorters/external/dartsort.py @@ -3,7 +3,7 @@ import numpy as np from ..basesorter import BaseSorter -from ...core import load +from ...core import load, Motion class DartsortSorter(BaseSorter): @@ -40,6 +40,9 @@ def _dynamic_params(cls): for k, props in schema["$defs"]["DARTsortUserConfig"]["properties"].items(): default_params_descriptions[k] = props["title"] + default_params.update({"si_motion": None}) + default_params_descriptions.update({"si_motion": "SpikeInterface motion object (optional)"}) + return default_params, default_params_descriptions @classmethod @@ -73,7 +76,9 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): recording = cls.load_recording_from_folder(sorter_output_folder.parent, with_warnings=False) # Dartsort can be given the motion object optionaly - motion = params.pop("motion", None) + si_motion = params.pop("si_motion", None) + if si_motion is not None: + si_motion = Motion.from_dict(si_motion) # dartsort config are set using dataclass we need to map this cfg = DARTsortUserConfig(**params) @@ -82,7 +87,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): recording, sorter_output_folder, cfg, - motion=motion, + si_motion=si_motion, ) # the DARTsortSorting is not the spikeinterface sorting dartsort_sorting = ret["sorting"] From b0d3843fc386590bc0dab9487885973dd56360c3 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Wed, 18 Nov 2026 12:26:27 +0100 Subject: [PATCH 2/2] prepare 0.105.5 patch-release --- doc/releases/0.105.5.rst | 17 +++++++++++++++++ doc/whatisnew.rst | 3 ++- pyproject.toml | 2 +- 3 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 doc/releases/0.105.5.rst diff --git a/doc/releases/0.105.5.rst b/doc/releases/0.105.5.rst new file mode 100644 index 0000000000..8526bf9f51 --- /dev/null +++ b/doc/releases/0.105.5.rst @@ -0,0 +1,17 @@ +.. _release0.105.5: + +SpikeInterface 0.105.5 release notes +------------------------------------ + +November 18th 2026 + +Minor release with bug fixes + +sorters: + +* Dartsort: fix passing pre-computed ``si_motion`` (#4953) + + +Contributors: + +* @alejoe91 diff --git a/doc/whatisnew.rst b/doc/whatisnew.rst index cd841b3a6c..abd5fff667 100644 --- a/doc/whatisnew.rst +++ b/doc/whatisnew.rst @@ -8,6 +8,7 @@ Release notes .. toctree:: :maxdepth: 1 + releases/0.105.5.rst releases/0.105.4.rst releases/0.105.3.rst releases/0.105.2.rst @@ -67,7 +68,7 @@ Release notes releases/0.9.1.rst -Versions 0.105.1/4 +Versions 0.105.1/5 ================== * Minor releases with bug fixes and performance improvements diff --git a/pyproject.toml b/pyproject.toml index 1741e6b873..e416aca4b6 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "spikeinterface" -version = "0.105.4" +version = "0.105.5" authors = [ { name="Alessio Buccino", email="alessiop.buccino@gmail.com" }, { name="Samuel Garcia", email="sam.garcia.die@gmail.com" },