From 2ab2bd848acff0ff4e370cf24b3ecc179dd26c26 Mon Sep 17 00:00:00 2001 From: Daniel McCoy Stephenson Date: Wed, 11 Nov 2026 21:07:02 -0700 Subject: [PATCH] Test that a blank name is never mentioned to the Logger The README promises a report with an empty or blank name is ignored "without a mention to the Logger", but reportIgnoresABlankName attaches no Logger. The new test sends blank names through every report overload alongside one real report to a server answering 500, so the Logger is seen to be listening and hears only that one drop. Co-Authored-By: Claude Opus 5.5 --- test/test_trace_client.cpp | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/test/test_trace_client.cpp b/test/test_trace_client.cpp index 430e4a6..8e79fe8 100644 --- a/test/test_trace_client.cpp +++ b/test/test_trace_client.cpp @@ -792,6 +792,22 @@ static void reportIgnoresABlankName() { CHECK_EQ(0u, server.received().size()); } +static void aBlankNameIsNeverMentionedToTheLogger() { + StubServer server; + server.status = 500; // the report that does go out is a drop, so the logger is seen to be listening + Log log; + trace_client::TraceClient client(server.baseUrl(), "MyGame", "1.2.3", "k", true, log.logger()); + client.report(""); + client.report(" \t\r\n\v\f", {{"level", "forest"}}); + client.report(" ", 3.0, {{"level", "forest"}}); + client.report("startup"); + client.close(); + CHECK_EQ(1u, server.received().size()); + CHECK_EQ(1u, log.lines.size()); + CHECK_EQ(1u, log.count("answered 500")); + CHECK_EQ(1u, log.count("\"name\":\"startup\"")); +} + static void jsonIsEscapedAndCleaned() { using trace_client::detail::json; CHECK_EQ(std::string("{\"application\":\"A\\\"pp\",\"name\":\"n\\\\\",\"tags\":{\"ok\":\"line\\nbreak\\t\\u0001\"}}"), @@ -1819,6 +1835,7 @@ int main() { {"aBlankBaseUrlIsUnavailable", aBlankBaseUrlIsUnavailable}, {"surroundingWhitespaceIsNotSent", surroundingWhitespaceIsNotSent}, {"reportIgnoresABlankName", reportIgnoresABlankName}, + {"aBlankNameIsNeverMentionedToTheLogger", aBlankNameIsNeverMentionedToTheLogger}, {"jsonIsEscapedAndCleaned", jsonIsEscapedAndCleaned}, {"tagsAreHeldToTheServerLimits", tagsAreHeldToTheServerLimits}, {"cleanUtf8ReplacesEveryMalformedSequence", cleanUtf8ReplacesEveryMalformedSequence},