From 83704c3d0631c32cc3a5284371083ded5f299c43 Mon Sep 17 00:00:00 2001 From: Daniel McCoy Stephenson Date: Wed, 11 Nov 2026 19:41:27 -0700 Subject: [PATCH] Test a blank key's disabled reason and an empty install ID file The README promises that a blank key disables reporting with the reason "no key", and that an install ID file holding no valid line is replaced with a fresh ID. Neither case had a test of its own: a blank key was only checked for sending nothing, and the replaced file held junk lines rather than nothing at all. Co-Authored-By: Claude Opus 5.5 --- tests/TraceClient.Tests/InstallIdTest.cs | 18 ++++++++++++++++++ tests/TraceClient.Tests/TraceClientTest.cs | 12 ++++++++++++ 2 files changed, 30 insertions(+) diff --git a/tests/TraceClient.Tests/InstallIdTest.cs b/tests/TraceClient.Tests/InstallIdTest.cs index 69a4913..4880c9a 100644 --- a/tests/TraceClient.Tests/InstallIdTest.cs +++ b/tests/TraceClient.Tests/InstallIdTest.cs @@ -73,6 +73,24 @@ public void InstallIdFromFile_ReadsTheFirstValidLineAndReplacesAFileWithoutOne() Assert.Equal(fresh, TraceClient.InstallIdFromFile(junk)); } + [Theory] + [InlineData("")] + [InlineData(" \n\t\n")] + public void InstallIdFromFile_ReplacesAnEmptyOrBlankFileWithAFreshId(string contents) + { + // A file that exists but holds nothing -- touched by hand, or cut off + // while being written -- is treated like a missing one. + Directory.CreateDirectory(_directory); + string path = Path.Combine(_directory, "install-id"); + File.WriteAllText(path, contents); + + string id = TraceClient.InstallIdFromFile(path); + + Assert.True(IsGuid(id), id); + Assert.Equal(id + "\n", File.ReadAllText(path)); + Assert.Equal(id, TraceClient.InstallIdFromFile(path)); + } + [Fact] public void InstallIdFromFile_KeepsALineExactlyAtTheLimit() { diff --git a/tests/TraceClient.Tests/TraceClientTest.cs b/tests/TraceClient.Tests/TraceClientTest.cs index 6fa4a32..a71dbf0 100644 --- a/tests/TraceClient.Tests/TraceClientTest.cs +++ b/tests/TraceClient.Tests/TraceClientTest.cs @@ -376,6 +376,18 @@ public void DisabledReason_NamesTheConfigFlagOrTheMissingKey() Assert.Equal("config", TraceClient.Disabled().DisabledReason); } + [Theory] + [InlineData("")] + [InlineData(" ")] + [InlineData("\t\n")] + public void DisabledReason_TreatsABlankKeyAsNoKey(string key) + { + var client = new TraceClient(_server.BaseUrl, "MyGame", "1.2.3", key: key); + + Assert.False(client.IsEnabled); + Assert.Equal(TraceClient.ReasonNoKey, client.DisabledReason); + } + [Theory] [InlineData("off")] [InlineData("OFF")]