Skip to content

Commit 02ebe07

Browse files
authored
fix(maths): correct coordinate subtraction in DistanceFormula.euclideanDistance (#7747)
1 parent c468089 commit 02ebe07

2 files changed

Lines changed: 19 additions & 4 deletions

File tree

‎src/main/java/com/thealgorithms/maths/DistanceFormula.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ private DistanceFormula() {
66

77
public static double euclideanDistance(double x1, double y1, double x2, double y2) {
88
double dX = Math.pow(x2 - x1, 2);
9-
double dY = Math.pow(y2 - x1, 2);
9+
double dY = Math.pow(y2 - y1, 2);
1010
return Math.sqrt(dX + dY);
1111
}
1212

‎src/test/java/com/thealgorithms/maths/DistanceFormulaTest.java‎

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,32 @@ void euclideanTest1() {
1414

1515
@Test
1616
void euclideanTest2() {
17-
Assertions.assertEquals(7.0710678118654755, DistanceFormula.euclideanDistance(1, 3, 8, 0));
17+
Assertions.assertEquals(7.615773105863909, DistanceFormula.euclideanDistance(1, 3, 8, 0));
1818
}
1919

2020
@Test
2121
void euclideanTest3() {
22-
Assertions.assertEquals(110.91911467371168, DistanceFormula.euclideanDistance(2.4, 9.1, 55.1, 100));
22+
Assertions.assertEquals(105.07188015829927, DistanceFormula.euclideanDistance(2.4, 9.1, 55.1, 100));
2323
}
2424

2525
@Test
2626
void euclideanTest4() {
27-
Assertions.assertEquals(19022.067605809836, DistanceFormula.euclideanDistance(1000, 13, 20000, 84));
27+
Assertions.assertEquals(19000.13265743163, DistanceFormula.euclideanDistance(1000, 13, 20000, 84));
28+
}
29+
30+
@Test
31+
void euclideanTestZeroDistance() {
32+
Assertions.assertEquals(0.0, DistanceFormula.euclideanDistance(0, 0, 0, 0));
33+
}
34+
35+
@Test
36+
void euclideanTestPythagoreanTriple() {
37+
Assertions.assertEquals(5.0, DistanceFormula.euclideanDistance(0, 0, 3, 4));
38+
}
39+
40+
@Test
41+
void euclideanTestNegativeCoordinates() {
42+
Assertions.assertEquals(5.0, DistanceFormula.euclideanDistance(-1, -2, 2, 2));
2843
}
2944

3045
@Test

0 commit comments

Comments
 (0)