From ba26cc2efb88896ac2f81866c71a79ba9e3af20c Mon Sep 17 00:00:00 2001 From: MachoPiggies Date: Sun, 8 Nov 2026 17:19:51 +0000 Subject: [PATCH 1/2] Fixed issue where single option inputs would progress forward regardless of click type --- .../provider/ChestDialogViewProvider.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java index 440ba9dd4..eed5f28fe 100644 --- a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java +++ b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java @@ -189,7 +189,7 @@ public boolean clickDialog(final UserConnection connection, final int container, } else if (widget instanceof final TextInput textInput) { clickTextInput(connection, textInput); } else if (widget instanceof final SingleOptionInput singleOptionInput) { - clickSingleOptionInput(singleOptionInput); + clickSingleOptionInput(singleOptionInput, mouse); } else if (widget instanceof final Button button) { clickButton(connection, storage.dialog().afterAction(), button); } else if (widget instanceof final Dialog dialog) { @@ -387,8 +387,13 @@ protected Item getSingleOptionInput(final UserConnection connection, final Singl ); } - protected void clickSingleOptionInput(final SingleOptionInput singleOptionInput) { - singleOptionInput.setClampedValue(singleOptionInput.value() + 1); + protected void clickSingleOptionInput(final SingleOptionInput singleOptionInput, final int mouse) { + final int current = singleOptionInput.value(); + final int optionCount = singleOptionInput.options().length; + switch (mouse) { + case 0 -> singleOptionInput.setValue((current + 1) % optionCount); + case 1 -> singleOptionInput.setValue(Math.floorMod(current - 1, optionCount)); + } } protected Item getButton(final UserConnection connection, final Button button) { From 817547370172c212c91cef3927615d3f32c0e511 Mon Sep 17 00:00:00 2001 From: MachoPiggies Date: Sun, 8 Nov 2026 17:20:27 +0000 Subject: [PATCH 2/2] Fixed issue where options.generic_value was missed from translation mappings, causing single option and slider buttons to hold invalid names --- .../resources/assets/viabackwards/data/translation-mappings.json | 1 + 1 file changed, 1 insertion(+) diff --git a/common/src/main/resources/assets/viabackwards/data/translation-mappings.json b/common/src/main/resources/assets/viabackwards/data/translation-mappings.json index e67b1486b..139a15750 100644 --- a/common/src/main/resources/assets/viabackwards/data/translation-mappings.json +++ b/common/src/main/resources/assets/viabackwards/data/translation-mappings.json @@ -3632,6 +3632,7 @@ "1.16.2": { "multiplayer.disconnect.missing_tags": "Incomplete set of tags received from server.\nPlease contact server operator.", "chat.square_brackets": "[%s]", + "options.generic_value": "%s: %s", "disconnect.exceeded_packet_rate": "Kicked for exceeding packet rate limit", "item.minecraft.piglin_brute_spawn_egg": "Piglin Brute Spawn Egg", "entity.minecraft.piglin_brute": "Piglin Brute",