From 02ba9b31c150d9b9c2e837962647b39ab42eb33e Mon Sep 17 00:00:00 2001
From: Trigg <triggerhapp@gmail.com>
Date: Sun, 1 Nov 2026 11:41:34 +0000
Subject: [PATCH] chore: add metadata lint ci step chore: cleaned out left over
 spaces in metadata

---
 .github/workflows/ci.yaml | 22 ++++++++++++
 metadata/dock.xml         |  4 +--
 metadata/locker.xml       | 70 +++++++++++++++++++--------------------
 metadata/panel.xml        |  8 ++---
 4 files changed, 63 insertions(+), 41 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 9fe95a03..27db0f67 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -99,3 +99,25 @@ jobs:
           wget https://raw.githubusercontent.com/WayfireWM/wayfire/master/uncrustify.ini
           git ls-files | grep "hpp$\|cpp$" | xargs ../uncrustify/build/uncrustify -c uncrustify.ini --no-backup --replace
           git diff --exit-code
+
+  lint-xml:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+
+      - name: Install xmlstarlet
+        run: sudo apt-get update && sudo apt-get install -y xmlstarlet
+
+      - name: Check XML
+        run: |
+          find metadata -name "*.xml" -exec xmlstarlet val --well-formed {} +
+
+      - name: Check XML Format
+        run: |
+          while IFS= read -r file; do
+            echo "File : ${file}"
+            xmlstarlet fo --indent-tab "$file" > "${file}.tmp"
+            diff -u "$file" "${file}.tmp"
+          done < <(find metadata -name "*.xml*")
diff --git a/metadata/dock.xml b/metadata/dock.xml
index 5b117a6b..f6f8f52c 100644
--- a/metadata/dock.xml
+++ b/metadata/dock.xml
@@ -5,7 +5,7 @@
 		<category>Shell</category>
 		<option name="css_path" type="string">
 			<_short>CSS Path</_short>
-			<default></default>
+			<default/>
 		</option>
 		<option name="autohide" type="bool">
 			<_short>Autohide</_short>
@@ -89,7 +89,7 @@
 			<default>20</default>
 		</option>
 		<option name="show_close" type="bool">
-		    <_short>Show Close Animations</_short>
+			<_short>Show Close Animations</_short>
 			<_long>Keep all window icons for up to 2 seconds to allow CSS animations.</_long>
 			<default>true</default>
 		</option>
diff --git a/metadata/locker.xml b/metadata/locker.xml
index 872ac801..b2dbe89a 100644
--- a/metadata/locker.xml
+++ b/metadata/locker.xml
@@ -100,8 +100,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -134,7 +134,7 @@
 				<default>center-center</default>
 			</option>
 			<option name="password_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>false</default>
 			</option>
 		</group>
@@ -151,8 +151,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -193,7 +193,7 @@
 				<default>2em default</default>
 			</option>
 			<option name="pin_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>false</default>
 			</option>
 		</group>
@@ -210,8 +210,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -260,7 +260,7 @@
 				<max>20</max>
 			</option>
 			<option name="fingerprint_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>false</default>
 			</option>
 		</group>
@@ -276,8 +276,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -310,8 +310,8 @@
 				<default>top-right</default>
 			</option>
 			<option name="network_always" type="bool">
-			    <_short>Always show</_short>
-			    <default>true</default>
+				<_short>Always show</_short>
+				<default>true</default>
 			</option>
 			<option name="network_font" type="string">
 				<_short>Network Font</_short>
@@ -340,8 +340,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -374,8 +374,8 @@
 				<default>top-center</default>
 			</option>
 			<option name="clock_always" type="bool">
-			    <_short>Always show</_short>
-			    <default>true</default>	
+				<_short>Always show</_short>
+				<default>true</default>
 			</option>
 			<option name="clock_font" type="string">
 				<_short>Clock Font</_short>
@@ -394,8 +394,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -438,7 +438,7 @@
 				<max>10</max>
 			</option>
 			<option name="weather_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>true</default>
 			</option>
 		</group>
@@ -454,8 +454,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -498,7 +498,7 @@
 				<max>20</max>
 			</option>
 			<option name="user_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>true</default>
 			</option>
 		</group>
@@ -529,8 +529,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -563,7 +563,7 @@
 				<default>bottom-right</default>
 			</option>
 			<option name="mpris_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>false</default>
 			</option>
 			<option name="mpris_icon_size" type="double">
@@ -605,8 +605,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -653,7 +653,7 @@
 				<max>10</max>
 			</option>
 			<option name="battery_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>true</default>
 			</option>
 		</group>
@@ -669,8 +669,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -703,7 +703,7 @@
 				<default>top-right</default>
 			</option>
 			<option name="volume_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>false</default>
 			</option>
 			<option name="volume_icon_size" type="double">
@@ -726,8 +726,8 @@
 					<_name>Top Left</_name>
 				</desc>
 				<desc>
-				    <value>top-center</value>
-			        <_name>Top</_name>
+					<value>top-center</value>
+					<_name>Top</_name>
 				</desc>
 				<desc>
 					<value>top-right</value>
@@ -764,7 +764,7 @@
 				<default>default</default>
 			</option>
 			<option name="instant_unlock_always" type="bool">
-			    <_short>Always show</_short>
+				<_short>Always show</_short>
 				<default>false</default>
 			</option>
 		</group>
diff --git a/metadata/panel.xml b/metadata/panel.xml
index 71ca05e7..82d2eac4 100644
--- a/metadata/panel.xml
+++ b/metadata/panel.xml
@@ -7,7 +7,7 @@
 			<_short>General</_short>
 			<option name="css_path" type="string">
 				<_short>CSS Path</_short>
-				<default></default>
+				<default/>
 			</option>
 			<option name="widgets_left" type="string">
 				<_short>Widgets Left</_short>
@@ -28,7 +28,7 @@
 			</option>
 			<option name="center" type="bool">
 				<_short>Center panel contents</_short>
-				<_long>Ensure the panel’s contents are centered. Effectively:
+				<_long>Ensure the panel&#x2019;s contents are centered. Effectively:
 		If full_span is on, it will put the left and right widgets next to the center ones.
 		If full_span is off, both sides of the panel will take the same amount of space, so that the center widgets are at the middle of the screen. This will lead to unused space on the side that has the least space taken up by the widgets.</_long>
 				<default>false</default>
@@ -271,7 +271,7 @@
 			<option name="menu_icon" type="string">
 				<_short>Menu Icon</_short>
 				<hint>file</hint>
-				<default></default>
+				<default/>
 			</option>
 			<option name="menu_icon_size" type="int">
 				<_short>Menu Icon Size</_short>
@@ -322,7 +322,7 @@
 			<option name="menu_logout_command" type="string">
 				<_short>Menu Logout Command</_short>
 				<_long>If not specified, a default logout interface will be used.</_long>
-				<default></default>
+				<default/>
 			</option>
 			<option name="logout_command" type="string">
 				<_short>Logout Button Command</_short>