Skip to content

Commit a1e5842

Browse files
fusharfushar
committed
Icons: Ship the admin bar and admin menu icons to WordPress Core
Marks the icons that WordPress/wordpress-develop#12270 adds to Core's icon library as `"public": false`: they are shipped and registered for server-side use, but stay out of the icons REST API and so out of the Icon block. brush, dashboard, link, media, page, pin, plugins, post, sites, tool, update `wordpress` is the twelfth icon that Core PR needs. It is already flagged by #82634, which introduces the non-public state and uses it as its first consumer, so it is not repeated here. `false` rather than `true` because these are admin chrome, not post content. Promoting an icon later is trivial; demoting one is a breaking change.
1 parent fb610a2 commit a1e5842

2 files changed

Lines changed: 77 additions & 11 deletions

File tree

‎packages/icons/src/manifest.json‎

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,8 @@
181181
{
182182
"slug": "brush",
183183
"label": "Brush",
184-
"filePath": "library/brush.svg"
184+
"filePath": "library/brush.svg",
185+
"public": false
185186
},
186187
{
187188
"slug": "bug",
@@ -491,7 +492,8 @@
491492
{
492493
"slug": "dashboard",
493494
"label": "Dashboard",
494-
"filePath": "library/dashboard.svg"
495+
"filePath": "library/dashboard.svg",
496+
"public": false
495497
},
496498
{
497499
"slug": "desktop",
@@ -923,7 +925,8 @@
923925
{
924926
"slug": "link",
925927
"label": "Link",
926-
"filePath": "library/link.svg"
928+
"filePath": "library/link.svg",
929+
"public": false
927930
},
928931
{
929932
"slug": "link-off",
@@ -984,7 +987,8 @@
984987
{
985988
"slug": "media",
986989
"label": "Media",
987-
"filePath": "library/media.svg"
990+
"filePath": "library/media.svg",
991+
"public": false
988992
},
989993
{
990994
"slug": "media-and-text",
@@ -1069,7 +1073,8 @@
10691073
{
10701074
"slug": "page",
10711075
"label": "Page",
1072-
"filePath": "library/page.svg"
1076+
"filePath": "library/page.svg",
1077+
"public": false
10731078
},
10741079
{
10751080
"slug": "page-break",
@@ -1123,7 +1128,8 @@
11231128
{
11241129
"slug": "pin",
11251130
"label": "Pin",
1126-
"filePath": "library/pin.svg"
1131+
"filePath": "library/pin.svg",
1132+
"public": false
11271133
},
11281134
{
11291135
"slug": "pin-small",
@@ -1133,7 +1139,8 @@
11331139
{
11341140
"slug": "plugins",
11351141
"label": "Plugins",
1136-
"filePath": "library/plugins.svg"
1142+
"filePath": "library/plugins.svg",
1143+
"public": false
11371144
},
11381145
{
11391146
"slug": "play",
@@ -1185,7 +1192,8 @@
11851192
{
11861193
"slug": "post",
11871194
"label": "Post",
1188-
"filePath": "library/post.svg"
1195+
"filePath": "library/post.svg",
1196+
"public": false
11891197
},
11901198
{
11911199
"slug": "post-author",
@@ -1507,7 +1515,8 @@
15071515
{
15081516
"slug": "sites",
15091517
"label": "Sites",
1510-
"filePath": "library/sites.svg"
1518+
"filePath": "library/sites.svg",
1519+
"public": false
15111520
},
15121521
{
15131522
"slug": "square",
@@ -1713,7 +1722,8 @@
17131722
{
17141723
"slug": "tool",
17151724
"label": "Tool",
1716-
"filePath": "library/tool.svg"
1725+
"filePath": "library/tool.svg",
1726+
"public": false
17171727
},
17181728
{
17191729
"slug": "trash",
@@ -1758,7 +1768,8 @@
17581768
{
17591769
"slug": "update",
17601770
"label": "Update",
1761-
"filePath": "library/update.svg"
1771+
"filePath": "library/update.svg",
1772+
"public": false
17621773
},
17631774
{
17641775
"slug": "upload",

‎packages/icons/src/manifest.php‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@
6161
'label' => _x( 'Block Table', 'icon label', 'gutenberg' ),
6262
'filePath' => 'library/block-table.svg',
6363
),
64+
'brush' => array(
65+
'label' => _x( 'Brush', 'icon label', 'gutenberg' ),
66+
'filePath' => 'library/brush.svg',
67+
'public' => false,
68+
),
6469
'calendar' => array(
6570
'label' => _x( 'Calendar', 'icon label', 'gutenberg' ),
6671
'filePath' => 'library/calendar.svg',
@@ -141,6 +146,11 @@
141146
'label' => _x( 'Create', 'icon label', 'gutenberg' ),
142147
'filePath' => 'library/create.svg',
143148
),
149+
'dashboard' => array(
150+
'label' => _x( 'Dashboard', 'icon label', 'gutenberg' ),
151+
'filePath' => 'library/dashboard.svg',
152+
'public' => false,
153+
),
144154
'desktop' => array(
145155
'label' => _x( 'Desktop', 'icon label', 'gutenberg' ),
146156
'filePath' => 'library/desktop.svg',
@@ -209,10 +219,20 @@
209219
'label' => _x( 'Language', 'icon label', 'gutenberg' ),
210220
'filePath' => 'library/language.svg',
211221
),
222+
'link' => array(
223+
'label' => _x( 'Link', 'icon label', 'gutenberg' ),
224+
'filePath' => 'library/link.svg',
225+
'public' => false,
226+
),
212227
'map-marker' => array(
213228
'label' => _x( 'Map Marker', 'icon label', 'gutenberg' ),
214229
'filePath' => 'library/map-marker.svg',
215230
),
231+
'media' => array(
232+
'label' => _x( 'Media', 'icon label', 'gutenberg' ),
233+
'filePath' => 'library/media.svg',
234+
'public' => false,
235+
),
216236
'menu' => array(
217237
'label' => _x( 'Menu', 'icon label', 'gutenberg' ),
218238
'filePath' => 'library/menu.svg',
@@ -233,6 +253,11 @@
233253
'label' => _x( 'Next', 'icon label', 'gutenberg' ),
234254
'filePath' => 'library/next.svg',
235255
),
256+
'page' => array(
257+
'label' => _x( 'Page', 'icon label', 'gutenberg' ),
258+
'filePath' => 'library/page.svg',
259+
'public' => false,
260+
),
236261
'paragraph' => array(
237262
'label' => _x( 'Paragraph', 'icon label', 'gutenberg' ),
238263
'filePath' => 'library/paragraph.svg',
@@ -249,6 +274,16 @@
249274
'label' => _x( 'People', 'icon label', 'gutenberg' ),
250275
'filePath' => 'library/people.svg',
251276
),
277+
'pin' => array(
278+
'label' => _x( 'Pin', 'icon label', 'gutenberg' ),
279+
'filePath' => 'library/pin.svg',
280+
'public' => false,
281+
),
282+
'plugins' => array(
283+
'label' => _x( 'Plugins', 'icon label', 'gutenberg' ),
284+
'filePath' => 'library/plugins.svg',
285+
'public' => false,
286+
),
252287
'plus' => array(
253288
'label' => _x( 'Plus', 'icon label', 'gutenberg' ),
254289
'filePath' => 'library/plus.svg',
@@ -257,6 +292,11 @@
257292
'label' => _x( 'Plus Circle', 'icon label', 'gutenberg' ),
258293
'filePath' => 'library/plus-circle.svg',
259294
),
295+
'post' => array(
296+
'label' => _x( 'Post', 'icon label', 'gutenberg' ),
297+
'filePath' => 'library/post.svg',
298+
'public' => false,
299+
),
260300
'previous' => array(
261301
'label' => _x( 'Previous', 'icon label', 'gutenberg' ),
262302
'filePath' => 'library/previous.svg',
@@ -305,6 +345,11 @@
305345
'label' => _x( 'Shuffle', 'icon label', 'gutenberg' ),
306346
'filePath' => 'library/shuffle.svg',
307347
),
348+
'sites' => array(
349+
'label' => _x( 'Sites', 'icon label', 'gutenberg' ),
350+
'filePath' => 'library/sites.svg',
351+
'public' => false,
352+
),
308353
'star-empty' => array(
309354
'label' => _x( 'Star Empty', 'icon label', 'gutenberg' ),
310355
'filePath' => 'library/star-empty.svg',
@@ -349,6 +394,16 @@
349394
'label' => _x( 'Tip', 'icon label', 'gutenberg' ),
350395
'filePath' => 'library/tip.svg',
351396
),
397+
'tool' => array(
398+
'label' => _x( 'Tool', 'icon label', 'gutenberg' ),
399+
'filePath' => 'library/tool.svg',
400+
'public' => false,
401+
),
402+
'update' => array(
403+
'label' => _x( 'Update', 'icon label', 'gutenberg' ),
404+
'filePath' => 'library/update.svg',
405+
'public' => false,
406+
),
352407
'upload' => array(
353408
'label' => _x( 'Upload', 'icon label', 'gutenberg' ),
354409
'filePath' => 'library/upload.svg',

0 commit comments

Comments
 (0)