From 1fd24f77de1040bf18369b5e2502d2229c5f0f90 Mon Sep 17 00:00:00 2001 From: shail-mehta Date: Mon, 2 Nov 2026 16:32:56 +0000 Subject: [PATCH 1/2] Tests: Add unit coverage for `get_wp_title_rss()`. Cover the get_wp_title_rss filter arguments with a fixed document title. See #65819. --- tests/phpunit/tests/feed/getWpTitleRss.php | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 tests/phpunit/tests/feed/getWpTitleRss.php diff --git a/tests/phpunit/tests/feed/getWpTitleRss.php b/tests/phpunit/tests/feed/getWpTitleRss.php new file mode 100644 index 0000000000000..2607dfd3037ed --- /dev/null +++ b/tests/phpunit/tests/feed/getWpTitleRss.php @@ -0,0 +1,31 @@ +assertSame( 'Feed Title_append', $result ); + $this->assertSame( 1, $filter->get_call_count() ); + $this->assertSame( array( 'Feed Title', '–' ), $filter->get_args()[0] ); + } +} From c513488db3b732d275c131823230e38672eb6924 Mon Sep 17 00:00:00 2001 From: Shail Mehta Date: Tue, 3 Nov 2026 10:09:12 +0530 Subject: [PATCH 2/2] Apply Feedback changes --- tests/phpunit/tests/feed/getWpTitleRss.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/phpunit/tests/feed/getWpTitleRss.php b/tests/phpunit/tests/feed/getWpTitleRss.php index 2607dfd3037ed..64718840ba4b7 100644 --- a/tests/phpunit/tests/feed/getWpTitleRss.php +++ b/tests/phpunit/tests/feed/getWpTitleRss.php @@ -11,7 +11,7 @@ class Tests_Feed_GetWpTitleRss extends WP_UnitTestCase { /** * @ticket 65819 */ - public function test_filter_receives_document_title_and_deprecated_arg() { + public function test_filter_can_customize_feed_title() { add_filter( 'pre_get_document_title', static function () { @@ -19,13 +19,13 @@ static function () { } ); - $filter = new MockAction(); - add_filter( 'get_wp_title_rss', array( $filter, 'filter_append' ), 10, 2 ); - - $result = get_wp_title_rss(); + add_filter( + 'get_wp_title_rss', + static function ( $title ) { + return $title . ' Custom'; + } + ); - $this->assertSame( 'Feed Title_append', $result ); - $this->assertSame( 1, $filter->get_call_count() ); - $this->assertSame( array( 'Feed Title', '–' ), $filter->get_args()[0] ); + $this->assertSame( 'Feed Title Custom', get_wp_title_rss() ); } }