[Bug]: Wrong error when sending a message for a terminal task

[lkk7]

What happened?

What the spec says about the "Send Message" operation errors:

UnsupportedOperationError: Messages sent to Tasks that are in a terminal state [...]

What the code does (on_message_send(...)->_setup_message_execution(...)):

if task.status.state in TERMINAL_TASK_STATES:
    raise InvalidParamsError(
        message=f'Task {task.id} is in terminal state: {task.status.state}'
    )

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[rohityan]

Hi @lkk7 , Thanks for reporting this and opening the accompanying PR.
Your PR fix appears to be the right approach. Assigning the issue to you till the PR gets reviewed.

[mykytanetipa]

@lkk7 Same bug class on SubscribeToTask, they must be fixed together so SendMessage and SubscribeToTask reject terminal tasks consistently, otherwise we would introduce confusing divergence for error handling.

Spec requires UnsupportedOperationError for both:

• SendMessage (3.1.1)
• SubscribeToTask (3.1.6 / 9.4.6): "Returns UnsupportedOperationError if the task is in a terminal state (…)."

Today SubscribeToTask raises the wrong error via ActiveTask.start():

# active_task.py:
if task.status.state in TERMINAL_TASK_STATES:
   raise InvalidParamsError(message=f'Task {task.id} is in terminal state: {task.status.state}')