From b2dc81bab690a738737fdc4a3667c39a273437cb Mon Sep 17 00:00:00 2001 From: Gage Krumbach Date: Sun, 15 Nov 2026 10:01:46 -0600 Subject: [PATCH] fix(ui): stop the credentials group overlapping network endpoints Each credential row in the Create provider profile modal was wrapped in its own one-item PatternFly Stack. The Stack layout sets height: 100%, and inside the Form's CSS grid the form group control is stretched to a definite height, so the Stack filled the whole control (the blank gap under the row) and pushed the "Add credential" link and its helper text out of the group, over the "Network endpoints" label. Render each credential row as a bare Grid, as the endpoint rows already are. Fixes #132 Co-Authored-By: Claude Opus 5.5 Signed-off-by: Gage Krumbach --- .../src/components/CreateProfileModal.tsx | 130 +++++++++--------- 1 file changed, 62 insertions(+), 68 deletions(-) diff --git a/frontend/src/components/CreateProfileModal.tsx b/frontend/src/components/CreateProfileModal.tsx index f85be302..37edf566 100644 --- a/frontend/src/components/CreateProfileModal.tsx +++ b/frontend/src/components/CreateProfileModal.tsx @@ -16,8 +16,6 @@ import { ModalBody, ModalFooter, ModalHeader, - Stack, - StackItem, TextArea, TextInput, } from '@patternfly/react-core'; @@ -214,72 +212,68 @@ const CreateProfileModal: React.FC = ({ role="group" > {credentials.map((cred, index) => ( - - - - - - setCredentials((rows) => - rows.map((r, i) => - i === index ? { ...r, name: value } : r, - ), - ) - } - placeholder="Credential name" - aria-label="Credential name" - /> - - - - setCredentials((rows) => - rows.map((r, i) => - i === index ? { ...r, envVarsText: value } : r, - ), - ) - } - placeholder="ENV_VARS (comma-separated)" - aria-label="Environment variables" - /> - - - - setCredentials((rows) => - rows.map((r, i) => - i === index ? { ...r, required: checked } : r, - ), - ) - } - /> - - - - - - - + + + + setCredentials((rows) => + rows.map((r, i) => + i === index ? { ...r, name: value } : r, + ), + ) + } + placeholder="Credential name" + aria-label="Credential name" + /> + + + + setCredentials((rows) => + rows.map((r, i) => + i === index ? { ...r, envVarsText: value } : r, + ), + ) + } + placeholder="ENV_VARS (comma-separated)" + aria-label="Environment variables" + /> + + + + setCredentials((rows) => + rows.map((r, i) => + i === index ? { ...r, required: checked } : r, + ), + ) + } + /> + + + + + ))}