From 51401b205ee1ec3ff17e877d78d32f80fb087324 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 15 Nov 2026 07:32:19 +0000 Subject: [PATCH 1/2] Bump com.github.siom79.japicmp:japicmp-maven-plugin Bumps [com.github.siom79.japicmp:japicmp-maven-plugin](https://github.com/siom79/japicmp) from 0.26.5 to 0.27.0. - [Release notes](https://github.com/siom79/japicmp/releases) - [Changelog](https://github.com/siom79/japicmp/blob/master/release.py) - [Commits](https://github.com/siom79/japicmp/compare/japicmp-base-0.26.5...japicmp-base-0.27.0) --- updated-dependencies: - dependency-name: com.github.siom79.japicmp:japicmp-maven-plugin dependency-version: 0.27.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1d28c1f22d..a67f2e1782 100644 --- a/pom.xml +++ b/pom.xml @@ -78,7 +78,7 @@ 2.23.0 2.22.4 2.23 - 0.26.5 + 0.27.0 1.3.2 3.11.0 shaded.parquet From f727952380b0cea86ef99ad5e9d558f8312602fb Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 15 Nov 2026 09:01:24 +0100 Subject: [PATCH 2/2] Suppress japicmp 0.27.0 false positive on PageReader japicmp 0.27.0 reports METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE for PageReader because it now extends AutoCloseable, even though PageReader overrides close() with a default method. Add a post-analysis script that drops only that change type from PageReader, so other checks stay active. Co-authored-by: Isaac --- dev/japicmp-post-analysis.groovy | 37 ++++++++++++++++++++++++++++++++ pom.xml | 2 ++ 2 files changed, 39 insertions(+) create mode 100644 dev/japicmp-post-analysis.groovy diff --git a/dev/japicmp-post-analysis.groovy b/dev/japicmp-post-analysis.groovy new file mode 100644 index 0000000000..78d35001d6 --- /dev/null +++ b/dev/japicmp-post-analysis.groovy @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// Drops specific japicmp compatibility changes from specific classes, for false positives that the +// plugin's could only suppress by skipping the whole class. japicmp ignores the +// returned list, so the changes are removed in place. +def ignoredChanges = [ + // GH-3767: PageReader now extends AutoCloseable. japicmp reports the abstract + // AutoCloseable#close() as added, but PageReader overrides it with a default method, so + // existing implementations stay source and binary compatible. + 'org.apache.parquet.column.page.PageReader': ['METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE'], +] + +jApiClasses.each { jApiClass -> + def ignored = ignoredChanges[jApiClass.fullyQualifiedName] + if (ignored) { + jApiClass.compatibilityChanges.removeIf { ignored.contains(it.type.name()) } + } +} + +return jApiClasses diff --git a/pom.xml b/pom.xml index a67f2e1782..04f3bf2dcc 100644 --- a/pom.xml +++ b/pom.xml @@ -633,6 +633,8 @@ ${shade.prefix}.* true + + ${maven.multiModuleProjectDirectory}/dev/japicmp-post-analysis.groovy parquet-benchmarks