From 265fd7329a1a3e24709c1fd7f2210856a11b7b47 Mon Sep 17 00:00:00 2001 From: "valery.bokov" Date: Fri, 20 Nov 2026 16:11:53 +0100 Subject: [PATCH] Close input streams in debugger StreamPane Use try-with-resources for the streams obtained from Stream.getStream() in requestStreamText() and DocumentCreator.doInBackground(). Co-Authored-By: Claude Opus 5.5 --- .../debugger/streampane/StreamPane.java | 43 +++++++++++-------- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java b/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java index f195b9ece0d..ff427f941c5 100644 --- a/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java +++ b/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java @@ -266,13 +266,15 @@ private void requestStreamText(String command) throws IOException } synchronized (stream) { - InputStream is = stream.getStream(command); - if (is == null) + try (InputStream is = stream.getStream(command)) { - JOptionPane.showMessageDialog(panel, command + " text not available (filter missing?)"); - return; + if (is == null) + { + JOptionPane.showMessageDialog(panel, command + " text not available (filter missing?)"); + return; + } + hexView.changeData(is.readAllBytes()); } - hexView.changeData(is.readAllBytes()); } } @@ -305,25 +307,32 @@ protected StyledDocument doInBackground() { encoding = "UTF-8"; } - InputStream inputStream = stream.getStream(filterKey); - if (inputStream == null) + try (InputStream inputStream = stream.getStream(filterKey)) { - return new DefaultStyledDocument(); - } - if (nice && Stream.DECODED.equals(filterKey)) - { - if (stream.isXmlMetadata()) + if (inputStream == null) { - return getXMLDocument(inputStream); + return new DefaultStyledDocument(); } - StyledDocument document = getContentStreamDocument(inputStream); - if (document != null) + if (nice && Stream.DECODED.equals(filterKey)) { - return document; + if (stream.isXmlMetadata()) + { + return getXMLDocument(inputStream); + } + StyledDocument document = getContentStreamDocument(inputStream); + if (document != null) + { + return document; + } + return getDocument(inputStream, encoding); } return getDocument(inputStream, encoding); } - return getDocument(inputStream, encoding); + catch (IOException e) + { + LOG.error(e.getMessage(), e); + return new DefaultStyledDocument(); + } } }