From f62464555b2b1352d47f5986384185f8a55f99f7 Mon Sep 17 00:00:00 2001 From: "valery.bokov" Date: Sat, 21 Nov 2026 19:10:31 +0100 Subject: [PATCH] Keep data for plain text fallback in debugger StreamPane The nice decoded view read the whole stream when trying to parse it as a content stream, so if parsing failed, the plain text fallback got an already consumed stream and showed an empty document. Read the data once and use it for both. Co-Authored-By: Claude Opus 5.5 --- .../apache/pdfbox/debugger/streampane/StreamPane.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java b/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java index 5b764725c9c..d32430e623f 100644 --- a/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java +++ b/debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamPane.java @@ -23,6 +23,7 @@ import java.awt.event.ActionEvent; import java.awt.event.ActionListener; import java.awt.image.BufferedImage; +import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; import java.io.InputStream; @@ -319,11 +320,15 @@ protected StyledDocument doInBackground() throws IOException { return getXMLDocument(inputStream); } - StyledDocument document = getContentStreamDocument(inputStream); + // read the data only once, so that it is still available for the + // plain text fallback if parsing as a content stream fails + byte[] data = inputStream.readAllBytes(); + StyledDocument document = getContentStreamDocument(data); if (document != null) { return document; } + return getDocument(new ByteArrayInputStream(data), encoding); } return getDocument(inputStream, encoding); } @@ -403,14 +408,14 @@ private StyledDocument getXMLDocument(InputStream inputStream) return docu; } - private StyledDocument getContentStreamDocument(InputStream inputStream) + private StyledDocument getContentStreamDocument(byte[] data) { StyledDocument docu = new DefaultStyledDocument(); PDFStreamParser parser; try { - parser = new PDFStreamParser(inputStream.readAllBytes()); + parser = new PDFStreamParser(data); parser.parse().forEach(obj -> writeToken(obj, docu)); } catch (IOException e)