|
9 | 9 | from aws_lambda_powertools.metrics.exceptions import MetricValueError, SchemaValidationError |
10 | 10 | from aws_lambda_powertools.metrics.provider.cold_start import reset_cold_start_flag |
11 | 11 | from aws_lambda_powertools.metrics.provider.datadog import DatadogMetrics, DatadogProvider |
| 12 | +from aws_lambda_powertools.warnings import PowertoolsUserWarning |
12 | 13 |
|
13 | 14 |
|
14 | 15 | def test_datadog_coldstart(capsys): |
@@ -125,6 +126,29 @@ def test_datadog_with_invalid_metric_value(): |
125 | 126 | metrics.add_metric(name="item_sold", value="a", product="latte", order="online") |
126 | 127 |
|
127 | 128 |
|
| 129 | +def _reject_non_finite(constant: str): |
| 130 | + raise ValueError(f"Datadog output contains {constant}, which is not valid JSON") |
| 131 | + |
| 132 | + |
| 133 | +@pytest.mark.parametrize("value", [float("nan"), float("inf"), float("-inf")]) |
| 134 | +def test_datadog_add_metric_with_non_finite_value(capsys, value): |
| 135 | + # GIVEN DatadogMetrics is initialized with flush_to_log |
| 136 | + dd_provider = DatadogProvider(flush_to_log=True) |
| 137 | + metrics = DatadogMetrics(provider=dd_provider) |
| 138 | + |
| 139 | + # WHEN we add a non-finite metric value next to a valid metric |
| 140 | + with pytest.warns(PowertoolsUserWarning, match="The metric bad_metric has a non-finite value *"): |
| 141 | + metrics.add_metric(name="bad_metric", value=value) |
| 142 | + metrics.add_metric(name="good_metric", value=1.0) |
| 143 | + metrics.flush_metrics() |
| 144 | + |
| 145 | + # THEN the flushed log is valid JSON and only contains the valid metric |
| 146 | + output = capsys.readouterr().out.strip() |
| 147 | + logs = json.loads(output, parse_constant=_reject_non_finite) |
| 148 | + assert logs["m"] == "good_metric" |
| 149 | + assert logs["v"] == 1.0 |
| 150 | + |
| 151 | + |
128 | 152 | def test_datadog_with_invalid_metric_name(): |
129 | 153 | # GIVEN DatadogMetrics is initialized |
130 | 154 | metrics = DatadogMetrics() |
|
0 commit comments