From 364b6753a40aa6fb61e8d367e9f4158cda5ae75f Mon Sep 17 00:00:00 2001 From: lechakrawarthy Date: Sun, 1 Nov 2026 15:45:32 +0530 Subject: [PATCH 1/3] fix(idempotency): treat empty or unparsable POWERTOOLS_IDEMPOTENCY_DISABLED as not disabled strtobool("") raised ValueError, so an empty or non-boolean value crashed every invocation before the handler ran. Resolve the variable once in a helper that returns False (with a debug log) for values strtobool rejects, and use it in both idempotent and idempotent_function. --- .../utilities/idempotency/idempotency.py | 18 +++++++++-- .../idempotency/_boto3/test_idempotency.py | 32 +++++++++++++++++++ 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/aws_lambda_powertools/utilities/idempotency/idempotency.py b/aws_lambda_powertools/utilities/idempotency/idempotency.py index 62a8994889c..a6da94d30c0 100644 --- a/aws_lambda_powertools/utilities/idempotency/idempotency.py +++ b/aws_lambda_powertools/utilities/idempotency/idempotency.py @@ -39,6 +39,20 @@ ContextT = TypeVar("ContextT", bound="LambdaContext | DurableContextProtocol") +def _is_idempotency_disabled() -> bool: + # An empty or unparsable value is easy to end up with in IaC templates and CI variables; + # treat it as "not disabled" instead of failing every invocation + value = os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "false") + try: + return strtobool(value) + except ValueError: + logger.debug( + f"Ignoring {constants.IDEMPOTENCY_DISABLED_ENV}={value!r}: " + "not a recognised boolean, idempotency stays enabled", + ) + return False + + class _IdempotentHandlerDecorator(Protocol): # The return type is Any, as responses replayed from the persistence store are deserialized JSON def __call__( @@ -106,7 +120,7 @@ def handler(event, context): # Skip idempotency controls when POWERTOOLS_IDEMPOTENCY_DISABLED has a truthy value # Raises a warning if not running in development mode - if strtobool(os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "false")): + if _is_idempotency_disabled(): warnings.warn( message="Disabling idempotency is intended for development environments only " "and should not be used in production.", @@ -216,7 +230,7 @@ def process_order(customer_id: str, order: dict, **kwargs): def decorate(*args, **kwargs): # Skip idempotency controls when POWERTOOLS_IDEMPOTENCY_DISABLED has a truthy value # Raises a warning if not running in development mode - if strtobool(os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "false")): + if _is_idempotency_disabled(): warnings.warn( message="Disabling idempotency is intended for development environments only " "and should not be used in production.", diff --git a/tests/functional/idempotency/_boto3/test_idempotency.py b/tests/functional/idempotency/_boto3/test_idempotency.py index fe70251905d..7aa0e825a73 100644 --- a/tests/functional/idempotency/_boto3/test_idempotency.py +++ b/tests/functional/idempotency/_boto3/test_idempotency.py @@ -1704,6 +1704,38 @@ def dummy_handler(event, context): assert len(persistence_store.client.method_calls) == 4 +@pytest.mark.parametrize("idempotency_disabled_value", ["", " ", "maybe", None]) +def test_idempotency_disabled_envvar_empty_or_unparsable( + monkeypatch, + lambda_context, + persistence_store: DynamoDBPersistenceLayer, + idempotency_disabled_value, +): + # Scenario to validate an empty, unset or unparsable 'POWERTOOLS_IDEMPOTENCY_DISABLED' + # keeps idempotency enabled instead of crashing the invocation + mock_event = {"data": "value"} + + persistence_store.client = MagicMock() + + if idempotency_disabled_value is None: + monkeypatch.delenv("POWERTOOLS_IDEMPOTENCY_DISABLED", raising=False) + else: + monkeypatch.setenv("POWERTOOLS_IDEMPOTENCY_DISABLED", idempotency_disabled_value) + + @idempotent_function(data_keyword_argument="data", persistence_store=persistence_store) + def dummy(data): + return {"message": "hello"} + + @idempotent(persistence_store=persistence_store) + def dummy_handler(event, context): + return {"message": "hi"} + + assert dummy(data=mock_event) == {"message": "hello"} + assert dummy_handler(mock_event, lambda_context) == {"message": "hi"} + + assert len(persistence_store.client.method_calls) == 4 + + @pytest.mark.parametrize("idempotency_config", [{"use_local_cache": True}], indirect=True) def test_idempotent_function_duplicates( idempotency_config: IdempotencyConfig, From 5cc2b528918b7567e103f4d01ca6a0993ae7233e Mon Sep 17 00:00:00 2001 From: Leandro Damascena Date: Tue, 10 Nov 2026 15:34:00 +0000 Subject: [PATCH 2/3] fix(idempotency): warn with PowertoolsUserWarning when the disabled flag is ignored --- .../utilities/idempotency/idempotency.py | 4 +++- .../functional/idempotency/_boto3/test_idempotency.py | 10 ++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/aws_lambda_powertools/utilities/idempotency/idempotency.py b/aws_lambda_powertools/utilities/idempotency/idempotency.py index a6da94d30c0..c8eb3fd663b 100644 --- a/aws_lambda_powertools/utilities/idempotency/idempotency.py +++ b/aws_lambda_powertools/utilities/idempotency/idempotency.py @@ -46,9 +46,11 @@ def _is_idempotency_disabled() -> bool: try: return strtobool(value) except ValueError: - logger.debug( + warnings.warn( f"Ignoring {constants.IDEMPOTENCY_DISABLED_ENV}={value!r}: " "not a recognised boolean, idempotency stays enabled", + category=PowertoolsUserWarning, + stacklevel=3, ) return False diff --git a/tests/functional/idempotency/_boto3/test_idempotency.py b/tests/functional/idempotency/_boto3/test_idempotency.py index 7aa0e825a73..93650f7c1ab 100644 --- a/tests/functional/idempotency/_boto3/test_idempotency.py +++ b/tests/functional/idempotency/_boto3/test_idempotency.py @@ -1730,8 +1730,14 @@ def dummy(data): def dummy_handler(event, context): return {"message": "hi"} - assert dummy(data=mock_event) == {"message": "hello"} - assert dummy_handler(mock_event, lambda_context) == {"message": "hi"} + if idempotency_disabled_value is None: + assert dummy(data=mock_event) == {"message": "hello"} + assert dummy_handler(mock_event, lambda_context) == {"message": "hi"} + else: + with pytest.warns(PowertoolsUserWarning, match="not a recognised boolean"): + assert dummy(data=mock_event) == {"message": "hello"} + with pytest.warns(PowertoolsUserWarning, match="not a recognised boolean"): + assert dummy_handler(mock_event, lambda_context) == {"message": "hi"} assert len(persistence_store.client.method_calls) == 4 From 6b73d62a5c491536a64614d329127bc078a73c67 Mon Sep 17 00:00:00 2001 From: Leandro Damascena Date: Sat, 14 Nov 2026 12:23:08 +0000 Subject: [PATCH 3/3] fix(idempotency): use the shared resolve_bool_env_var for POWERTOOLS_IDEMPOTENCY_DISABLED --- .../utilities/idempotency/idempotency.py | 23 +++---------------- .../idempotency/_boto3/test_idempotency.py | 4 ++-- 2 files changed, 5 insertions(+), 22 deletions(-) diff --git a/aws_lambda_powertools/utilities/idempotency/idempotency.py b/aws_lambda_powertools/utilities/idempotency/idempotency.py index c8eb3fd663b..212d1fe315e 100644 --- a/aws_lambda_powertools/utilities/idempotency/idempotency.py +++ b/aws_lambda_powertools/utilities/idempotency/idempotency.py @@ -6,14 +6,13 @@ import functools import logging -import os import warnings from inspect import isclass from typing import TYPE_CHECKING, Any, Protocol, TypeVar, cast from aws_lambda_powertools.middleware_factory import lambda_handler_decorator from aws_lambda_powertools.shared import constants -from aws_lambda_powertools.shared.functions import strtobool +from aws_lambda_powertools.shared.functions import resolve_bool_env_var from aws_lambda_powertools.shared.types import AnyCallableT from aws_lambda_powertools.utilities.idempotency.base import IdempotencyHandler from aws_lambda_powertools.utilities.idempotency.config import IdempotencyConfig @@ -39,22 +38,6 @@ ContextT = TypeVar("ContextT", bound="LambdaContext | DurableContextProtocol") -def _is_idempotency_disabled() -> bool: - # An empty or unparsable value is easy to end up with in IaC templates and CI variables; - # treat it as "not disabled" instead of failing every invocation - value = os.getenv(constants.IDEMPOTENCY_DISABLED_ENV, "false") - try: - return strtobool(value) - except ValueError: - warnings.warn( - f"Ignoring {constants.IDEMPOTENCY_DISABLED_ENV}={value!r}: " - "not a recognised boolean, idempotency stays enabled", - category=PowertoolsUserWarning, - stacklevel=3, - ) - return False - - class _IdempotentHandlerDecorator(Protocol): # The return type is Any, as responses replayed from the persistence store are deserialized JSON def __call__( @@ -122,7 +105,7 @@ def handler(event, context): # Skip idempotency controls when POWERTOOLS_IDEMPOTENCY_DISABLED has a truthy value # Raises a warning if not running in development mode - if _is_idempotency_disabled(): + if resolve_bool_env_var(constants.IDEMPOTENCY_DISABLED_ENV): warnings.warn( message="Disabling idempotency is intended for development environments only " "and should not be used in production.", @@ -232,7 +215,7 @@ def process_order(customer_id: str, order: dict, **kwargs): def decorate(*args, **kwargs): # Skip idempotency controls when POWERTOOLS_IDEMPOTENCY_DISABLED has a truthy value # Raises a warning if not running in development mode - if _is_idempotency_disabled(): + if resolve_bool_env_var(constants.IDEMPOTENCY_DISABLED_ENV): warnings.warn( message="Disabling idempotency is intended for development environments only " "and should not be used in production.", diff --git a/tests/functional/idempotency/_boto3/test_idempotency.py b/tests/functional/idempotency/_boto3/test_idempotency.py index b6fc29b3e54..00e25365e7c 100644 --- a/tests/functional/idempotency/_boto3/test_idempotency.py +++ b/tests/functional/idempotency/_boto3/test_idempotency.py @@ -1764,9 +1764,9 @@ def dummy_handler(event, context): assert dummy(data=mock_event) == {"message": "hello"} assert dummy_handler(mock_event, lambda_context) == {"message": "hi"} else: - with pytest.warns(PowertoolsUserWarning, match="not a recognised boolean"): + with pytest.warns(PowertoolsUserWarning, match="unrecognised value"): assert dummy(data=mock_event) == {"message": "hello"} - with pytest.warns(PowertoolsUserWarning, match="not a recognised boolean"): + with pytest.warns(PowertoolsUserWarning, match="unrecognised value"): assert dummy_handler(mock_event, lambda_context) == {"message": "hi"} assert len(persistence_store.client.method_calls) == 4