From e8099ed79ea0ff22b62fbacd6b7e8e6e0c6307af Mon Sep 17 00:00:00 2001 From: Ronak Yadav Date: Sun, 15 Nov 2026 21:39:06 +0530 Subject: [PATCH 1/2] fix(logger): match suppressed loggers by hierarchy SuppressFilter matched loggers via substring (`self.logger not in record.name`), which unintentionally suppressed unrelated third-party loggers whose names contained the service name (e.g. `botocore` when service was `core`). Change the matching logic to match either the exact logger name or child loggers prefixed with `{self.logger}.`. Add functional regression tests. Closes #8821 --- aws_lambda_powertools/logging/filters.py | 2 +- .../required_dependencies/test_logger.py | 28 +++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/aws_lambda_powertools/logging/filters.py b/aws_lambda_powertools/logging/filters.py index 7587590b124..c6542f92c8d 100644 --- a/aws_lambda_powertools/logging/filters.py +++ b/aws_lambda_powertools/logging/filters.py @@ -13,4 +13,4 @@ def filter(self, record: logging.LogRecord) -> bool: # noqa: A003 created by loggers who don't have a handler. """ logger = record.name - return self.logger not in logger + return not (logger == self.logger or logger.startswith(f"{self.logger}.")) diff --git a/tests/functional/logger/required_dependencies/test_logger.py b/tests/functional/logger/required_dependencies/test_logger.py index afc16b6cbfb..8867ae14acc 100644 --- a/tests/functional/logger/required_dependencies/test_logger.py +++ b/tests/functional/logger/required_dependencies/test_logger.py @@ -633,6 +633,34 @@ def test_logger_log_twice_when_log_filter_isnt_present_and_root_logger_is_setup( assert len(logs) == 4 +def test_suppress_filter_does_not_suppress_unrelated_logger_containing_service_name(stdout): + # GIVEN a root logger configured with a handler (as in Lambda runtime) + root_stream = io.StringIO() + root_handler = logging.StreamHandler(root_stream) + root_logger = logging.getLogger() + root_logger.addHandler(root_handler) + + try: + # AND a Powertools logger with service "core" + Logger(service="core", stream=stdout) + child_logger = Logger(service="core", child=True, stream=stdout) + unrelated_logger = logging.getLogger("botocore") + + # WHEN an unrelated logger whose name contains the service string logs a message + # AND a child logger of the Powertools logger logs a message + unrelated_logger.warning("credentials expire soon") + child_logger.warning("child message") + + # THEN the unrelated logger must not be suppressed by the root handler's SuppressFilter + root_output = root_stream.getvalue() + assert "credentials expire soon" in root_output + + # AND the genuine child logger must still be suppressed from bubbling to the root handler + assert "child message" not in root_output + finally: + root_logger.removeHandler(root_handler) + + def test_logger_exception_extract_exception_name(stdout, service_name): # GIVEN Logger is initialized logger = Logger(service=service_name, stream=stdout) From 31d803bb3f1a37ad31dee8ebcc097734eb1ed9ff Mon Sep 17 00:00:00 2001 From: Ronak Yadav Date: Wed, 18 Nov 2026 14:46:32 +0530 Subject: [PATCH 2/2] test(logger): use service fixture for suppress filter test --- .../logger/required_dependencies/test_logger.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/functional/logger/required_dependencies/test_logger.py b/tests/functional/logger/required_dependencies/test_logger.py index 8867ae14acc..85c587c82d5 100644 --- a/tests/functional/logger/required_dependencies/test_logger.py +++ b/tests/functional/logger/required_dependencies/test_logger.py @@ -633,7 +633,7 @@ def test_logger_log_twice_when_log_filter_isnt_present_and_root_logger_is_setup( assert len(logs) == 4 -def test_suppress_filter_does_not_suppress_unrelated_logger_containing_service_name(stdout): +def test_suppress_filter_does_not_suppress_unrelated_logger_containing_service_name(stdout, service_name): # GIVEN a root logger configured with a handler (as in Lambda runtime) root_stream = io.StringIO() root_handler = logging.StreamHandler(root_stream) @@ -641,10 +641,11 @@ def test_suppress_filter_does_not_suppress_unrelated_logger_containing_service_n root_logger.addHandler(root_handler) try: - # AND a Powertools logger with service "core" - Logger(service="core", stream=stdout) - child_logger = Logger(service="core", child=True, stream=stdout) - unrelated_logger = logging.getLogger("botocore") + # AND a Powertools logger, plus an unrelated logger whose name contains the service name + # (like "botocore" for service "core") + Logger(service=service_name, stream=stdout) + child_logger = Logger(service=service_name, child=True, stream=stdout) + unrelated_logger = logging.getLogger(f"boto{service_name}") # WHEN an unrelated logger whose name contains the service string logs a message # AND a child logger of the Powertools logger logs a message