From 6ddb4316f8000a780c1c61c7d1f7c1faff12c7df Mon Sep 17 00:00:00 2001 From: GusAntoniassi Date: Thu, 21 May 2026 11:28:36 -0300 Subject: [PATCH 1/4] fix: conditional aws-hyperpod namespace creation --- .../templates/aws-hyperpod-namespace.yaml | 6 ++++-- .../charts/deep-health-check/values.yaml | 4 +++- helm_chart/HyperPodHelmChart/values.yaml | 8 ++++---- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml b/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml index 79b96bf2..8fdd6c91 100644 --- a/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml +++ b/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml @@ -1,6 +1,8 @@ +{{- if .Values.namespace.create }} apiVersion: v1 kind: Namespace metadata: - name: aws-hyperpod + name: {{ .Values.namespace.name }} labels: - name: aws-hyperpod + name: {{ .Values.namespace.name }} +{{- end }} \ No newline at end of file diff --git a/helm_chart/HyperPodHelmChart/charts/deep-health-check/values.yaml b/helm_chart/HyperPodHelmChart/charts/deep-health-check/values.yaml index 894df9a2..045a08a8 100644 --- a/helm_chart/HyperPodHelmChart/charts/deep-health-check/values.yaml +++ b/helm_chart/HyperPodHelmChart/charts/deep-health-check/values.yaml @@ -1 +1,3 @@ -namespace: "aws-hyperpod" +namespace: + name: "aws-hyperpod" + create: true diff --git a/helm_chart/HyperPodHelmChart/values.yaml b/helm_chart/HyperPodHelmChart/values.yaml index 9ca210f8..39376891 100644 --- a/helm_chart/HyperPodHelmChart/values.yaml +++ b/helm_chart/HyperPodHelmChart/values.yaml @@ -111,10 +111,6 @@ tolerations: [] affinity: {} -namespace: - create: true - name: aws-hyperpod - cert-manager: enabled: false namespace: cert-manager @@ -276,6 +272,10 @@ health-monitoring-agent: # region: "us-east-1" deep-health-check: enabled: true + namespace: + create: true + name: aws-hyperpod + job-auto-restart: enabled: true hyperpod-patching: From 1b187236f4d986f185357439ca793f2a648d007a Mon Sep 17 00:00:00 2001 From: GusAntoniassi Date: Thu, 21 May 2026 14:04:20 -0300 Subject: [PATCH 2/4] fix: deep health check namespace reference --- .../deep-health-check/templates/deep-health-check-rbac.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/deep-health-check-rbac.yaml b/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/deep-health-check-rbac.yaml index 5a3a184d..1b4dcedd 100644 --- a/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/deep-health-check-rbac.yaml +++ b/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/deep-health-check-rbac.yaml @@ -5,7 +5,7 @@ apiVersion: v1 kind: ServiceAccount metadata: name: deep-health-check-service-account - namespace: {{ .Values.namespace }} + namespace: {{ .Values.namespace.name }} --- kind: ClusterRole apiVersion: rbac.authorization.k8s.io/v1 @@ -39,4 +39,4 @@ roleRef: subjects: - kind: ServiceAccount name: deep-health-check-service-account - namespace: {{ .Values.namespace }} + namespace: {{ .Values.namespace.name }} From 9462356fcdd92d83574b68c7ee4b17b0cfa817db Mon Sep 17 00:00:00 2001 From: Gustavo Antoniassi Date: Fri, 22 May 2026 10:43:14 -0300 Subject: [PATCH 3/4] chore: allow conditional creation of mpi-operator chart --- .../charts/mpi-operator/templates/rbac.yaml | 2 ++ helm_chart/HyperPodHelmChart/charts/mpi-operator/values.yaml | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml b/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml index 67da7f19..dae08e7b 100644 --- a/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml +++ b/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml @@ -1,3 +1,4 @@ +{{- if .Values.namespace.create }} apiVersion: v1 kind: Namespace metadata: @@ -8,6 +9,7 @@ metadata: kustomize.component: mpi-operator name: mpi-operator --- +{{- end }} apiVersion: v1 kind: ServiceAccount metadata: diff --git a/helm_chart/HyperPodHelmChart/charts/mpi-operator/values.yaml b/helm_chart/HyperPodHelmChart/charts/mpi-operator/values.yaml index c21fb48c..1b51581e 100644 --- a/helm_chart/HyperPodHelmChart/charts/mpi-operator/values.yaml +++ b/helm_chart/HyperPodHelmChart/charts/mpi-operator/values.yaml @@ -35,4 +35,7 @@ mpiOperator: imagePullPolicy: IfNotPresent ## Apply extra labels to all created resources -extraLabels: {} \ No newline at end of file +extraLabels: {} + +namespace: + create: true \ No newline at end of file From 8f121173f48ea9db3282f183d9f3d60b99104233 Mon Sep 17 00:00:00 2001 From: GusAntoniassi Date: Fri, 28 Aug 2026 11:14:48 -0300 Subject: [PATCH 4/4] chore: address review changes --- .../deep-health-check/templates/aws-hyperpod-namespace.yaml | 2 +- .../HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml | 2 +- helm_chart/HyperPodHelmChart/values.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml b/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml index 8fdd6c91..1a36e89a 100644 --- a/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml +++ b/helm_chart/HyperPodHelmChart/charts/deep-health-check/templates/aws-hyperpod-namespace.yaml @@ -5,4 +5,4 @@ metadata: name: {{ .Values.namespace.name }} labels: name: {{ .Values.namespace.name }} -{{- end }} \ No newline at end of file +{{- end }} diff --git a/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml b/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml index dae08e7b..c354bd47 100644 --- a/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml +++ b/helm_chart/HyperPodHelmChart/charts/mpi-operator/templates/rbac.yaml @@ -8,8 +8,8 @@ metadata: app.kubernetes.io/name: mpi-operator kustomize.component: mpi-operator name: mpi-operator ---- {{- end }} +--- apiVersion: v1 kind: ServiceAccount metadata: diff --git a/helm_chart/HyperPodHelmChart/values.yaml b/helm_chart/HyperPodHelmChart/values.yaml index 39376891..569ab0dd 100644 --- a/helm_chart/HyperPodHelmChart/values.yaml +++ b/helm_chart/HyperPodHelmChart/values.yaml @@ -275,7 +275,7 @@ deep-health-check: namespace: create: true name: aws-hyperpod - + job-auto-restart: enabled: true hyperpod-patching: