From c40443eab21c9982a1ed7bfb2fbdb9028810dfa4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Pierzcha=C5=82a?= Date: Thu, 5 Nov 2026 19:05:47 +0100 Subject: [PATCH] docs(capture): correct stale Limrun and Revyl capture comments The viewport test still listed a Limrun tree acquisition that #4243 removed, and the Revyl iOS comment said the tree goes through the capture kit's reader while Revyl parses its own hierarchy and only flattens and interprets through the capture kit. --- .../snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts | 2 +- packages/provider-revyl/src/snapshot.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/capture-kit/src/snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts b/packages/capture-kit/src/snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts index 7d9f2f79ab..2fa7cbbebe 100644 --- a/packages/capture-kit/src/snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts +++ b/packages/capture-kit/src/snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts @@ -11,7 +11,7 @@ import type { IosViewportEvidence } from '@agent-device/contracts/ios-snapshot'; import { AppError } from '@agent-device/kernel/errors'; import type { RawSnapshotNode } from '@agent-device/kernel/snapshot'; -// #3182: the provider acquisitions — the simulator AX bridge, an Appium page source, a Limrun tree — +// #3182: the provider acquisitions — the simulator AX bridge or an Appium page source — // already resolve the box their nodes are measured in, and this presenter is the one seam that turns // an acquisition into a snapshot result. Publishing nothing here left the default local-iOS producer // without a viewport while it held the evidence, which is the issue's first `Done when` line. diff --git a/packages/provider-revyl/src/snapshot.ts b/packages/provider-revyl/src/snapshot.ts index 4274ae2cc9..7c34589cb1 100644 --- a/packages/provider-revyl/src/snapshot.ts +++ b/packages/provider-revyl/src/snapshot.ts @@ -47,8 +47,8 @@ export async function captureRevylSnapshot( } /** - * iOS: the AX node tree goes through the capture kit's iOS AX tree reader and interpreter, and comes - * back as an acquisition for the host to present. The viewport is the tree's own application root, + * iOS: Revyl's hierarchy JSON is parsed here into an AX node tree; the capture kit then flattens and + * interprets it, and it comes back as an acquisition for the host to present. The viewport is the tree's own application root, * because that is the box its frames were measured in; without a usable root it is `health`'s screen, * which Revyl reports in the same points on iOS. */