From 92989cf2dd067735165ffafcbf4a8f0005e20dbb Mon Sep 17 00:00:00 2001 From: Jonathan Tatum Date: Tue, 18 Aug 2026 11:46:30 -0700 Subject: [PATCH] Bump cel-spec version. Re-enable fixed conformance tests. PiperOrigin-RevId: 966718346 --- MODULE.bazel | 7 ++++++- conformance/BUILD | 1 + conformance/conformance_test.py | 13 ++----------- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index a47ae41..c233a1e 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -24,7 +24,12 @@ git_override( ) # https://registry.bazel.build/modules/cel-spec -bazel_dep(name = "cel-spec", version = "0.25.1", repo_name = "com_google_cel_spec") +bazel_dep(name = "cel-spec", version = "0.25.3", repo_name = "com_google_cel_spec") +git_override( + module_name = "cel-spec", + commit = "ba58ae5007845f3a1279b488cdeb79645ce958bb", + remote = "https://github.com/cel-expr/cel-spec", +) # https://registry.bazel.build/modules/googletest bazel_dep(name = "googletest", version = "1.17.0.bcr.2", repo_name = "com_google_googletest") diff --git a/conformance/BUILD b/conformance/BUILD index 79bb661..00291fc 100644 --- a/conformance/BUILD +++ b/conformance/BUILD @@ -14,6 +14,7 @@ _ALL_TESTS = [ "@com_google_cel_spec//tests/simple:testdata/fp_math.textproto", "@com_google_cel_spec//tests/simple:testdata/integer_math.textproto", "@com_google_cel_spec//tests/simple:testdata/lists.textproto", + "@com_google_cel_spec//tests/simple:testdata/lists_ext.textproto", "@com_google_cel_spec//tests/simple:testdata/logic.textproto", "@com_google_cel_spec//tests/simple:testdata/macros.textproto", "@com_google_cel_spec//tests/simple:testdata/math_ext.textproto", diff --git a/conformance/conformance_test.py b/conformance/conformance_test.py index d0b30e6..529bba2 100644 --- a/conformance/conformance_test.py +++ b/conformance/conformance_test.py @@ -60,13 +60,6 @@ class ConformanceTestSuite(unittest.TestSuite): "fields/qualified_identifier_resolution/qualified_identifier_resolution_unchecked", "fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous", "namespace/namespace/self_eval_container_lookup_unchecked", - # TODO(b/453051120): fix support for FieldMask->toJson - "wrappers/field_mask/to_json", - # TODO(b/464071224): fix support for triple-quoted unescaped punctuation. - "parse/bytes_literals/triple_double_quoted_unescaped_punctuation", - "parse/bytes_literals/triple_single_quoted_unescaped_punctuation", - "parse/string_literals/triple_double_quoted_unescaped_punctuation", - "parse/string_literals/triple_single_quoted_unescaped_punctuation", # Recent changes "proto2/set_null/repeated_field_timestamp_null_pruned", "proto2/set_null/repeated_field_duration_null_pruned", @@ -80,10 +73,8 @@ class ConformanceTestSuite(unittest.TestSuite): "proto3/set_null/map_timestamp_null_pruned", "proto3/set_null/map_duration_null_pruned", "proto3/set_null/map_wrapper_null_pruned", - "string_ext/format/default precision for fixed-point clause with int", - "string_ext/format/default precision for fixed-point clause with uint", - "string_ext/format/default precision for scientific notation with int", - "string_ext/format/default precision for scientific notation with uint", + # TODO(b/548571767): add lists_ext support + "lists_ext/.*", ] if sys.platform == "win32":