fix: test fixes

Author: kevinwang5658

test/orchestrator/apply/apply.test.ts

@@ -8,6 +8,19 @@ import { MockReporter } from '../mocks/reporter.js';
 import { ApplyOrchestrator } from '../../../src/orchestrators/apply';
 import {OsUtils} from "../../../src/utils/os-utils.js";
 
+// In-process MockPlugins spawn BackgroundPtys that are never killed between tests. On Linux their
+// pending writes can land in the pty validateShell spawns (fd reuse), causing spurious failures.
+vi.mock('../../../src/utils/shell.js', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('../../../src/utils/shell.js')>();
+  return {
+    ...actual,
+    ShellUtils: {
+      ...actual.ShellUtils,
+      validateShell: vi.fn(async () => {}),
+    },
+  }
+})
+
 vi.mock('../../../src/plugins/plugin.js', async () => {
   const { MockPlugin } = await import('../mocks/plugin.js');
   return { Plugin: MockPlugin };

test/orchestrator/destroy/destroy.test.ts

@@ -29,6 +29,19 @@ vi.mock('../mocks/get-mock-resources.js', async () => {
   }
 })
 
+// In-process MockPlugins spawn BackgroundPtys that are never killed between tests. On Linux their
+// pending writes can land in the pty validateShell spawns (fd reuse), causing spurious failures.
+vi.mock('../../../src/utils/shell.js', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('../../../src/utils/shell.js')>();
+  return {
+    ...actual,
+    ShellUtils: {
+      ...actual.ShellUtils,
+      validateShell: vi.fn(async () => {}),
+    },
+  }
+})
+
 vi.mock('../../../src/plugins/plugin.js', async () => {
   const { MockPlugin } = await import('../mocks/plugin.js');
   return { Plugin: MockPlugin };

test/orchestrator/import/import.test.ts

@@ -111,6 +111,19 @@ vi.mock('../mocks/get-mock-resources.js', async () => {
   }
 })
 
+// In-process MockPlugins spawn BackgroundPtys that are never killed between tests. On Linux their
+// pending writes can land in the pty validateShell spawns (fd reuse), causing spurious failures.
+vi.mock('../../../src/utils/shell.js', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('../../../src/utils/shell.js')>();
+  return {
+    ...actual,
+    ShellUtils: {
+      ...actual.ShellUtils,
+      validateShell: vi.fn(async () => {}),
+    },
+  }
+})
+
 vi.mock('../../../src/plugins/plugin.js', async () => {
   const { MockPlugin } = await import('../mocks/plugin.js');
   return { Plugin: MockPlugin };

test/orchestrator/plan/plan.test.ts

@@ -8,6 +8,19 @@ import { MockReporter } from '../mocks/reporter.js';
 import { PlanOrchestrator } from '../../../src/orchestrators/plan';
 import {OsUtils} from "../../../src/utils/os-utils.js";
 
+// In-process MockPlugins spawn BackgroundPtys that are never killed between tests. On Linux their
+// pending writes can land in the pty validateShell spawns (fd reuse), causing spurious failures.
+vi.mock('../../../src/utils/shell.js', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('../../../src/utils/shell.js')>();
+  return {
+    ...actual,
+    ShellUtils: {
+      ...actual.ShellUtils,
+      validateShell: vi.fn(async () => {}),
+    },
+  }
+})
+
 vi.mock('../../../src/plugins/plugin.js', async () => {
   const { MockPlugin } = await import('../mocks/plugin.js');
   return { Plugin: MockPlugin };

test/orchestrator/refresh/refresh.test.ts

@@ -112,6 +112,19 @@ vi.mock('../mocks/get-mock-resources.js', async () => {
   }
 })
 
+// In-process MockPlugins spawn BackgroundPtys that are never killed between tests. On Linux their
+// pending writes can land in the pty validateShell spawns (fd reuse), causing spurious failures.
+vi.mock('../../../src/utils/shell.js', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('../../../src/utils/shell.js')>();
+  return {
+    ...actual,
+    ShellUtils: {
+      ...actual.ShellUtils,
+      validateShell: vi.fn(async () => {}),
+    },
+  }
+})
+
 vi.mock('../../../src/plugins/plugin.js', async () => {
   const { MockPlugin } = await import('../mocks/plugin.js');
   return { Plugin: MockPlugin };