feat: update to node-pty latest (1.2 beta) which has pre-compiled binaries and does not rely on post install scripts (node-gyp)

Author: kevinwang5658

README.md

@@ -1,6 +1,3 @@
-> ⚠️ **This package has been migrated and re-purposed.** The original package by [Andrew Stone](https://www.npmjs.com/~andrewjstone)
-> for transforming integers to base36 strings. To continue to use that functionality, please pin to version 0.3.0 or below.
-
 # Codify - Your Development Environment as Code
 
 **Stop manually setting up your development environment. Define it once, replicate it everywhere.**

package-lock.json

@@ -6,8 +6,7 @@
   "dependencies": {
     "@codifycli/ink-form": "0.0.12",
     "@codifycli/schemas": "1.2.0",
-    "@homebridge/node-pty-prebuilt-multiarch": "npm:@lydell/node-pty@1.2.0-beta.15",
-    "@lydell/node-pty": "1.2.0-beta.15",
+    "@homebridge/node-pty-prebuilt-multiarch": "npm:node-pty@1.2.0-beta.15",
     "@mischnic/json-sourcemap": "^0.1.1",
     "@oclif/core": "^4.0.8",
     "@oclif/plugin-autocomplete": "^3.2.24",
@@ -37,6 +36,7 @@
     "kill-port": "^2.0.1",
     "latest-semver": "^4.0.0",
     "nanoid": "^5.0.9",
+    "node-pty": "1.2.0-beta.15",
     "open": "^10.1.2",
     "parse-json": "^8.1.0",
     "react": "^18.3.1",
@@ -150,7 +150,7 @@
     "prepublishOnly": "npm run build && npm run build:npm",
     "postpublish": "npm run restore-npm"
   },
-  "version": "1.2.2",
+  "version": "1.2.3-beta.1",
   "bugs": "https://github.com/codifycli/codify/issues",
   "keywords": [
     "oclif",

package.json

@@ -2,8 +2,9 @@
 
 APPLE_DEVELOPER_APPLICATION_PROFILE=$(cat package.json | jq -r '.oclif.macos."application-certificate"')
 
-# @lydell/node-pty ships its native binaries in per-platform packages (e.g. @lydell/node-pty-darwin-arm64/prebuilds/darwin-arm64)
-for dir in node_modules/@lydell/node-pty-darwin-*/prebuilds/darwin-*; do
+# node-pty ships its native binaries for every platform in prebuilds/<platform>-<arch>. Sign the copy installed under the
+# @homebridge alias too, since plugins built before the node-pty switch load that one.
+for dir in node_modules/node-pty/prebuilds/darwin-* node_modules/@homebridge/node-pty-prebuilt-multiarch/prebuilds/darwin-*; do
   codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" "$dir/spawn-helper" --force
   codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" "$dir/pty.node" --force
 done

scripts/codesign.sh

@@ -62,6 +62,12 @@ console.log(chalk.magenta(`Generated help files for: ${commands.join(', ')}`))
 console.log(chalk.magenta('Install production dependencies'))
 execSync('npm install --production', { cwd: './.build', shell: 'zsh' })
 
+console.log(chalk.magenta('Removing Windows node-pty prebuilds'))
+execSync(
+  'rm -rf node_modules/node-pty/prebuilds/win32-* node_modules/@homebridge/node-pty-prebuilt-multiarch/prebuilds/win32-*',
+  { cwd: './.build', shell: 'zsh' }
+)
+
 console.log(chalk.magenta('Running oclif pkg macos'))
 execSync('oclif pack macos -r .', { cwd: './.build', shell: 'zsh' });
 

scripts/pkg.ts

@@ -1,4 +1,4 @@
-import { IPty, spawn } from '@lydell/node-pty';
+import { IPty, spawn } from 'node-pty';
 import chalk from 'chalk';
 import { Router } from 'express';
 import WebSocket from 'ws';

src/connect/http-routes/create-command.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@lydell/node-pty';
+import { spawn } from 'node-pty';
 import { ConfigFileSchema } from '@codifycli/schemas';
 import * as fs from 'node:fs/promises';
 import os from 'node:os';

src/connect/http-routes/handlers/apply-handler.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@lydell/node-pty';
+import { spawn } from 'node-pty';
 import { ConfigFileSchema } from '@codifycli/schemas';
 import * as fs from 'node:fs/promises';
 import os from 'node:os';

src/connect/http-routes/handlers/destroy-handler.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@lydell/node-pty';
+import { spawn } from 'node-pty';
 import { ConfigFileSchema } from '@codifycli/schemas';
 import { diffChars } from 'diff';
 import * as fs from 'node:fs/promises';

src/connect/http-routes/handlers/import-handler.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@lydell/node-pty';
+import { spawn } from 'node-pty';
 import { diffChars } from 'diff';
 import * as fs from 'node:fs/promises';
 import os from 'node:os';