{escape(title)}
' - f'{pic}- {rows}
{escape(title)}
' - f'{pic}{escape(title)}
' + f'{_html_prose(" ".join(lead_text.split()))}
') body.append(concepts_block) - - overview = _paragraphs(analysis.get("overview")) + detail_only = True if overview: # One heading in both modes: the topic a cold reader needs is the same shape whether # it is a change ("what changed") or an area ("what this is"), so the two headings this # used to swap between said nothing the field itself didn't already carry. - body.append("g1
"}}) two = out.index(">Two") - assert two < out.index('g1
g1
pic
"}, {**c, "title": "Two"}]}) - assert out.index('id="cw-concepts"') < out.index("live" in out
assert out.count('class="cw-vis cw-concept-vis"') == 1 and "pic
" in out @@ -1724,6 +1725,69 @@ def test_concepts_render_first_with_text_fallback_and_legacy_pages_are_unchanged assert "cw-concepts" not in pics({"pr": PR_PIC, "groups": {}}) +def test_concepts_replace_the_overview_with_a_bold_lead_and_picture_first_cards(): + c = {"title": "Two", "before": "a", "after": "b", "why": "c"} + out = pics({"pr": None, "groups": {}, "concepts": [{**c, "html": "pic
"}, c]}) + assert 'loadSession now falls back to the refresh token.
pic
") < first.index('class="cw-concept-title"') + assert first.count("g0
"}}, state={"meta": {"id": "x"}}) + assert 'g0
g0
"}}) + + +def test_review_bar_view_toggle_and_group_chips_ship_in_the_template_and_post_directly(): + tpl = _real_template() + assert 'id="cw-bar"' in tpl and tpl.count("data-ev=\"") >= 3 + for ev in ("COMMENT", "REQUEST_CHANGES", "APPROVE"): + assert f'data-ev="{ev}"' in tpl + assert "html.cw-general details.hunk>:not(summary)" in tpl and "'hr-groups'" in tpl and "'cw-view'" in tpl + assert "start(b,b.dataset.ev)" in tpl and "direct:viaBar" in tpl + assert "look good'" in tpl and "' checked'" in tpl and "body.cw-has-bar #plan-content{padding-bottom" in tpl + assert "'Looks good'" in tpl and "'Needs changes'" in tpl and "Code ok" not in tpl + assert "#cw-bar.cw-sug-rc [data-ev=REQUEST_CHANGES]" in tpl and "#cw-bar.cw-sug-ok [data-ev=APPROVE]" in tpl + assert "groupFileHunks(h).forEach(d=>{ d.open=false; })" in tpl + assert "': needs changes'" in tpl and "' unchecked'" in tpl and "marked Needs changes" in tpl + assert "hunk-viewed" not in tpl and "hr-viewed" not in tpl and "wt-viewed" not in tpl + assert "html.cw-general .cw-ov-detail{display:none}" in tpl + assert "groupMarks[keys[i]]" in tpl and "e.preventDefault(); e.stopPropagation();" in tpl + assert "nextGlossary!==base.glossary" in tpl + assert "resolve:[...pendingResolveSet],direct:viaBar" in tpl + assert "const groupKeys=()=>" in tpl and "t+'#'+seen[t]" in tpl and "delete groupMarks[k]);" not in tpl + + def test_load_visuals_counts_and_sanitises_concepts(tmp_path): c = {"title": "T", "before": "b", "after": "a", "why": "w"} raw = {"concepts": [{**c, "html": ""}], "groups": []} @@ -1747,3 +1811,19 @@ def test_legacy_visuals_json_without_concepts_loads_and_renders_unchanged(tmp_pa assert "concepts" not in clean and lines == ["visuals: 2 kept, 0 dropped"] assert "cw-concept" not in pics(clean) + + +def test_glossary_is_embedded_escaped_and_rechecked_and_a_legacy_page_is_unchanged(tmp_path): + _order, files = parsed() + template = TEMPLATE + "" + terms = [{"term": "Order Book", "def": "Resting orders."}] + out = render_html(ANALYSIS, files, template, now=FROZEN, glossary=terms) + blob = out.split('")[0] + assert "<" not in blob and json.loads(blob) == terms + legacy = render_html(ANALYSIS, files, template, now=FROZEN) + assert "cw-glossary" not in legacy and render_html(ANALYSIS, files, template, now=FROZEN, glossary=[]) == legacy + path = tmp_path / "glossary.json" + path.write_text(json.dumps([{"term": "ok", "def": "d"}, {"term": "x"}, "junk"])) + assert load_glossary(path) == [{"term": "ok", "def": "d"}] + path.write_text("not json") + assert load_glossary(path) == [] and load_glossary(tmp_path / "missing.json") == [] diff --git a/skills/code-walkthrough/scripts/test_walkthrough.py b/skills/code-walkthrough/scripts/test_walkthrough.py index 015ff51..85b14e3 100644 --- a/skills/code-walkthrough/scripts/test_walkthrough.py +++ b/skills/code-walkthrough/scripts/test_walkthrough.py @@ -427,21 +427,12 @@ def test_group_titles_reach_the_page(): assert "Everything else" in render_html(groups, files, {}) -def test_group_heading_carries_an_empty_viewed_placeholder(): - # The template's JS fills this live from localStorage; the render knows nothing about - # viewed state, so it ships empty, same convention as .hunk-count. +def test_per_file_viewed_markup_is_gone(): order, files = parsed() groups = story(order, files, [{"title": "Session handling", "paths": ["src/auth.py"]}], None) - assert '' in render_html(groups, files, {}) - - -def test_every_hunk_summary_carries_a_viewed_checkbox(): - order, files = parsed() - out = render_html(flat(order, files), files, {}) - - assert out.count('