From c2cc419c0839820265edd0b9eba17fe6a433681f Mon Sep 17 00:00:00 2001 From: Divyansh Vijayvergia Date: Tue, 3 Nov 2026 13:48:05 +0000 Subject: [PATCH] Read the Go SDK's _last_sha in the SDK consistency check The Go SDK records the spec commit each release was generated from in .codegen/_last_sha. Its .codegen/_openapi_sha is now a copy of that value kept for older tooling and is being phased out. TestConsistentDatabricksSdkVersion and the bump-sdk skill now read _last_sha. Both files hold the same value at every SDK release since v0.188.0, including the v0.193.0 pin on main. Co-authored-by: Isaac --- .agents/skills/bump-sdk/SKILL.md | 2 +- internal/build/sdk_consistency_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.agents/skills/bump-sdk/SKILL.md b/.agents/skills/bump-sdk/SKILL.md index 01a4fe53439..8ca4b0c4c6f 100644 --- a/.agents/skills/bump-sdk/SKILL.md +++ b/.agents/skills/bump-sdk/SKILL.md @@ -37,7 +37,7 @@ Steps 1-4 are the manual equivalent of the bumper (no bumper PR yet, a pinned ve **1. Resolve the target versions.** Use the SDK version the user gave. If they didn't specify one, look up the latest released version yourself (the newest `vX.Y.Z` tag at `https://github.com/databricks/databricks-sdk-go/tags`) instead of prompting for it. If they want "the version the Terraform provider vX.Y.Z uses", read the provider's `go.mod` at that tag: `https://raw.githubusercontent.com/databricks/terraform-provider-databricks/vX.Y.Z/go.mod`. -The accompanying OpenAPI SHA is pinned inside the SDK at that tag: `https://raw.githubusercontent.com/databricks/databricks-sdk-go/vX.Y.Z/.codegen/_openapi_sha`. +The accompanying OpenAPI SHA is pinned inside the SDK at that tag: `https://raw.githubusercontent.com/databricks/databricks-sdk-go/vX.Y.Z/.codegen/_last_sha`. Always bump the spec SHA together with the SDK; they are expected to move as a pair. **2. Apply the core bump.** diff --git a/internal/build/sdk_consistency_test.go b/internal/build/sdk_consistency_test.go index 61ed7ce1755..786b35f917d 100644 --- a/internal/build/sdk_consistency_test.go +++ b/internal/build/sdk_consistency_test.go @@ -36,7 +36,7 @@ func TestConsistentDatabricksSdkVersion(t *testing.T) { require.NotEmpty(t, version) // Read the OpenAPI SHA from the Go SDK at the version tag. - url := fmt.Sprintf("https://raw.githubusercontent.com/databricks/databricks-sdk-go/%s/.codegen/_openapi_sha", version) + url := fmt.Sprintf("https://raw.githubusercontent.com/databricks/databricks-sdk-go/%s/.codegen/_last_sha", version) resp, err := http.Get(url) //nolint:gosec require.NoError(t, err) defer resp.Body.Close()