Commit 2ebc5e1
docs: fix two incorrect Kernel claims in CONNECTION_PARAMETERS.md (#930)
* docs: fix two incorrect Kernel claims in CONNECTION_PARAMETERS.md
Two rows disagreed with the code:
- `_tls_client_cert_key_password`: documented as honored on Kernel (✅),
but the kernel path raises `NotSupportedError` when it is set
(`_kernel_tls_kwargs`, src/databricks/sql/backend/kernel/client.py) — the
kernel has no surface for an encrypted client key. Marked ❌ and noted the
workaround (unencrypted key, or Thrift). Also caveated the section callout,
which had claimed all TLS options are honored on both backends.
- `username` / `password`: the "raises `ValueError`" note is Thrift-only.
That error is raised inside `get_python_sql_connector_auth_provider`
(src/databricks/sql/auth/auth.py), which the kernel path never calls, so on
Kernel the params are silently ignored rather than rejected.
Doc-only change.
Co-authored-by: Isaac
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
* docs: correct _disable_pandas Kernel support in CONNECTION_PARAMETERS.md
_disable_pandas is a Python-side Arrow->row conversion toggle, not a wire
option. KernelResultSet inherits the shared _convert_arrow_table, which
reads connection.disable_pandas, so the flag is honored on the kernel path
too (the kernel returns Arrow that flows through the same conversion).
Mark the row Kernel-supported and drop it from the "ignored on Kernel"
summary list.
Co-authored-by: Isaac
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
* docs: clarify decimal/timestamp arrow-native flags (Thrift), verified live
Both `_use_arrow_native_decimals` and `_use_arrow_native_timestamps` look like
twin knobs, but behave oppositely when off — confirmed against a live warehouse:
- `_use_arrow_native_decimals=False`: no value-level effect. The wire encoding
becomes an Arrow string, but the connector unconditionally re-casts it back to
`decimal128` (`convert_decimals_in_arrow_table`), so fetches always yield
`Decimal`.
- `_use_arrow_native_timestamps=False`: genuinely returns Python `str` (Arrow
`string`) — there is no re-cast on the Arrow path — while `cursor.description`
still reports `'timestamp'`. The `timestampAsArrow=False` flag also wins over
the always-sent `timestampAsString=false` conf.
Doc-only change.
Co-authored-by: Isaac
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
* ai: apply changes for #930 (1 review thread)
Addresses:
- #3847633323 at CONNECTION_PARAMETERS.md:131
Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
---------
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
Co-authored-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>1 parent 4ed862d commit 2ebc5e1
1 file changed
Lines changed: 9 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
122 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
| |||
128 | 129 | | |
129 | 130 | | |
130 | 131 | | |
131 | | - | |
| 132 | + | |
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| |||
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
140 | | - | |
| 141 | + | |
141 | 142 | | |
142 | | - | |
143 | | - | |
| 143 | + | |
| 144 | + | |
144 | 145 | | |
145 | 146 | | |
146 | 147 | | |
| |||
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
189 | | - | |
| 190 | + | |
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
| |||
0 commit comments