diff --git a/.skills/planning-and-closure/SKILL.md b/.skills/planning-and-closure/SKILL.md index 6e12e26..acaf246 100644 --- a/.skills/planning-and-closure/SKILL.md +++ b/.skills/planning-and-closure/SKILL.md @@ -12,10 +12,11 @@ requires contract-level acceptance evidence. `plans/003-planning-process.md` is ## Before you open anything -1. Read `plans/registry.md` §"Next handoff". As of the last review **no - implementation milestone is `ready`** — the next three lines (Contract M003, - Bootstrap M003, Ecosystem M003 eggsearch) are *research/plan decisions*, not - execution. If your idea is one of them, the deliverable is a plan, not code. +1. Read the current `plans/registry.md` status tables and §"Next handoff". + Milestone status changes over time; use the registry and linked subsystem + roadmap as the authority instead of relying on remembered status snapshots. + If no implementation milestone is `ready`, author or update a plan before + implementing work that has not been handed off. 2. Check the subsystem roadmap (`plans/subsystems/-roadmap.md`). A plan may already exist under a name you did not guess. 3. Only then write anything. diff --git a/AGENTS.md b/AGENTS.md index 791185a..d796c3d 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -89,4 +89,4 @@ Read the index in `overview.md` and follow one link. Grouped by what they cover: ## Planning conventions - Closure discipline: `plans/closure//NNN-status.md`. Compilation ≠ closure. History never rewritten — correctives are new `NNNa` plans; superseded material goes to `plans/archive/`. -- Current handoff (source: `plans/registry.md`): no milestone is **in progress** and none is registered **ready**; the last open obligation of the 2026-10-23 review chain — Release Manifest M004, the ADR-0006 `eggpack-manifest 0.1.1` patch release and the compatibility record ADR-0006 §5.4 requires — is **closed**: `0.1.1` is published to crates.io (checksum `352c3e327159615b763298e911e239f1decc4a2c9e28c28be8ddd28e50515e37`, tagged `eggpack-manifest-v0.1.1`), and both narrowings the package carries — the ADR-0006 digest rule and the `3ef806f` document bound — are recorded as compatibility events. The 2026-10-23 post-implementation review chain is closed (Build/Qualification M007, M008, M009; CI/Release M003l, M003m, M003n; Planning Hygiene M003; Bootstrap M003a), and **ADR-0006 is accepted** (Option A), having gated CI M003l's digest-acceptance work package only. A follow-up review of that chain's own output registered and closed a second corrective chain: Build/Qualification M007a (digest zero-length read refusal), M008a (floor contradiction mask and ELF offset overflow), M009a (local producer operator defects, including an input-destroying staging path), and CI/Release M003o (renderer panic and digest diagnostics). **The chain's first hosted CI run failed on macOS and registered a third corrective, CI/Release M003p**: the shared bounded runner treated a failed process-group signal as fatal, but macOS refuses to signal a group holding the unreaped zombie of an exited child and reports `EPERM` where Linux signals it successfully, so an output-bound violation was reported as a launch failure. M003p decides by observing whether the child has exited rather than by reading the errno, and hosted run `40263176191` is green on all four lanes. Both review chains left one obligation open — ADR-0006 §5.2/§9's `eggpack-manifest 0.1.1` publication and the release-manifest compatibility record — and M004 owns it; the `0.1.1` package carries **two** narrowings of the published acceptance set, the ADR-0006 digest rule and the `3ef806f` document bound, and only the first had been recorded. **Blocked** are Ecosystem M004 (Gregg sibling bundle), Ecosystem M005 (CodeGG runfile bundle), and Ecosystem M006 (Egress archive pair), each on its named adoption evidence and bundle/archive review; the provenance/authenticity line is **planned** pending a dedicated trust ADR, and Python/wheel adapters are **planned** behind broader native adoption. Contract M003, Bootstrap M003, and Ecosystem M003a/M003b are closed, so the contract-conformance and bootstrap-installers subsystems have no open work. The next Eggpack line is whatever the registry lists as `ready`; if that table is empty, the next action is plan authoring, not implementation. +- Current handoff (source: `plans/registry.md`): CI/Release M003pa is **closed** under `plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md`; closure `plans/closure/ci-release-orchestration/003pa-status.md` records implementation `329a3dfdb166580de4770b2c6b2f046358983003` and hosted run `44118309795` green on all four lanes; no implementation milestone is **active** and none is registered **ready**; the next action is plan authoring, not implementation; the last open obligation of the 2026-10-23 review chain — Release Manifest M004, the ADR-0006 `eggpack-manifest 0.1.1` patch release and the compatibility record ADR-0006 §5.4 requires — is **closed**: `0.1.1` is published to crates.io (checksum `352c3e327159615b763298e911e239f1decc4a2c9e28c28be8ddd28e50515e37`, tagged `eggpack-manifest-v0.1.1`), and both narrowings the package carries — the ADR-0006 digest rule and the `3ef806f` document bound — are recorded as compatibility events. The 2026-10-23 post-implementation review chain is closed (Build/Qualification M007, M008, M009; CI/Release M003l, M003m, M003n; Planning Hygiene M003; Bootstrap M003a), and **ADR-0006 is accepted** (Option A), having gated CI M003l's digest-acceptance work package only. A follow-up review of that chain's own output registered and closed a second corrective chain: Build/Qualification M007a (digest zero-length read refusal), M008a (floor contradiction mask and ELF offset overflow), M009a (local producer operator defects, including an input-destroying staging path), and CI/Release M003o (renderer panic and digest diagnostics). **The chain's first hosted CI run failed on macOS and registered a third corrective, CI/Release M003p**: the shared bounded runner treated a failed process-group signal as fatal, but macOS refuses to signal a group holding the unreaped zombie of an exited child and reports `EPERM` where Linux signals it successfully, so an output-bound violation was reported as a launch failure. M003p decides by observing whether the child has exited rather than by reading the errno, and hosted run `40263176191` is green on all four lanes. A later review found that this does not prove the whole group is empty; M003pa is active to retry after reaping the leader and accept only a successful retry or `ESRCH`, keeping every other case fail-closed. Both review chains left one obligation open — ADR-0006 §5.2/§9's `eggpack-manifest 0.1.1` publication and the release-manifest compatibility record — and M004 owns it; the `0.1.1` package carries **two** narrowings of the published acceptance set, the ADR-0006 digest rule and the `3ef806f` document bound, and only the first had been recorded. **Blocked** are Ecosystem M004 (Gregg sibling bundle), Ecosystem M005 (CodeGG runfile bundle), and Ecosystem M006 (Egress archive pair), each on its named adoption evidence and bundle/archive review; the provenance/authenticity line is **planned** pending a dedicated trust ADR, and Python/wheel adapters are **planned** behind broader native adoption. Contract M003, Bootstrap M003, and Ecosystem M003a/M003b are closed, so the contract-conformance and bootstrap-installers subsystems have no open work. The next Eggpack line is whatever the registry lists as `ready`; if that table is empty, the next action is plan authoring, not implementation. diff --git a/architecture/ci-consumer-seam.md b/architecture/ci-consumer-seam.md index b254f72..ca8151c 100644 --- a/architecture/ci-consumer-seam.md +++ b/architecture/ci-consumer-seam.md @@ -210,9 +210,9 @@ narrower and still real. The *shape* of the invocation is fixed and finite — o interpreter, one script path, one candidate path, no shell, no argument vector, no env map (`consumer_validator.rs:526-534`). The *environment* is built by the shared runner, which clears it and re-adds a five-variable allowlist -(`crates/eggpack-core/src/builder.rs:735`, `753-754`); the CI side contributes only +(`crates/eggpack-core/src/builder.rs:737`, `755-756`); the CI side contributes only the caller's explicit `PATH` (`consumer_validator.rs:299-300`), stdin is null -(`builder.rs:736`), and the working directory is explicit +(`builder.rs:738`), and the working directory is explicit (`consumer_validator.rs:304`). The *outcome is bounded*: timeout, output limits, a seven-value classification; a validator cannot hang or flood the job. This is a **separation-of-concerns** mechanism: `Passed` means an independent script exited @@ -240,9 +240,9 @@ bounded runner in `eggpack-core`: Everything the old private runner did is therefore core's contract, not the CI crate's: process-group/job termination on every failure path, a cleared -environment with a five-variable allowlist (`builder.rs:735`, `753-754`), null -stdin (`builder.rs:736`), the exact output truncation in `drain` -(`builder.rs:942-958`, which keeps `n.min(limit - len)`), and the bounded reader +environment with a five-variable allowlist (`builder.rs:737`, `755-756`), null +stdin (`builder.rs:738`), the exact output truncation in `drain` +(`builder.rs:944-960`, which keeps `n.min(limit - len)`), and the bounded reader joins. The runner outcome maps onto the consumer-validation outcome exactly (`consumer_validator.rs:536-555`): success → `Passed`, non-zero exit → `Failed(NonZeroExit)`, deadline → `Failed(Timeout)`, output bound → @@ -442,7 +442,7 @@ Where enforcement is weaker than it looks: The two gaps that the private CI runner used to have — output retention above the cap, and a preflight that discarded its over-limit flags — are gone with it. Both now belong to the shared runner: `drain` truncates exactly -(`crates/eggpack-core/src/builder.rs:942-958`) and the preflight's over-limit +(`crates/eggpack-core/src/builder.rs:944-960`) and the preflight's over-limit outcome is a non-success runner outcome, which the CI side maps to `Failed(InterpreterUnavailable)` (`consumer_validator.rs:503-506`). diff --git a/architecture/cli.md b/architecture/cli.md index 0b3154a..c665bbf 100644 --- a/architecture/cli.md +++ b/architecture/cli.md @@ -607,7 +607,7 @@ characters (`411-416`), then delegates to `eggpack_core::run_git_bounded` peel, `git rev-parse --verify refs/tags/^{commit}` (`builder.rs:535-541`); both use the same bounded runner with a 30 s deadline (`builder.rs:29`), a 4 KiB retained-output cap (`builder.rs:31`), a -`command-group` process group, and a cleared environment (`builder.rs:735`). +`command-group` process group, and a cleared environment (`builder.rs:737`). See [process-execution.md](process-execution.md) for the workspace spawn contract. diff --git a/architecture/overview.md b/architecture/overview.md index 6ef4f51..e525c1e 100644 --- a/architecture/overview.md +++ b/architecture/overview.md @@ -9,11 +9,13 @@ It deliberately does **not** replace Eggup: Eggup remains the consumer-side verified installation/update/rollback layer, and the product repository owns release/install policy. See [eggup-manifest-consumer-v1.md](eggup-manifest-consumer-v1.md). -Code baseline `fa82486dab83d2369d330a3cef197a3651851c26` — the tree the line -counts and the `file:line` citations in this directory were measured and -verified against. That is the SHA the numbers below describe: this index changes -no Rust source, so the counts and citations stay true of the tree it commits onto. -Re-verify them against the workspace if you edit the overview again. +Code baseline `1cd6d0bf43c93dc9fd572c2d69a3a675a2958b09` — the committed source +immediately before M003pa. The core line counts below were measured and affected +citations checked by symbol against exact implementation candidate +`329a3dfdb166580de4770b2c6b2f046358983003`; hosted run `44118309795` passed all +four lanes. M003pa is closed; its evidence is recorded in +`plans/closure/ci-release-orchestration/003pa-status.md`. Remeasure and recheck +citations against any later source change. Milestone/evidence statuses are **not** restated here; `plans/registry.md` is the authority for those, and [principles-roadmap.md](principles-roadmap.md) narrates them. @@ -163,6 +165,18 @@ rewrites in the CLI, manifest, and GitHub source also preserved anchors. Affecte architecture citations were rechecked by symbol; the line-count table above remains pinned to `fa82486`. +**2026-11-17 — CI/Release M003pa process-group recheck (closed).** The shared +runner retries after reaping an exited leader and accepts only retry success or +`ESRCH`; a live or unverified group remains a hard failure. Deterministic helper +coverage and the release-marker live-descendant regression passed. The +`run_bounded` anchor is `builder.rs:698`; the timeout regression anchor is +`builder.rs:1835`, both checked by symbol name. The `eggpack-core` source count is +9109 (`builder.rs` 2078, `digest.rs` 325), measured against the implementation +candidate `329a3dfdb166580de4770b2c6b2f046358983003` from baseline +`1cd6d0bf43c93dc9fd572c2d69a3a675a2958b09`. `scripts/check-local.sh` passed, and +hosted run `44118309795` passed Linux stable, Linux 1.89.0, macOS, and Windows on +the exact candidate. Closure evidence: `plans/closure/ci-release-orchestration/003pa-status.md`. + ## How to read this document This file has two jobs, deliberately: @@ -241,18 +255,19 @@ contract manifest |---|---|---| | `eggpack-contract` | 2937 (2449 + 488 tests) | [contract.md](contract.md) | | `eggpack-manifest` | 1536 | [manifest.md](manifest.md) | -| `eggpack-core` | 8935 (6 files) | [core.md](core.md) | +| `eggpack-core` | 9109 (6 files) | [core.md](core.md) | | `eggpack-bootstrap` | 3587 | [bootstrap.md](bootstrap.md) | | `eggpack-ci` | 12945 (14 files) | [ci.md](ci.md) | | `eggpack-github` | 5498 (3439 + 2059 tests) | [github.md](github.md) | | `eggpack-cli` | 8523 (5711 + 2812 tests) | [cli.md](cli.md) | -Counts are Rust source lines per crate, measured against the baseline named -above: every `.rs` file under `crates//`, production and test code alike. -A count in parentheses is the split inside the total — `production + tests`. The -test code lives in a `#[cfg(test)]` module in `src/` for every crate except -`contract` (whose conformance and fixture tests are separate `tests/` targets) -and `ci` and `github` (whose test modules are separate out-of-line files). +Counts are Rust source lines per crate, measured on the current worktree +described above: every `.rs` file under `crates//`, production and test +code alike. A count in parentheses is the split inside the total — `production + +tests`. The test code lives in a `#[cfg(test)]` module in `src/` for every crate +except `contract` (whose conformance and fixture tests are separate `tests/` +targets) and `ci` and `github` (whose test modules are separate out-of-line +files). ### `eggpack-contract` — layout authority and validators @@ -300,10 +315,10 @@ revision verification and for the consumer validator: | File | Lines | Stage | Deep dive | |---|---|---|---| | `src/lib.rs` | 1384 | `PackConfig` → `ReleasePlan`, policy types, `build_manifest` | [core-planning.md](core-planning.md) | -| `src/builder.rs` | 1902 | bindings, command specs, bounded execution, candidate discovery | [core-build.md](core-build.md) | +| `src/builder.rs` | 2078 | bindings, command specs, bounded execution, candidate discovery | [core-build.md](core-build.md) | | `src/qualification.rs` | 2982 | qualification methods, host matching, evidence | [core-qualification.md](core-qualification.md) | | `src/finalization.rs` | 928 | `finalize_release`, archive assembly, manifest aggregation | [core-finalization.md](core-finalization.md) | -| `src/digest.rs` | 327 | the one bounded file-digest authority | [core-finalization.md](core-finalization.md) | +| `src/digest.rs` | 325 | the one bounded file-digest authority | [core-finalization.md](core-finalization.md) | | `src/floor.rs` | 1412 | bounded ELF compatibility-floor inspection | [core-qualification.md](core-qualification.md) | Crate-level orientation, dependency direction, and the cross-file data diff --git a/architecture/process-execution.md b/architecture/process-execution.md index a734987..643d6a8 100644 --- a/architecture/process-execution.md +++ b/architecture/process-execution.md @@ -15,10 +15,10 @@ share one set of guarantees. | Site | Entry point | Spawn call | Deadline | Group handling | Environment | | --- | --- | --- | --- | --- | --- | -| Core build + preflight | `run_bounded_cancellable` (`crates/eggpack-core/src/builder.rs:461`) | `group_spawn()` at `builder.rs:799` | `spec.timeout`, ≤ 86 400 s (`builder.rs:714`) | `command-group` group/job, `kill()` + `wait()` (`builder.rs:820-834`) | `env_clear()` + 19-variable builder allowlist (`builder.rs:735`, `756-778`) | -| Core qualification smoke (native) | `run_qualification_process` (`builder.rs:569`) | same `run_bounded` | `smoke.timeout_ms` | same shared path | narrower 5-var allowlist (`builder.rs:753-754`) | +| Core build + preflight | `run_bounded_cancellable` (`crates/eggpack-core/src/builder.rs:461`) | `group_spawn()` at `builder.rs:801` | `spec.timeout`, ≤ 86 400 s (`builder.rs:715-716`) | `command-group` group/job, `kill()` + `wait()` (`builder.rs:824-845`) | `env_clear()` + 19-variable builder allowlist (`builder.rs:737`, `758-779`) | +| Core qualification smoke (native) | `run_qualification_process` (`builder.rs:569`) | same `run_bounded` | `smoke.timeout_ms` | same shared path | narrower 5-var allowlist (`builder.rs:755-756`) | | Core qualification smoke (QEMU) | `run_qemu_process` (`builder.rs:580`) | same `run_bounded` | `smoke.timeout_ms` | same shared path | narrower 5-var allowlist | -| Core git revision verification | `run_git_bounded` (`builder.rs:512`) | same `run_bounded` | 30 s (`GIT_TIMEOUT`, `builder.rs:29`) | same shared path | 7-var allowlist incl. `HOME` (`builder.rs:743-752`) | +| Core git revision verification | `run_git_bounded` (`builder.rs:512`) | same `run_bounded` | 30 s (`GIT_TIMEOUT`, `builder.rs:29`) | same shared path | 7-var allowlist incl. `HOME` (`builder.rs:742-753`) | | CLI source verification | `verify_source_revision` (`crates/eggpack-cli/src/main.rs:410`) | delegates to `run_git_bounded` | same 30 s | same shared path | same 7-var allowlist | | CI consumer validator | `run_consumer_validator` (`crates/eggpack-ci/src/consumer_validator.rs:323`) → `run_validator_process` (`consumer_validator.rs:521`) | delegates to `run_interpreter_bounded` (`builder.rs:485`) | `validator.timeout_ms`, 1 000–600 000 ms (`consumer_validator.rs:87`) | same shared path — group/job kill on every failure path | same narrow 5-var allowlist, plus the caller's explicit `PATH` override (`consumer_validator.rs:299-300`) | | CI interpreter preflight | `run_interpreter_preflight` (`consumer_validator.rs:488`) | delegates to `run_interpreter_bounded` | `timeout_ms.min(30_000)` (`consumer_validator.rs:499`) | same shared path | same as above | @@ -26,14 +26,14 @@ share one set of guarantees. ### What is shared and what is independent The five `eggpack-core` entry points are thin wrappers over one private -function, `run_bounded` (`builder.rs:696`), reached through `run_bounded_inner` +function, `run_bounded` (`builder.rs:698`), reached through `run_bounded_inner` (`builder.rs:608`), differing only in the `ExecutableAllowance` passed: `Builder` (`builder.rs:128`), `Candidate`, `Qemu`, `Git`, and `Interpreter` (`builder.rs:132`). One implementation, one place to audit, one set of guarantees. The allowance is what keeps the set narrow: `Git` admits only the -literal `git` (`builder.rs:709`), exactly as `Qemu` admits only the three named +literal `git` (`builder.rs:711`), exactly as `Qemu` admits only the three named QEMU binaries and `Interpreter` admits only `python3` and `python` -(`builder.rs:710`). +(`builder.rs:708-710`). `eggpack-ci` shares it. The crate still declares no `command-group` dependency; it reaches the runner through `eggpack-core`, which already owns @@ -57,12 +57,12 @@ The runner matches an exact expected value internally rather than returning it. `CommandSpec::expected_stdout` is a substring containment check, which is right for a tool banner (`builder.rs:175-176`) but too weak for a revision identity; the new `expected_stdout_exact` field (`builder.rs:177-181`) compares the trimmed stdout -for equality (`builder.rs:886-891`), and a miss becomes -`CommandOutcome::Failed(-1)` (`builder.rs:898-899`) rather than an error carrying +for equality (`builder.rs:888-893`), and a miss becomes +`CommandOutcome::Failed(-1)` (`builder.rs:900-901`) rather than an error carrying output. The Git allowlist deliberately keeps `HOME` and `USERPROFILE` -(`builder.rs:745-746`) that the narrower candidate and QEMU allowlists drop. +(`builder.rs:747-748`) that the narrower candidate and QEMU allowlists drop. `git` resolves helpers from `PATH`, and `safe.directory` is commonly set in the global config; clearing `HOME` would make self-hosted runners fail closed for a reason unrelated to release integrity. @@ -82,7 +82,7 @@ the job's build directory. The workspace therefore never uses bare `Child::kill` on a build or qualification path; it uses `command-group` 5.0.1 (`crates/eggpack-core/Cargo.toml:24`, pinned in `Cargo.lock:61-64`). -`group_spawn()` (`builder.rs:799`) returns a `GroupChild` owning a group/job with +`group_spawn()` (`builder.rs:801`) returns a `GroupChild` owning a group/job with two different implementations: - **Unix:** the child is spawned with `process_group(0)`, i.e. `setpgid(0, 0)`, @@ -96,89 +96,74 @@ two different implementations: Killing is not enough. The group must then be *waited for*, twice over. In the timeout and cancellation branches, `kill()` is immediately followed by `wait()` -(`builder.rs:820-825` for cancellation, `builder.rs:827-832` for the deadline). On +(`builder.rs:823-828` for cancellation, `builder.rs:830-835` for the deadline). On Unix that `wait()` loops `waitpid` over the negated pgid precisely so that already-exited group members are reaped rather than left as zombies (`command-group` `src/stdlib/child/unix.rs:71-85`); on Windows it drains the job completion port with `INFINITE` before waiting on the child (`src/stdlib/child/windows.rs:97-99`). Second, after the loop breaks, `run_bounded_inner` requires a final `try_wait()` to return `Some`; a `None` is -the error `process cleanup incomplete` (`builder.rs:874-877`). Skipping either +the error `process cleanup incomplete` (`builder.rs:876-879`). Skipping either wait is what leaves orphans and zombies behind a timeout, and both are present. The CI validator creates no group of its own: it delegates to the shared runner, which creates the group or job object and kills and waits for it. -### Signalling a group that has already exited - -A group's only member is the supervised child. When that child has already -exited it stays in the group as a zombie until it is reaped, and the group -holds no process at all once it is reaped. `command-group` documents that a -group which has already exited produces an error from `kill`. - -**The two supported platforms disagree about the zombie case, and not in the -way the errno suggests.** Linux signals a zombie process group successfully. -macOS refuses to signal a group that holds one and reports the *whole* group -signal as `EPERM` — not `ESRCH`. A run whose child exited just before the -runner noticed that its output bound was exceeded therefore terminated -cleanly on Linux and failed on macOS, with the runner reporting -`output-limit process-group termination failed`. - -The runner's rule (`terminate_process_group`, `builder.rs:675-694`, and -`group_signal_failure_is_benign` beside it at `builder.rs:644-649`) is: a -failed group signal may be ignored when there is nothing left to terminate. -That is true in two cases. - -- The signal failed with `ESRCH` — the kernel's own statement that the group - holds no process. -- The signal failed with any other errno **and** the supervised child has - already exited. The child is then a zombie or already reaped, and a child - that has exited is not a process that can outlive the run. - -The second case is the one that matters, and it is decided by observing the -child rather than by reading the errno: `try_wait` both observes and reaps a -child that has already exited. A group that holds a **live** process and -still cannot be signalled remains a hard failure, so the run fails closed. - -This is exact rather than permissive. A descendant that outlives the child is -caught by the drain budget — a reader still parked at its budget means a -descendant holds the write end of a pipe, and the run fails closed with the -output-limit outcome and terminates the group again. - -The check is Unix-only. A Windows job object is terminated through -`TerminateJobObject`, which reports a different condition for an empty job -and uses a different error space, where the value `3` means -`ERROR_PATH_NOT_FOUND` rather than `ESRCH`. - -Two regression tests pin the rule. `terminating_an_already_exited_process_group_is_not_a_failure` -reaps a child and asserts that the dependency reports the empty group as an -error while the runner does not. `a_failed_group_signal_is_benign_only_when_nothing_is_left_to_terminate` -pins the decision itself: `ESRCH` is benign, `EPERM` is benign only when the -child has exited, and `EPERM` with a live child is not benign. - -Without this, a completed run was reported as a failed one, and the caller -misread the failure: the CI consumer-validator maps every runner error onto -`InterpreterUnavailable`, so an output-bound violation was reported as "the -interpreter could not be launched`. +### Rechecking a failed process-group signal + +`command-group` sends Unix group termination with `killpg`. Linux can signal a +zombie member, while macOS may report `EPERM` when a group contains an +unreaped zombie. `ESRCH` remains the kernel's direct indication that the group +does not exist. + +M003p correctly addressed the macOS output-limit failure, but its exception +was too broad: `GroupChild::try_wait` reports only the supervised leader's +state. Reaping that leader does not prove the process group is empty; a live +descendant can remain, including one that closed stdout and stderr. The drain +budget detects descendants that keep a pipe open, but pipe completion is not +evidence that every group member has exited. + +The corrected rule (`terminate_process_group` and +`group_signal_failure_is_benign` in `crates/eggpack-core/src/builder.rs`) is: + +- Initial `ESRCH` is benign because the group is absent. +- For another initial signal error, a live or unverified supervised child is +a hard failure. +- If the supervised child has exited, `try_wait` reaps it and the runner + retries the group signal. Retry success means the group signal was sent to + remaining members; retry `ESRCH` proves the group is empty. Every other retry + error, including `EPERM`, remains a hard failure. + +Thus the zombie-only macOS case can resolve to an empty group on retry, but a +leader's exit alone never suppresses a group-signal failure. The rule is +Unix-only. Windows job objects use `TerminateJobObject` and a different error +space, where the value `3` means `ERROR_PATH_NOT_FOUND`, not `ESRCH`; their +behavior is unchanged. + +The regression suite pins the decision with injected signal outcomes, +retains the real empty-group case, and exercises termination with a live +descendant after its leader exits. The output-overflow test continues to cover +the actual bounded-runner path. M003pa is not closed until the local gate and +hosted macOS, Linux stable/MSRV, and Windows lanes pass on the same candidate. ## Timeouts and cancellation `run_bounded_inner` validates its own bounds before spawning and fails closed -with `invalid process bounds or executable` (`builder.rs:712-721`): timeout must +with `invalid process bounds or executable` (`builder.rs:714-723`): timeout must be non-zero and at most 86 400 s, and both output limits must be in `1..=MAX_OUTPUT` where `MAX_OUTPUT = 256 * 1024` (`builder.rs:20`). -The deadline is `Instant::now() + spec.timeout` (`builder.rs:819`) enforced by a -poll loop (`builder.rs:820-859`), not a blocking wait: each iteration calls -`child.try_wait()` (`builder.rs:845-850`) and sleeps 20 ms (`builder.rs:852`). +The deadline is `Instant::now() + spec.timeout` (`builder.rs:821`) enforced by a +poll loop (`builder.rs:822-855`), not a blocking wait: each iteration calls +`child.try_wait()` (`builder.rs:847-852`) and sleeps 20 ms (`builder.rs:854`). Polling is what makes cancellation observable at all — a blocking `wait()` would only notice a flag after the child had already exited. Ordering inside the loop is the contract. Cancellation is tested first -(`builder.rs:821`), the deadline second (`builder.rs:828`), the output bound -third (`builder.rs:835`), exit status last (`builder.rs:845`). When cancellation +(`builder.rs:823`), the deadline second (`builder.rs:830`), the output bound +third (`builder.rs:840`), exit status last (`builder.rs:847`). When cancellation and the deadline apply in the same iteration, the run breaks with -`(false, true, false)` and is classified `Cancelled` (`builder.rs:826`, +`(false, true, false)` and is classified `Cancelled` (`builder.rs:828`, `builder.rs:232`). A cancelled build therefore never reports as timed out, and an over-limit run is reported as an output-limit failure rather than as a build failure. The CI validator inherits that precedence unchanged and maps each @@ -186,35 +171,35 @@ runner outcome onto its own typed failure. A pre-loop cancellation check also exists in `qualification.rs:887-899`, so a cancelled qualification does not spawn at all. -Timeouts in use: builds get 1800 s (`builder.rs:1120`); toolchain preflights get -10 s each (`builder.rs:975`, `builder.rs:995`, `builder.rs:1025`, -`builder.rs:1044`); the QEMU emulator preflight gets 10 s +Timeouts in use: builds get 1800 s (`builder.rs:1122`); toolchain preflights get +10 s each (`builder.rs:977`, `builder.rs:997`, `builder.rs:1027`, +`builder.rs:1046`); the QEMU emulator preflight gets 10 s (`qualification.rs:845`); smoke runs get `smoke.timeout_ms` bounded to `1..=86_400_000` (`qualification.rs:151-152`); CI validator runs get `1_000..=600_000` ms (`consumer_validator.rs:87`) with the preflight further capped at 30 s (`consumer_validator.rs:499`). How a timeout reaches the caller: never as an error. `run_bounded_inner` returns -`Ok(ProcessEvidence)` with `CommandOutcome::TimedOut` (`builder.rs:892-893`, +`Ok(ProcessEvidence)` with `CommandOutcome::TimedOut` (`builder.rs:894-895`, enum at `builder.rs:224-235`). The build path converts any non-`Success` outcome into a `BuildAttempt` carrying the evidence and no candidates -(`builder.rs:1123-1150`). A timeout is therefore a recorded, typed, +(`builder.rs:1125-1134`). A timeout is therefore a recorded, typed, non-success *result*, not a raised error — which is what keeps a hung build from looking like a crash. One fidelity caveat in that classification: a failed `expected_stdout` check maps -to `CommandOutcome::Failed(-1)` (`builder.rs:898-899`), and a signal-terminated +to `CommandOutcome::Failed(-1)` (`builder.rs:900-901`), and a signal-terminated process also maps to `Failed(-1)` via `status.code().unwrap_or(-1)` -(`builder.rs:903`). Callers cannot distinguish a version mismatch from a +(`builder.rs:905`). Callers cannot distinguish a version mismatch from a signal kill by outcome alone. ## Output bounding and the no-output-leak rule Both stdout and stderr are piped and drained by dedicated threads -(`builder.rs:737-738`, threads at `builder.rs:815` and `498`). `drain` -(`builder.rs:942-958`) reads in 8 KiB chunks, keeps at most +(`builder.rs:739-740`, threads at `builder.rs:817`, `820`, and `498`). `drain` +(`builder.rs:944-960`) reads in 8 KiB chunks, keeps at most `limit - already_captured` bytes, and sets an overflow flag when a chunk does not -fit (`builder.rs:948-953`). Oversized output is *dropped*, not buffered to disk +fit (`builder.rs:947-955`). Oversized output is *dropped*, not buffered to disk and not truncated-with-a-tail. Both reader threads are joined before the outcome is computed, under a bounded budget (`join_drained`, `builder.rs`): a reader returns only at pipe EOF, which needs every write end closed, so a descendant @@ -226,26 +211,26 @@ removes a false-success path: a child that exits zero while a descendant holds the pipe used to be reported as a success with incomplete captured output. Overflow is a first-class failure. If either flag is set, the outcome is -`CommandOutcome::OutputLimitExceeded` (`builder.rs:896-897`), ranked below +`CommandOutcome::OutputLimitExceeded` (`builder.rs:898-899`), ranked below timeout and cancellation but above exit status — an over-limit run is never reported as a build failure, so an unbounded log flood cannot be mistaken for a compiler error. The CI validator used to cap the same way with readers of its own and to detect the overflow *promptly* rather than at the deadline. It no longer has readers -of its own: the shared `drain` (`builder.rs:942`) does the capping, and the +of its own: the shared `drain` (`builder.rs:944`) does the capping, and the shared runner detects the overflow promptly — `stream_over_limit` -(`builder.rs:938`) reads the same flag the drain thread sets, and the runner -terminates the whole group at the moment of excess (`builder.rs:835-846`). +(`builder.rs:940`) reads the same flag the drain thread sets, and the runner +terminates the whole group at the moment of excess (`builder.rs:840-845`). That prompt detection was CI's strength and it is now the shared runner's: a process that exceeds its output bound is killed when it exceeds it, not when its deadline arrives. The observable outcome is unchanged. The decisive rule is that **captured output contents never cross the API boundary.** `ProcessEvidence` carries only an outcome and two byte counts -(`builder.rs:256-263`, constructed at `builder.rs:905-909`); it has no output +(`builder.rs:256-263`, constructed at `builder.rs:907-911`); it has no output fields at all. The `expected_stdout` version substring is compared inside -`run_bounded_inner` (`builder.rs:886-891`) and is never stored, logged, or +`run_bounded_inner` (`builder.rs:888-893`) and is never stored, logged, or returned — the field's own doc comment says so (`builder.rs:175-176`). `ConsumerValidationEvidenceV1` is built from identity, interpreter, outcome, size, and digest only (`consumer_validator.rs:267-277`). @@ -259,15 +244,15 @@ failure text anywhere. ## Environment clearing and the allowlist -Every bounded spawn begins with `env_clear()` (`builder.rs:735`); the CI +Every bounded spawn begins with `env_clear()` (`builder.rs:737`); the CI validator reaches that same call through the shared runner. Nothing is inherited implicitly. Each variable is then re-added -only if it is present in the parent (`builder.rs:779-783`), and finally the +only if it is present in the parent (`builder.rs:781-785`), and finally the per-spec explicit overrides are applied with `command.envs(&spec.env)` -(`builder.rs:797`) — for a build, that is exactly `CARGO_TARGET_DIR` +(`builder.rs:799`) — for a build, that is exactly `CARGO_TARGET_DIR` (`builder.rs:442-446`). -The builder allowlist (`builder.rs:755-778`): +The builder allowlist (`builder.rs:758-779`): | Variable | Why it is allowed | | --- | --- | @@ -288,7 +273,7 @@ The builder allowlist (`builder.rs:755-778`): | `UniversalCRTSdkDir`, `UCRTVersion` | Universal CRT root and version. | Candidate and QEMU runs get a deliberately narrower set — `PATH`, `SystemRoot`, -`WINDIR`, `TEMP`, `TMP` (`builder.rs:753-754`). The untrusted binary being +`WINDIR`, `TEMP`, `TMP` (`builder.rs:755-756`). The untrusted binary being smoke-tested gets no `CARGO_HOME`, no `RUSTUP_HOME`, and no MSVC variables. This is the meaningful containment: a candidate that can observe the toolchain roots learns where the build machine's toolchain lives. @@ -300,7 +285,7 @@ security one. The CI validator no longer restates an allowlist. It runs under the narrow five-variable allowance that the candidate and QEMU runs use — `PATH`, -`SystemRoot`, `WINDIR`, `TEMP`, `TMP` (`builder.rs:753-754`) — which is the +`SystemRoot`, `WINDIR`, `TEMP`, `TMP` (`builder.rs:755-756`) — which is the same allowance the interpreter needs to locate its runtime. `PATH` may be replaced wholesale by a caller-supplied directory list (`consumer_validator.rs:299-300`), which is what keeps missing-interpreter tests hermetic; that override is a @@ -310,14 +295,14 @@ test-and-fixture facility, and its value is fully caller-controlled. eggpack does not provision a Windows C toolchain and does not pretend to. The MSVC variables in the allowlist are *preserved if already present* and otherwise -simply absent (`builder.rs:779-783`). Provisioning is the caller's and CI's +simply absent (`builder.rs:781-785`). Provisioning is the caller's and CI's responsibility: `.github/workflows/ci.yml:43-46` runs `ilammy/msvc-dev-cmd@v1` with `arch: x64` before any Windows build, and `.github/workflows/ci.yml:47-56` then verifies that `VCToolsInstallDir` is set and that `link.exe` resolves underneath it. The one adjustment eggpack makes is path ordering. On Windows, if -`VCToolsInstallDir` is set, `builder.rs:784-796` prepends +`VCToolsInstallDir` is set, `builder.rs:786-798` prepends `%VCToolsInstallDir%/bin/Hostx64/x64` to the copied `PATH`. `env_clear()` has discarded the environment `msvc-dev-cmd` carefully assembled, and this restores the single entry that determines which `link.exe` is used; the wider MSVC @@ -326,25 +311,25 @@ about them. The consequence on an uninitialized Windows host is bounded and quiet. `cargo` is found through `PATH`, finds no `link.exe`, exits non-zero, and the run is recorded -as `CommandOutcome::Failed(code)` (`builder.rs:902-903`) — or `Failed(-1)` if the +as `CommandOutcome::Failed(code)` (`builder.rs:904-905`) — or `Failed(-1)` if the tool was signal-terminated. The diagnostic that would explain *why* the link failed stays inside the discarded stderr buffer: only `stderr_bytes` is reported -(`builder.rs:908`). An operator sees "build failed, N bytes of stderr", and the +(`builder.rs:910`). An operator sees "build failed, N bytes of stderr", and the missing-environment diagnosis has to come from the CI step that checks for it, not from the captured linker output. ## The executable allowlist (ADR-0004 boundary) `ExecutableAllowance` (`builder.rs:127-132`) is the per-strategy restriction on -what may be executed. It is evaluated at `builder.rs:701-711`, *before* any +what may be executed. It is evaluated at `builder.rs:703-713`, *before* any `Command` is constructed, and a non-matching executable is rejected with -`invalid process bounds or executable` (`builder.rs:712-721`). +`invalid process bounds or executable` (`builder.rs:714-723`). | Allowance | Permitted executable | Enforcement | | --- | --- | --- | -| `Builder` | exactly `cargo`, `rustc`, or `zig` | `matches!(spec.executable.as_str(), ...)` (`builder.rs:702-704`) | -| `Candidate` | any **absolute** path, which must then be made executable | `Path::new(&spec.executable).is_absolute()` (`builder.rs:705`) | -| `Qemu` | exactly `qemu-x86_64`, `qemu-aarch64`, or `qemu-arm` | `matches!(...)` (`builder.rs:706-708`) | +| `Builder` | exactly `cargo`, `rustc`, or `zig` | `matches!(run.executable, ...)` (`builder.rs:704-706`) | +| `Candidate` | any **absolute** path, which must then be made executable | `Path::new(run.executable).is_absolute()` (`builder.rs:707`) | +| `Qemu` | exactly `qemu-x86_64`, `qemu-aarch64`, or `qemu-arm` | `matches!(...)` (`builder.rs:708-710`) | This is the enforcement point for ADR-0004's rejection of a generic shell DSL and of a "run whatever" escape hatch (`architecture/principles-roadmap.md:94-98`). @@ -364,7 +349,7 @@ executable is `candidate.path` from a discovered candidate artifact (`qualification.rs:917`), which was itself produced by a bounded build, re-verified, and made executable. So the candidate allowance trusts a path's origin, not its name. That is a deliberate difference in mechanism, and it is -why `ensure_candidate_executable` runs at `builder.rs:726-730` and a failure +why `ensure_candidate_executable` runs at `builder.rs:728-731` and a failure there is a build error rather than a spawn. The CI side closes the same hole twice over. The interpreter is a @@ -380,16 +365,16 @@ constructed. ## Preflight checks and their strength -`preflight` (`builder.rs:961-1058`) runs before any build, called from -`execute_target_cancellable` at `builder.rs:1104`. The checks are not of uniform +`preflight` (`builder.rs:963-1060`) runs before any build, called from +`execute_target_cancellable` at `builder.rs:1083`. The checks are not of uniform strength, and stating otherwise would misrepresent the guarantee. | Tool | Command | `expected_stdout` | Strength | | --- | --- | --- | --- | -| `rustc` | `+ --version` (`builder.rs:967-980`) | `None` (`builder.rs:978`) | **Exit status only** | -| `cargo` | `+ --version` (`builder.rs:987-1000`) | `None` (`builder.rs:998`) | **Exit status only** | -| `cargo-zigbuild` | `zigbuild --version` (`builder.rs:1020-1033`) | `Some("cargo-zigbuild ")` (`builder.rs:1031`) | **Substring verified** | -| `zig` | `version` (`builder.rs:1039-1052`) | `Some()` (`builder.rs:1049`) | **Substring verified** | +| `rustc` | `+ --version` (`builder.rs:968-982`) | `None` (`builder.rs:980`) | **Exit status only** | +| `cargo` | `+ --version` (`builder.rs:988-1002`) | `None` (`builder.rs:1000`) | **Exit status only** | +| `cargo-zigbuild` | `zigbuild --version` (`builder.rs:1021-1034`) | `Some("cargo-zigbuild ")` (`builder.rs:1033`) | **Substring verified** | +| `zig` | `version` (`builder.rs:1040-1052`) | `Some()` (`builder.rs:1051`) | **Substring verified** | | QEMU | ` --version` (`qualification.rs:840-850`) | `None` (`qualification.rs:848`) | **Exit status only** | | Python 3 | `--version` (`consumer_validator.rs:497`, run at `consumer_validator.rs:503`) | `expected_stdout` = `"Python 3"` (`consumer_validator.rs:502`) | **Substring verified** (`"Python 3"`) | @@ -406,14 +391,14 @@ exit-status-only, though there tool identity is a fixed finite mapping A missing interpreter is a failure, never a skip: an unusable `python3` returns `InterpreterUnavailable` (`consumer_validator.rs:551-554`) rather than passing validation vacuously. A missing cargo-zigbuild or Zig declaration is rejected before spawn -(`builder.rs:1044`, `builder.rs:1018`). +(`builder.rs:1014`, `builder.rs:1020`). ## No shell interpretation Every production spawn passes an argument vector to `Command::new` plus `.args`/`.arg`. There is no `sh -c`, no `cmd /C`, and no shell string anywhere in a spawn path. Core: `Command::new(run.executable).args(run.args)` -(`builder.rs:731-734`). CI: the same shared call, with the argv built as +(`builder.rs:733-736`). CI: the same shared call, with the argv built as OS-native arguments — script path and candidate path (`consumer_validator.rs:530-533`). Because no shell is involved, the workspace does not need to escape, quote, or diff --git a/architecture/testing-and-portability.md b/architecture/testing-and-portability.md index 50e29f5..fae8fd9 100644 --- a/architecture/testing-and-portability.md +++ b/architecture/testing-and-portability.md @@ -34,7 +34,7 @@ Two topologies coexist. **Inline `mod tests`.** Eight modules declared inside `src/*.rs`: `bootstrap/src/lib.rs:1066`, `cli/src/main.rs:1628`, `contract/src/lib.rs:1780`, -`core/src/lib.rs:770`, `core/src/builder.rs:1278`, `core/src/finalization.rs:491`, +`core/src/lib.rs:770`, `core/src/builder.rs:1281`, `core/src/finalization.rs:491`, `core/src/qualification.rs:1314`, and `manifest/src/lib.rs:424`. What this buys: tests can reach `pub(crate)` and private items without widening @@ -241,7 +241,7 @@ outputs, so running them twice buys nothing. | `ilammy/msvc-dev-cmd@v1` (arch x64) | 43-46 | Rust's MSVC toolchain needs an initialized developer environment before any Cargo build; without it `link.exe` is absent and the real-Cargo tests fail with a linker error, not a code failure | | Verify initialized MSVC linker environment | 47-56 | Fails fast and legibly: throws if `VCToolsInstallDir` is unset, and throws if `link.exe` resolves *outside* that directory. Guards against silently picking up a different `link.exe` on `PATH` | | Windows builder real Cargo candidate smoke | 57-59 | `real_local_cargo_fixture_builds_a_direct_candidate`; the only lane that proves a real Cargo build links on Windows | -| Process-group timeout and cancellation | 60-62 | `timeout_kills_and_waits_for_the_process_group` (`crates/eggpack-core/src/builder.rs:1757`); process-group/job semantics differ most on Windows | +| Process-group timeout and cancellation | 60-62 | `timeout_kills_and_waits_for_the_process_group` (`crates/eggpack-core/src/builder.rs:1835`); process-group/job semantics differ most on Windows | | Core tests serialized for diagnosis | 63-65 | `-- --test-threads=1`. A serialization workaround: the suite exhibits nondeterministic failures under parallel execution on Windows, so the Windows lane trades coverage speed for signal | | Windows CI crate tests | 66-68 | `-p eggpack-ci` on Windows — the CI crate has no `#[cfg(windows)]` block left; its Windows paths are runtime target checks (`crates/eggpack-ci/src/render_github.rs:230`, `crates/eggpack-ci/src/handoff.rs:380`) plus `cfg!(windows)` (`crates/eggpack-ci/src/consumer_validator.rs:220`), which Linux never exercises | | Verify pwsh 7 + `tar.exe` | 69-75 | `tar.exe` ships in the Windows image but is not guaranteed; the archive qualification lane requires both, so prerequisite failure is separated from test failure | diff --git a/architecture/validation-model.md b/architecture/validation-model.md index bd97fe6..12229fc 100644 --- a/architecture/validation-model.md +++ b/architecture/validation-model.md @@ -109,7 +109,7 @@ be a breaking change to that document only. | Crate | Enforcing sites | | --- | --- | -| core | `lib.rs:654`, `lib.rs:680`, `lib.rs:716`, `builder.rs:310`, `builder.rs:1091`, `finalization.rs:74`, `qualification.rs:138`, `qualification.rs:337`, `qualification.rs:593` | +| core | `lib.rs:654`, `lib.rs:680`, `lib.rs:716`, `builder.rs:310`, `builder.rs:1093`, `finalization.rs:74`, `qualification.rs:138`, `qualification.rs:337`, `qualification.rs:593` | | bootstrap | `lib.rs:323`, `lib.rs:409` | | ci | `consumer_validator.rs:80`, `:184`, `handoff.rs:78`, `:192`, `identity.rs:105`, `:199`, `planning.rs:191`, `:235`, `release_plan.rs:171` | | github | `lib.rs:175`, `:339`, `:433`, `:792`, `:929` | diff --git a/crates/eggpack-core/src/builder.rs b/crates/eggpack-core/src/builder.rs index 1e7fb80..5b826b9 100644 --- a/crates/eggpack-core/src/builder.rs +++ b/crates/eggpack-core/src/builder.rs @@ -625,53 +625,53 @@ fn run_bounded_inner( run_bounded(&run, cancellation, allowance) } -/// Whether a failed group signal can be ignored. +/// Whether a failed group signal is resolved by the kernel or a safe retry. /// -/// `ESRCH` means the group holds no process at all, which is exactly the -/// state the signal was meant to reach. +/// `ESRCH` proves the group is absent. For another error, an exited leader +/// must first be reaped and the whole group signalled again; only a successful +/// retry or retry `ESRCH` establishes that termination is complete. /// -/// Otherwise the supervised child may have exited between the decision to -/// terminate and the signal itself. It then stays in the group as a zombie -/// until it is reaped, and an unreaped zombie cannot be signalled: Linux -/// signals the group anyway, while macOS refuses the whole group and reports -/// `EPERM`. When the child has already exited there is no child left to -/// terminate, so the failure is benign for the same reason `ESRCH` is. +/// The initial error is not proof that the group is empty. In particular, +/// macOS `EPERM` can mean a group member is unsignalable, not absent. +/// `try_wait` reports only the supervised leader and cannot inventory the +/// remaining process group. /// -/// A group that holds a live process and still cannot be signalled is a hard -/// failure. That is the case where the child has not exited and the errno is -/// not `ESRCH`, and the run must fail closed. +/// The retry closure is lazy and runs only after the leader has exited and +/// been reaped. It sends the same group signal again, so live descendants are +/// still targeted. Any retry error other than `ESRCH` remains a hard failure. +/// Pipe EOF is not group inventory: descendants may close inherited pipes +/// and remain alive. This helper is used by each Unix termination path. #[cfg(unix)] -fn group_signal_failure_is_benign(error: &std::io::Error, child_exited: bool) -> bool { +fn group_signal_failure_is_benign( + error: &std::io::Error, + child_exited: bool, + retry_group_signal: impl FnOnce() -> std::io::Result<()>, +) -> bool { if error.raw_os_error() == Some(libc::ESRCH) { return true; } - child_exited + if !child_exited { + return false; + } + match retry_group_signal() { + Ok(()) => true, + Err(retry_error) => retry_error.raw_os_error() == Some(libc::ESRCH), + } } -/// Terminate the supervised process group, tolerating a group with nothing -/// left to terminate. +/// Terminate the supervised process group, tolerating only proven completion. /// -/// The group's only member is the supervised child. When that child has -/// already exited it stays in the group as a zombie until it is reaped, and -/// the group holds no process at all once it is reaped. Signalling a group -/// that holds nothing is reported by the kernel as `ESRCH` — "no such -/// process group" — and `command-group` documents that a group which has -/// already exited produces an error from `kill`. +/// On macOS, signalling a group containing an unreaped zombie can fail with +/// `EPERM`; reaping the leader may make the group empty, but it may also leave +/// live descendants. Therefore, after any non-`ESRCH` failure, the runner +/// reaps an exited leader and retries the group signal. A successful retry +/// reaches remaining members; retry `ESRCH` proves the group is empty. Every +/// other retry error remains a hard failure. /// -/// The two supported platforms disagree about the zombie case. Linux signals -/// a zombie successfully, while macOS refuses to signal a group that holds -/// one and reports `EPERM` for the whole group. A run whose child exited just -/// before the runner noticed that its output bound was exceeded would -/// therefore terminate cleanly on one platform and fail on the other, and it -/// would report an output-bound violation as a launch failure, because the -/// caller maps every runner error onto that outcome. -/// -/// This is exact rather than permissive. `ESRCH` is the kernel's own -/// statement that the group holds no process, and a child that has already -/// exited is not a process that can outlive the run. A descendant that -/// outlives the child is caught by the drain budget, which fails the run -/// closed. Every other case — a group that holds a live process and cannot -/// be signalled — remains a hard failure. +/// The drain budget detects a descendant that keeps a pipe open, but a +/// descendant that closes its pipes is not observable through that budget. +/// Group termination, not pipe state or leader status, is the authority here. +/// Existing timeout, cancellation, and output-limit classification is unchanged. fn terminate_process_group( child: &mut command_group::GroupChild, message: &str, @@ -679,15 +679,17 @@ fn terminate_process_group( match child.kill() { Ok(()) => Ok(()), Err(error) => { - // `try_wait` reaps a child that has already exited, so this both - // observes and clears the zombie that made the signal fail. - let child_exited = matches!(child.try_wait(), Ok(Some(_))); + // Reap the leader before retrying; its exit alone says nothing + // about other members that may still be in the process group. + let child_wait = child.try_wait(); + #[cfg(unix)] + let child_exited = child_wait.as_ref().is_ok_and(Option::is_some); #[cfg(unix)] - if group_signal_failure_is_benign(&error, child_exited) { + if group_signal_failure_is_benign(&error, child_exited, || child.kill()) { return Ok(()); } #[cfg(not(unix))] - let _ = child_exited; + let _ = child_wait; Err(build_err(message)) } } @@ -1692,15 +1694,91 @@ mod tests { } #[cfg(unix)] #[test] - fn a_failed_group_signal_is_benign_only_when_nothing_is_left_to_terminate() { + fn a_failed_group_signal_is_benign_only_after_recheck_proves_termination() { let no_such_group = std::io::Error::from_raw_os_error(libc::ESRCH); let not_permitted = std::io::Error::from_raw_os_error(libc::EPERM); - // The group is empty. - assert!(group_signal_failure_is_benign(&no_such_group, false)); - // The group holds only the zombie of a child that already exited. - assert!(group_signal_failure_is_benign(¬_permitted, true)); - // The group holds a live process that cannot be signalled. - assert!(!group_signal_failure_is_benign(¬_permitted, false)); + + assert!(group_signal_failure_is_benign( + &no_such_group, + false, + || { panic!("ESRCH must not trigger a retry") } + )); + assert!(!group_signal_failure_is_benign( + ¬_permitted, + false, + || { panic!("a live or unverified child must not trigger a retry") } + )); + assert!(group_signal_failure_is_benign(¬_permitted, true, || Ok( + () + ))); + assert!(group_signal_failure_is_benign(¬_permitted, true, || { + Err(std::io::Error::from_raw_os_error(libc::ESRCH)) + })); + assert!(!group_signal_failure_is_benign( + ¬_permitted, + true, + || { Err(std::io::Error::from_raw_os_error(libc::EPERM)) } + )); + } + #[cfg(unix)] + #[test] + fn terminating_an_exited_leader_still_signals_a_live_group_descendant() { + let root = crate::test_temp_dir("group-descendant-termination"); + let started = root.join("descendant-started"); + let release = root.join("descendant-release"); + let survived = root.join("descendant-survived"); + let started_arg = started.to_string_lossy().into_owned(); + let release_arg = release.to_string_lossy().into_owned(); + let survived_arg = survived.to_string_lossy().into_owned(); + let mut command = Command::new("sh"); + command.args([ + "-c", + "sh -c 'printf started > \"$1\"; while [ ! -e \"$2\" ]; do sleep 0.01; done; printf survived > \"$3\"' sh \"$1\" \"$2\" \"$3\" >/dev/null 2>&1 & exit 0", + "group-fixture", + started_arg.as_str(), + release_arg.as_str(), + survived_arg.as_str(), + ]); + let mut child = command.group_spawn().unwrap(); + + let leader_deadline = Instant::now() + Duration::from_secs(3); + let leader_status = loop { + match child.try_wait() { + Ok(Some(status)) => break Some(status), + Ok(None) if Instant::now() < leader_deadline => { + thread::sleep(Duration::from_millis(10)); + } + _ => break None, + } + }; + let descendant_deadline = Instant::now() + Duration::from_secs(1); + while !started.is_file() && Instant::now() < descendant_deadline { + thread::sleep(Duration::from_millis(10)); + } + + let terminated = terminate_process_group(&mut child, "test termination").is_ok(); + if !terminated { + let _ = child.kill(); + } + // If a live descendant was incorrectly left behind, releasing it makes + // it write a marker rather than relying on an arbitrary sleep duration. + fs::write(&release, "release").unwrap(); + let survivor_deadline = Instant::now() + Duration::from_secs(1); + while !survived.is_file() && Instant::now() < survivor_deadline { + thread::sleep(Duration::from_millis(10)); + } + let descendant_started = started.is_file(); + let descendant_survived = survived.exists(); + let leader_succeeded = leader_status.is_some_and(|status| status.success()); + fs::remove_dir_all(root).unwrap(); + + assert!(leader_succeeded, "the group leader must exit normally"); + assert!(descendant_started, "the live descendant fixture must start"); + assert!(terminated, "the process group must be terminated"); + assert!( + !descendant_survived, + "the descendant must not outlive group termination" + ); } #[test] fn nonzero_tool_exit_is_not_success() { diff --git a/plans/closure/ci-release-orchestration/003k-status.md b/plans/closure/ci-release-orchestration/003k-status.md new file mode 100644 index 0000000..93d1020 --- /dev/null +++ b/plans/closure/ci-release-orchestration/003k-status.md @@ -0,0 +1,85 @@ +# CI Release Orchestration M003k — Closure + +Status: **closed** + +Source plan: `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` + +Roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md` + +Reviewed Eggpack baseline: `559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce` (CI M003j). + +Implementation commits: `c4c4bb8649fac812b0ea5d27411dd89c1951c991` (resolve tags before checkout), `23d9f0347d89fd6ecd916692c145152e39de687f` (require tags to peel to commits), and `fb81aa1400e1f333f6500075f78d944a9242b673` (final qualification record). PR `eggstack/eggpack#1` merged at `1103a1affc62a210f1102a769457db80d9188bc8`. + +Downstream consumer baseline: `dbowm91/wg-basic@bd7c085d191ccf147e0f4dab72fde7cc8818f3fd`. Downstream strict closure: `dbowm91/wg-basic@1e034d089ca62d9f4c22a562a3067227ad8beb9d`, Release Readiness R001. + +Hosted producer CI: [run 38027470046](https://github.com/eggstack/eggpack/actions/runs/38027470046), pull request, attempt 1, exact final implementation head `fb81aa1400e1f333f6500075f78d944a9242b673`, conclusion `success`. All four lanes passed: Linux stable, Linux 1.89.0, macOS, and Windows. + +## Executive finding + +CI M003k is closed. Generated workflows validate and resolve the selected tag to a commit before checking out release source, use the frozen commit for later source checkouts, and verify checked-out `HEAD` before producer or product commands run. The generated GitHub Environment is optional and is limited to the write-authorized `stage` job. The downstream wg-basic consumer repinned M003k, regenerated its checked-in workflow with an exact `eggpack ci check` match, configured its maintainer-controlled stage environment, and closed R001 with exact-head hosted CI and release-contract evidence. + +The live tagged-stage preflight was not exercised because wg-basic had no release tags at closure time. Its strict R001 closure explicitly deferred that operation to the separately gated R004 release. No release was staged, signed, published, or mutated as part of M003k. + +## Requirement-to-evidence matrix + +| Requirement | Evidence | Result | +|---|---|---| +| Validate and resolve the selected tag before any source checkout | M003k implementation commits `c4c4bb8` and `23d9f03`; hosted run `38027470046`; downstream generated-workflow security tests at wg-basic R001 closure | Pass | +| Resolve only an existing tag that peels to a commit, then bind checkouts to that immutable OID | `23d9f0347d89fd6ecd916692c145152e39de687f`; consumer R001 closure at `1e034d0` records tag-object validation for annotated/lightweight tags, changed/non-commit objects, malformed input, and injection rejection | Pass | +| Recheck checkout identity before Eggpack or product release commands | Frozen-SHA checkout and HEAD verification are present in the M003k-generated workflow; consumer exact-head workflow drift check and hosted CI passed | Pass | +| Keep the optional stage environment scoped to the stage job | Producer renderer policy change; downstream R001 records the sole `contents: write` grant on `stage` and the `release-staging` environment with maintainer reviewer `dbowm91` | Pass | +| Preserve compatibility when no environment is configured and keep release semantics unchanged | Producer test suite and four hosted lanes passed; no `ReleaseManifest` or runtime handoff schema change; draft-only staging and no-publication boundary preserved | Pass | +| Qualify downstream release-contract, native candidate, and systemd lifecycle lanes | wg-basic hosted Distribution Foundation run `38108270368` at exact consumer head `1e034d0`; both GNU native candidates and both systemd install-lifecycle lanes passed | Pass | + +## Production implementation evidence + +- The reusable workflow resolves and validates the tag without first checking out the selected source. Later source-consuming jobs check out the resolved OID and verify `HEAD` before invoking Eggpack or product commands. +- The provider policy accepts an optional staging environment name and renders it only on `stage`; Eggpack does not create the environment or choose its reviewers. +- PR `eggstack/eggpack#1` contains the implementation and qualification commits and merged to `main` at `1103a1affc62a210f1102a769457db80d9188bc8`. +- wg-basic pinned the producer, regenerated `.github/workflows/release-eggpack.yml`, and recorded `eggpack ci check: match` at 40,658 bytes. Its strict R001 closure records read-only GitHub settings evidence and the named stage reviewer configuration. +- The public manifest schema, producer/consumer authority boundary, exact-tag draft staging, and separate publication decision did not change. + +## Exact verification executed + +| Command or evidence | Result | +|---|---| +| `scripts/check-local.sh` | Recorded as passing on 2026-10-10 in the M003k implementation plan and final PR qualification commit | +| Hosted Eggpack CI run `38027143275` | Passed at intermediate head `23d9f0347d89fd6ecd916692c145152e39de687f` | +| Hosted Eggpack CI run `38027470046` | Passed on final PR head `fb81aa1400e1f333f6500075f78d944a9242b673` across Linux stable, Linux 1.89.0, macOS, and Windows | +| PR `eggstack/eggpack#1` | Merged at `1103a1affc62a210f1102a769457db80d9188bc8` | +| wg-basic regenerated-workflow `eggpack ci check` | Exact match at 40,658 bytes at the downstream M003k pin | +| wg-basic hosted CI run `38108270370` | Exact-head consumer CI success at `1e034d089ca62d9f4c22a562a3067227ad8beb9d`; 21 checks passed | +| wg-basic hosted Distribution Foundation run `38108270368` | Exact-head release-contract, GNU native-candidate, and systemd install-lifecycle jobs passed | +| wg-basic R001 closure | Closed at `1e034d089ca62d9f4c22a562a3067227ad8beb9d`; [closure record](https://github.com/dbowm91/wg-basic/blob/1e034d089ca62d9f4c22a562a3067227ad8beb9d/plans/closure/release-readiness/001-status.md) | + +The M003k PR has no formal GitHub review object recorded. The merge, exact-head producer CI, downstream generation, repository-policy evidence, and exact-head consumer CI are recorded above; no separate reviewer approval is claimed. + +## Invariant review + +- Dispatch input remains bounded data, not shell source; tag validation precedes source checkout. +- Every source-consuming job uses the resolved immutable commit and checks its checkout identity before release commands. +- The optional environment reference appears only on the stage job. Reviewer identity and GitHub Environment configuration remain consumer-owned. +- Build jobs remain read-only, staging remains draft-only on the exact existing tag, and publication remains a separate human action. +- `ReleasePlan`, `ReleaseManifest`, and Eggup receipts retain their distinct authority; no public schema changed. + +Nothing was weakened to reach the milestone. + +## Failure, recovery, compatibility, and security review + +Missing, malformed, ambiguous, moved, or non-commit refs fail before release work or draft mutation. A checkout mismatch fails before Eggpack or product commands execute. If the configured reviewer gate is not approved, the stage job does not run and cannot mutate a draft. Omitting the environment preserves the old policy form. + +The consumer R001 strict closure records the configured `release-staging` environment and its single maintainer reviewer. The same record states that no live `v*` tag existed, so the live tagged-stage preflight was deferred to R004. That release operation is outside M003k and remains separately gated; M003k does not claim a live stage, signing, or publication. + +## Documentation and operations evidence + +The CI renderer roadmap and registry now link this closure and identify the exact producer merge, final hosted run, and downstream R001 closure. The downstream plan and closure remain in wg-basic; no external repository was edited in this Eggpack closeout. + +## Unresolved findings + +No unresolved Eggpack implementation finding remains for M003k. The live tagged-stage preflight, production signing, and publication were not exercised and remain downstream R004 operations. No independent GitHub review object was recorded; this evidence limitation is stated rather than inferred away. + +## Roadmap disposition and registry updates + +- CI M003k: **closed**. Pre-checkout tag resolution and stage-environment rendering are qualified at the merged producer revision. +- wg-basic Release Readiness R001: **closed** at its own repository baseline with the configured reviewer environment and exact-head CI evidence; the first live tagged-stage preflight remains assigned to R004. +- No additional Eggpack milestone became ready as a result of M003k. The remaining registry entries are blocked or planned, not eligible for implementation. diff --git a/plans/closure/ci-release-orchestration/003pa-status.md b/plans/closure/ci-release-orchestration/003pa-status.md new file mode 100644 index 0000000..f4e9773 --- /dev/null +++ b/plans/closure/ci-release-orchestration/003pa-status.md @@ -0,0 +1,96 @@ +# CI/Release M003pa Closure — Process-Group Signal Recheck + +Status: closed + +Source plan: `plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md` + +Roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md` + +Reviewed baseline: `1cd6d0bf43c93dc9fd572c2d69a3a675a2958b09` — the committed parent immediately before the M003pa implementation. + +Implementation commit: `329a3dfdb166580de4770b2c6b2f046358983003` (`fix: recheck process-group signals after leader exit`), pushed to `feat/auto-20261117-f257539b`. + +Hosted CI for the exact implementation SHA: [run 44118309795](https://github.com/eggstack/eggpack/actions/runs/44118309795), push event, attempt 1, completed successfully. All four required jobs reported success: + +| Lane | Result | Job | +|---|---|---| +| `linux (stable)` | success | [134162378950](https://github.com/eggstack/eggpack/actions/runs/44118309795/job/134162378950) | +| `linux (1.89.0)` | success | [134162379725](https://github.com/eggstack/eggpack/actions/runs/44118309795/job/134162379725) | +| `portability (macos-latest)` | success | [134162379635](https://github.com/eggstack/eggpack/actions/runs/44118309795/job/134162379635) | +| `portability (windows-latest)` | success | [134162379578](https://github.com/eggstack/eggpack/actions/runs/44118309795/job/134162379578) | + +The closure/status update is documentation-only; no production code changed after the implementation run. + +## Executive finding + +M003pa is closed. A failed Unix process-group signal is considered resolved only when the initial error is `ESRCH`, or when an exited/reaped leader is followed by a successful group-signal retry or retry `ESRCH`. A live or unverified leader and every other retry error remain hard failures. This does not infer that the group is empty from leader exit or pipe EOF. + +The implementation and regressions are in `crates/eggpack-core/src/builder.rs`. The retry helper is covered for initial `ESRCH`, a live/unverified leader, retry success, retry `ESRCH`, and a hard retry error. The bounded live-descendant test uses a release-file handshake to prove that a surviving descendant would write a marker; group termination prevents that marker. The real empty-group and output-overflow runner regressions remain covered. + +## Requirement-to-evidence matrix + +| Requirement | Evidence | Result | +|---|---|---| +| Initial `ESRCH` remains benign and does not retry | `a_failed_group_signal_is_benign_only_after_recheck_proves_termination` | pass | +| A live or unverified leader cannot authorize a retry or benign result | Same helper test; wait errors/non-exited status remain hard failures | pass | +| After leader reaping, only retry success or retry `ESRCH` is benign | Same helper test covers success, `ESRCH`, and retry `EPERM` | pass | +| A live descendant is still targeted after the leader exits | `terminating_an_exited_leader_still_signals_a_live_group_descendant`, using the release-file handshake | pass | +| A real already-exited/empty process group remains benign | `terminating_an_already_exited_process_group_is_not_a_failure` | pass | +| Actual output-overflow runner path remains bounded and fails | `stdout_overflow_is_bounded_and_not_success` | pass | +| Windows job-object behavior is unchanged | Unix-only retry handling; hosted Windows lane, including process-group timeout/cancellation and serialized core tests | pass | +| No public API, manifest/schema, dependency, or generated-workflow change | Reviewed implementation diff; only the private core runner/tests and documentation/planning files changed | pass | +| Normative documentation and affected citations match the implementation | `architecture/process-execution.md` and affected architecture citations rechecked by symbol; `eggpack-core` count is 9,109 lines (`builder.rs` 2,078; `digest.rs` 325) | pass | +| Local canonical gate is green | `scripts/check-local.sh`, exit 0; details below | pass | +| Exact candidate is cross-platform qualified | Hosted run `44118309795` on SHA `329a3dfdb166580de4770b2c6b2f046358983003`; all four jobs above | pass | + +## Verification executed + +Focused process-group checks passed: + +```text +cargo test -p eggpack-core --all-targets --all-features --locked group_signal -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked terminating_an_already_exited_process_group_is_not_a_failure -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked terminating_an_exited_leader_still_signals_a_live_group_descendant -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked stdout_overflow_is_bounded_and_not_success -- --nocapture +``` + +The canonical `scripts/check-local.sh` gate passed with exit code 0. It includes formatting, workspace check/lint/tests, documentation, dependency-tree/package checks, and the Rust 1.89 MSRV lane. It ran in the worktree before the implementation commit; the eight unrelated pre-existing edits were present but excluded from commit `329a3df`. Hosted CI then tested the exact committed SHA on all four required lanes. + +## Production implementation evidence + +`group_signal_failure_is_benign` in `crates/eggpack-core/src/builder.rs` now accepts a lazy retry closure. It returns benign immediately only for initial `ESRCH`; otherwise the Unix termination path first calls `try_wait`, and invokes the retry only if the leader is observed exited and reaped. Retry success or `ESRCH` is accepted; any other retry error preserves the hard failure. The non-Unix path retains the existing job-object behavior. + +## Invariant review + +- Process-group termination remains the authority; leader status and pipe state do not inventory descendants. +- A failed signal is never downgraded based solely on leader exit. +- All non-`ESRCH` retry failures remain fail-closed. +- Existing timeout, cancellation, output-limit classification, bounded execution, and output redaction are unchanged. +- M003p's plan and closure are unchanged; M003pa is recorded as a separate corrective. + +## Failure and recovery review + +The original intermittent output-limit failure was not reproduced during the corrective work; the exact original errno/interleaving remains unobserved. A diagnostic had observed `EPERM` while the direct child had exited, but did not establish whether the process group was empty. The corrective addresses that uncertainty conservatively by re-signalling the group after reaping the leader and accepting only success or `ESRCH`. + +A triplicated full-core stress attempt under artificial concurrent load produced native qualification fixture `SmokeTimedOut` failures. The normal canonical gate and the exact-candidate hosted workspace tests passed; this stress-only timeout is not attributed to the M003pa process-group change. No descendant leak or hosted failure remains unresolved. + +## Compatibility and migration review + +No public API, wire format, manifest schema, dependency, workflow, or migration changed. The change is private to Unix process-group termination and its tests; the Windows path is unchanged and passed its hosted lane. Existing external consumers require no action. + +## Security review + +No new privilege, network, credential, publication, or shell surface was introduced. The runner continues to signal the supervised process group, preserve bounded execution/error handling, and avoid returning captured output contents. Retry failure remains fail-closed. + +## Documentation and operations evidence + +The normative process-execution deep dive and affected citations were updated. The overview, CI consumer seam, CLI, validation, and testing/portability references were checked; M003pa status was reconciled in the registry, roadmap, and `AGENTS.md`. The prior M003p history remains intact. + +## Unresolved findings + +- **Informational:** the precise original intermittent errno/interleaving could not be reproduced. No behavior remains unverified for the acceptance criteria: helper outcomes, descendant termination, the real output-overflow path, local gate, and all four hosted lanes passed. +- No blocker or high/medium-severity finding remains. + +## Roadmap disposition and registry updates + +M003pa is closed in the CI/release roadmap and registry, with this record linked from the plan. No implementation milestone is active or registered ready; the next action is plan authoring, not implementation. No dependent or cross-repository work is unlocked by this process-runner correction. M003p's historical plan and closure are unchanged. diff --git a/plans/implementation/build-qualification/007-evidence-digest-unification-corrective.md b/plans/implementation/build-qualification/007-evidence-digest-unification-corrective.md index 8469bd1..cd89e95 100644 --- a/plans/implementation/build-qualification/007-evidence-digest-unification-corrective.md +++ b/plans/implementation/build-qualification/007-evidence-digest-unification-corrective.md @@ -1,6 +1,6 @@ # Build/Qualification M007 — Evidence Digest Unification Corrective -Status: **ready for implementation**. +Status: **closed** — see `plans/closure/build-qualification/007-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/build-qualification-roadmap.md`. diff --git a/plans/implementation/build-qualification/008-compatibility-floor-verification-corrective.md b/plans/implementation/build-qualification/008-compatibility-floor-verification-corrective.md index aadf9b3..4166c72 100644 --- a/plans/implementation/build-qualification/008-compatibility-floor-verification-corrective.md +++ b/plans/implementation/build-qualification/008-compatibility-floor-verification-corrective.md @@ -1,6 +1,6 @@ # Build/Qualification M008 — Compatibility Floor Verification Corrective -Status: **blocked** on Build/Qualification M007. +Status: **closed** — see `plans/closure/build-qualification/008-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/build-qualification-roadmap.md`. diff --git a/plans/implementation/build-qualification/009-local-producer-operator-commands.md b/plans/implementation/build-qualification/009-local-producer-operator-commands.md index a150022..cd86270 100644 --- a/plans/implementation/build-qualification/009-local-producer-operator-commands.md +++ b/plans/implementation/build-qualification/009-local-producer-operator-commands.md @@ -1,6 +1,6 @@ # Build/Qualification M009 — Local Producer Operator Commands -Status: **ready for implementation**. +Status: **closed** — see `plans/closure/build-qualification/009-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/build-qualification-roadmap.md`. diff --git a/plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md b/plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md index f974ca8..9cec2ab 100644 --- a/plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md +++ b/plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md @@ -1,6 +1,6 @@ # CI Release Orchestration M003k — Pre-checkout Tag Resolution and Staging Approval Gate -Status: in progress. Producer baseline: `eggstack/eggpack@559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce` (M003j implementation). Downstream trigger/evidence: `dbowm91/wg-basic@bd7c085d191ccf147e0f4dab72fde7cc8818f3fd`; R001 requires canonical tag validation and immutable commit resolution before any source checkout, plus reviewer-gated staging. +Status: **closed** — strict evidence is recorded at `plans/closure/ci-release-orchestration/003k-status.md`. Producer baseline: `eggstack/eggpack@559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce` (M003j implementation). Downstream trigger/evidence: `dbowm91/wg-basic@bd7c085d191ccf147e0f4dab72fde7cc8818f3fd`; R001 required canonical tag validation and immutable commit resolution before any source checkout, plus reviewer-gated staging. Subsystem roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md`. Canonical authority: ADR-0003; `plans/003-planning-process.md`; CI M003i/M003j closure records. @@ -36,7 +36,7 @@ Invalid tags, missing refs, resolution ambiguity/failure, invalid OIDs, or check ## Verification -Run focused `eggpack-ci` tests; `cargo fmt --all -- --check`; `cargo test --workspace --all-targets --all-features --locked`; `cargo clippy --workspace --all-targets --all-features --locked -- -D warnings`; `scripts/check-local.sh`; and hosted Linux stable/MSRV/macOS/Windows CI. Regenerate wg-basic workflow at the new immutable producer revision and run its release-contract, native candidate, and systemd lifecycle lanes. Do not stage or publish any release. Local `scripts/check-local.sh` passed on 2026-10-10; hosted run `38027143275` passed all four lanes on the current producer head. Independent PR review/merge and downstream evidence are pending. +Run focused `eggpack-ci` tests; `cargo fmt --all -- --check`; `cargo test --workspace --all-targets --all-features --locked`; `cargo clippy --workspace --all-targets --all-features --locked -- -D warnings`; `scripts/check-local.sh`; and hosted Linux stable/MSRV/macOS/Windows CI. Regenerate wg-basic workflow at the new immutable producer revision and run its release-contract, native candidate, and systemd lifecycle lanes. Do not stage or publish any release. The local `scripts/check-local.sh` was recorded as passing on 2026-10-10. Hosted run `38027470046` passed all four lanes at final PR head `fb81aa1400e1f333f6500075f78d944a9242b673`; PR #1 merged at `1103a1affc62a210f1102a769457db80d9188bc8`. The downstream R001 strict closure records exact-head generator, security, CI, and Distribution Foundation evidence. See the closure record for the unexercised live-tag preflight and review-record limitations. ## Acceptance and closure diff --git a/plans/implementation/ci-release-orchestration/003l-producer-rule-authority-convergence-corrective.md b/plans/implementation/ci-release-orchestration/003l-producer-rule-authority-convergence-corrective.md index 143f6c1..b823c82 100644 --- a/plans/implementation/ci-release-orchestration/003l-producer-rule-authority-convergence-corrective.md +++ b/plans/implementation/ci-release-orchestration/003l-producer-rule-authority-convergence-corrective.md @@ -1,6 +1,6 @@ # CI/Release M003l — Producer Rule Authority Convergence Corrective -Status: **blocked** on CI M003k merge, and on ADR-0006 for the digest-validator work package. +Status: **closed** — see `plans/closure/ci-release-orchestration/003l-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md`. diff --git a/plans/implementation/ci-release-orchestration/003m-bounded-process-execution-convergence-corrective.md b/plans/implementation/ci-release-orchestration/003m-bounded-process-execution-convergence-corrective.md index 1221e38..4079890 100644 --- a/plans/implementation/ci-release-orchestration/003m-bounded-process-execution-convergence-corrective.md +++ b/plans/implementation/ci-release-orchestration/003m-bounded-process-execution-convergence-corrective.md @@ -1,6 +1,6 @@ # CI/Release M003m — Bounded Process Execution Convergence Corrective -Status: **blocked** on CI M003l. +Status: **closed** — see `plans/closure/ci-release-orchestration/003m-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md`. diff --git a/plans/implementation/ci-release-orchestration/003n-producer-implementation-consolidation-corrective.md b/plans/implementation/ci-release-orchestration/003n-producer-implementation-consolidation-corrective.md index 1e28b72..341c6b5 100644 --- a/plans/implementation/ci-release-orchestration/003n-producer-implementation-consolidation-corrective.md +++ b/plans/implementation/ci-release-orchestration/003n-producer-implementation-consolidation-corrective.md @@ -1,6 +1,6 @@ # CI/Release M003n — Producer Implementation Consolidation Corrective -Status: **blocked** on CI M003m. +Status: **closed** — see `plans/closure/ci-release-orchestration/003n-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md`. diff --git a/plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md b/plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md new file mode 100644 index 0000000..627ad10 --- /dev/null +++ b/plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md @@ -0,0 +1,139 @@ +# CI/Release Orchestration Milestone 003pa — Process-Group Signal Recheck Corrective + +Status: closed + +Corrects: CI/Release M003p, closed at `27cb16c` with closure `plans/closure/ci-release-orchestration/003p-status.md`. The historical plan and closure remain unchanged. + +Repository authoring baseline: `1cd6d0bf43c93dc9fd572c2d69a3a675a2958b09` + +Primary roadmap: `plans/subsystems/ci-release-orchestration-roadmap.md` + +Normative deep dive: `architecture/process-execution.md` + +Primary class: fail-closed process-group termination + +## 1. Why this milestone exists + +At the reviewed baseline, `terminate_process_group` treats a failed Unix group signal as benign whenever `GroupChild::try_wait` reports that the supervised leader exited (`crates/eggpack-core/src/builder.rs`, `group_signal_failure_is_benign` and `terminate_process_group`). Reaping the leader proves only that the leader exited; it does not prove the process group is empty. A surviving descendant may have closed stdout and stderr, so the drain budget is not proof that no group member remains. + +Apple documents `EPERM` for `killpg` when a group member is not signalable, and no group signal is sent. Therefore, accepting `EPERM` based only on the leader's exit can report termination as complete while a live descendant remains. `ESRCH` remains the kernel's direct indication that the group does not exist. + +The local output-bound regression did not reproduce in 30 repeated runs during research. A prior diagnostic sampled `EPERM` while the direct child had exited; it did not establish that the entire group was empty. The corrective must preserve the macOS zombie-only behavior without broadening the exception to live or unverified group members. + +## 2. Why ready + +- M003p is closed and its behavior is identified precisely; this plan corrects that closed milestone without editing its historical record. +- The defect is localized to the shared `eggpack-core` termination helper and its tests. The shared runner is the authority for builds, qualification, git, and CI consumer validation. +- No schema, public API, dependency, or external-repository change is required. +- The user has requested implementation and verification. The exact acceptance and local verification steps are listed below; hosted cross-platform qualification remains a closure requirement and is not implied by local success. + +## 3. Objective + +1. Keep an initial `ESRCH` benign. +2. For another failed Unix group signal, observe/reap the supervised child. If it is still live or its status is unavailable, keep the failure hard. +3. If the leader has exited, retry the group signal after reaping it. Treat only retry success or retry `ESRCH` as completed termination; any other retry error remains a hard failure. +4. Preserve the Windows job-object behavior and all public outcomes outside this termination distinction. +5. Add deterministic coverage for the retry decision and coverage that a surviving group descendant is still targeted; correct the normative process-execution documentation. + +## 4. Authority and invariants + +The termination rule belongs to `eggpack-core`'s shared bounded runner, not to the CI outcome mapper. The runner must not declare process-group termination complete based solely on the direct child's state. + +Affected invariants: + +- every failure path targets the whole process group/job; +- no live, unverified, or unsignalable group is treated as terminated; +- only `ESRCH`, successful retry, or retry `ESRCH` establish that no further signal failure remains; +- Windows job-object semantics and error classification remain unchanged; +- no public API, serialized format, generated workflow, or dependency changes; +- deterministic behavior and fail-closed error mapping are preserved. + +## 5. Scope + +### In scope + +- Tighten the private Unix group-signal failure/retry decision in `crates/eggpack-core/src/builder.rs`. +- Update the focused helper tests and add a process-group descendant regression if it can be made bounded and leak-safe. +- Update `architecture/process-execution.md` so it no longer claims that an exited leader proves the group is empty or that pipe-drain completion detects every descendant. +- Re-verify architecture citations into `builder.rs` by symbol/content, not by arithmetic; update affected citations. +- Update this plan's active status surfaces in the CI/release roadmap, registry, and `AGENTS.md`. Do not modify M003p's plan or closure. + +### Out of scope + +- Changing CI validator error-to-outcome mapping or generated workflow bytes. +- Changing timeout, cancellation, output-limit policy, process-group creation, or public APIs. +- Suppressing `EPERM` unconditionally, adding privileged test setup, or claiming that a direct-child status proves the whole group is empty. +- Remote workflow dispatch, publication, or changes to unrelated pre-existing worktree files. A commit/push requires explicit user authorization; the later authorization to push the implementation candidate solely for hosted CI is recorded in the closure record. + +## 6. Required work packages + +### WP1 — Fail-closed signal retry + +When the initial group signal fails with `ESRCH`, return success. For any other error, call `try_wait`. If the child is live or the wait status is unavailable, return the existing termination error. If the child exited, retry `GroupChild::kill`; accept retry success or retry `ESRCH`, and preserve the termination error for every other retry failure. + +### WP2 — Regression coverage + +- Deterministically cover initial `ESRCH`, a live/unverified leader, and an exited leader whose retry returns success, `ESRCH`, or `EPERM`. Confirm the retry closure is not called for the initial `ESRCH` or a live/unverified leader. +- Retain the real empty-group test. +- Add or strengthen a bounded process-group test demonstrating that a live descendant is still targeted after the leader exits. Do not rely on changing UID or other privileged setup; model an unsignalable retry with deterministic injected outcomes. +- Keep the output-overflow test as end-to-end coverage of the actual runner path. + +### WP3 — Normative documentation and citations + +Correct the process-execution deep dive's rule and descendant/drain claims, record the retry semantics and Windows boundary, and re-verify affected `builder.rs` citations by their named constructs. Preserve the M003p plan and closure as historical evidence. + +### WP4 — Verification and closure evidence + +Run the exact targeted commands and the canonical local gate below. Record results, including any platform or hosted-CI gaps, in a new `plans/closure/ci-release-orchestration/003pa-status.md` only when closure evidence is available. Do not mark this milestone closed based solely on compilation or local tests; hosted macOS, Linux stable/MSRV, and Windows lanes are required before closure. + +## 7. Failure, restart, and compatibility + +A retry error other than `ESRCH` is never downgraded because the supervised leader exited. The original termination error remains the public failure classification; captured process output remains unavailable to callers. If a test fails or a group cannot be proven terminated, stop and retain fail-closed behavior. The patch adds no migration requirement or compatibility change. + +The working tree contains unrelated pre-existing edits in `Cargo.lock`, `architecture/ci.md`, `architecture/github.md`, `architecture/overview.md`, `crates/eggpack-ci/Cargo.toml`, `crates/eggpack-ci/src/tests.rs`, `crates/eggpack-github/Cargo.toml`, and `crates/eggpack-github/src/lib.rs`; leave them intact and out of scope. + +## 8. Tests and exact verification commands + +Focused tests: + +```bash +cargo test -p eggpack-core --all-targets --all-features --locked group_signal -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked terminating_an_already_exited_process_group_is_not_a_failure -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked terminating_an_exited_leader_still_signals_a_live_group_descendant -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked stdout_overflow_is_bounded_and_not_success -- --nocapture +cargo test -p eggpack-core --all-targets --all-features --locked parked_drain_reader_cannot_outlive_the_deadline -- --nocapture +``` + +Local checks: + +```bash +cargo fmt --all -- --check +cargo check --workspace --all-targets --locked +cargo clippy --workspace --all-targets --all-features --locked -- -D warnings +cargo test --workspace --all-targets --all-features --locked +scripts/check-local.sh +``` + +`scripts/check-local.sh` is the canonical gate and includes packaging and the Rust 1.89 MSRV lane. Hosted CI on the exact candidate remains required for closure. A later explicit user instruction authorized committing and pushing the implementation candidate solely to run CI; no remote workflow dispatch or publication occurred. + +## 9. Acceptance criteria + +| Criterion | Evidence | +|---|---| +| Zombie-only macOS failure remains tolerated without assuming the group is empty | deterministic initial-`EPERM`, exited-leader, retry-`ESRCH` coverage and end-to-end output-bound test | +| Live/unverified group cannot be accepted from leader exit alone | deterministic retry-`EPERM` failure and live/unverified-leader failure coverage | +| A live descendant is still targeted after leader exit | bounded process-group regression, with no leaked descendant | +| Empty group remains benign | real empty-group regression passes | +| Windows behavior is unchanged | cfg review and hosted Windows lane | +| API, manifest, and generated workflow bytes are unchanged | diff review and existing workspace tests | +| Normative text and citations match the implementation | source-anchor review of affected `architecture/` citations | +| Local gate is green | exact `scripts/check-local.sh` result | +| Candidate is cross-platform qualified before closure | hosted run on the exact candidate SHA, all four lanes green | + +## 10. Stop conditions + +Stop and keep the milestone active if the retry returns any non-`ESRCH` error, if a live or unverified group is accepted, if any descendant test leaks a process, if the Windows path changes, if the local gate fails, if architecture citations are not verified, or if hosted CI for the exact candidate is unavailable or red. Do not dispatch or publish. Commit/push requires explicit user authorization; the authorized follow-up push used for CI is documented in the closure record. + +## 11. Closure evidence + +Closure record: `plans/closure/ci-release-orchestration/003pa-status.md`. M003pa is closed on implementation commit `329a3dfdb166580de4770b2c6b2f046358983003` after `scripts/check-local.sh` returned 0 and hosted run `44118309795` passed all four lanes on that exact SHA. The record distinguishes implementation evidence, local verification, hosted results, and the remaining informational observation. The prior M003p plan and closure remain unchanged. \ No newline at end of file diff --git a/plans/implementation/ecosystem-adoption/003b-eggsearch-seven-target-eggpack-producer-cutover.md b/plans/implementation/ecosystem-adoption/003b-eggsearch-seven-target-eggpack-producer-cutover.md index 650958a..53962dc 100644 --- a/plans/implementation/ecosystem-adoption/003b-eggsearch-seven-target-eggpack-producer-cutover.md +++ b/plans/implementation/ecosystem-adoption/003b-eggsearch-seven-target-eggpack-producer-cutover.md @@ -1,6 +1,6 @@ # Ecosystem Adoption Milestone 003b — Eggsearch Seven-Target Eggpack Producer Cutover -Status: ready +Status: **closed** — see `plans/closure/ecosystem-adoption/003b-status.md`. Class: capability / cross-repository adoption / operational qualification diff --git a/plans/implementation/planning-hygiene/002-post-m003a-cross-repository-handoff-reconciliation.md b/plans/implementation/planning-hygiene/002-post-m003a-cross-repository-handoff-reconciliation.md index acf1ff5..a9ccf46 100644 --- a/plans/implementation/planning-hygiene/002-post-m003a-cross-repository-handoff-reconciliation.md +++ b/plans/implementation/planning-hygiene/002-post-m003a-cross-repository-handoff-reconciliation.md @@ -1,6 +1,6 @@ # Planning Hygiene M002 — Post-M003a Cross-Repository Handoff Reconciliation -Status: ready +Status: **closed** — see `plans/closure/planning-hygiene/002-status.md`. Class: planning / closure hygiene / cross-repository handoff reconciliation diff --git a/plans/implementation/planning-hygiene/003-post-implementation-review-baseline-reconciliation.md b/plans/implementation/planning-hygiene/003-post-implementation-review-baseline-reconciliation.md index ced8e51..227752e 100644 --- a/plans/implementation/planning-hygiene/003-post-implementation-review-baseline-reconciliation.md +++ b/plans/implementation/planning-hygiene/003-post-implementation-review-baseline-reconciliation.md @@ -1,6 +1,6 @@ # Planning Hygiene M003 — Post-Implementation Review Baseline Reconciliation -Status: **ready for implementation**. +Status: **closed** — see `plans/closure/planning-hygiene/003-status.md`. Repository baseline: `eggstack/eggpack@fb81aa1400e1f333f6500075f78d944a9242b673` (2026-10-23). Source roadmap: `plans/subsystems/planning-hygiene-roadmap.md`. diff --git a/plans/registry.md b/plans/registry.md index b203086..3cf73a7 100644 --- a/plans/registry.md +++ b/plans/registry.md @@ -88,29 +88,29 @@ Distribution predecessor evidence: - **Downstream handoff:** wg-basic Distribution M003 may resume against immutable producer SHA `3ddac9d84fc2e10b8451d38672f66b02e06724df`. Its own implementation, native qualification, and closure remain consumer-owned and were not changed in Eggpack. - **Execution order:** M002b implementation → M002b strict four-platform closure → M003i implementation → M003i strict closure (complete) → separate wg-basic M003 handoff. These additions supersede historical 'no ready' snapshots below; earlier closure records remain unchanged. -## Active subsystem roadmaps +## Subsystem roadmap status | Subsystem | Status | Roadmap | Current milestone | Dependencies / blockers | |---|---|---|---|---| | Contract and conformance | **complete** | `plans/subsystems/contract-conformance-roadmap.md` | M001-M003 closed | M003 closed on `43fa2d7`; closure `plans/closure/contract-conformance/003-status.md`: additive local `eggpack contract expand` scalar projection over existing schema-v1 semantics, 18 new tests including a process-boundary stdout contract, parity proven against eggsact `d4e6e5c` and stegoeggo `v0.5.0` for every target/alias/field. Roadmap §11 completion definition fully met; no contract milestone remains registered | | External backend evaluation | closed | `plans/subsystems/external-backend-evaluation-roadmap.md` | M001 closed (C) | no production backend adopted; new evidence/plan required to reopen | -| Release manifest | active | `plans/subsystems/release-manifest-roadmap.md` | M002/M003 closed; M003a closed; **M004 closed** | M004 published the ADR-0006 `eggpack-manifest 0.1.1` patch release and wrote the compatibility record ADR-0006 §5.4 requires: crates.io, checksum `352c3e327159615b763298e911e239f1decc4a2c9e28c28be8ddd28e50515e37`, not yanked, from publication source commit `4ce4fb850ffa0e141f1a807b60c150173507a92b`, tagged `eggpack-manifest-v0.1.1`; hosted run `40263953007` green on all four lanes. Both narrowings of the published acceptance set — the ADR-0006 digest rule and the `3ef806f` document bound — are recorded as compatibility events. `0.1.0` remains published and resolvable. `eggup-eggpack` pins `=0.1.0` and is the named affected consumer; its bump is consumer-owned. M003 and M003a remain closed and no runtime/package requalification was performed or implied | -| Build and qualification | active | `plans/subsystems/build-qualification-roadmap.md` | M001-M009 closed | M009 closed on `eb77d19` + `8950eb9`: six of the nine operator commands the canonical specification names now exist (`check`, `plan`, `package`, `qualify`, `collect`, `manifest`). The new commands and the `ci _*` runners call the same core functions and the same serialization helpers, and the byte-identity between them is proven by test; `eggpack-core` needed no change, which is the strongest evidence that the new surface is thin wiring rather than a second pipeline. M008 closed on `7e7cb6a`: a declared compatibility floor is no longer silently dropped — every target declaring one carries a finite, closed floor verification status on both the `ReleasePlan` and the `QualificationEvidence`, computed by bounded independent ELF `GLIBC_x.y` inspection. M007 closed on `e3c6192`: one canonical bounded file-digest authority in `eggpack-core`, retiring core's three divergent digest implementations | -| Bootstrap installers | active; corrective closed | `plans/subsystems/bootstrap-installers-roadmap.md` | M002b closed; M003a closed; prior milestones closed | M002b implementation `88ddf2e`, hosted run `37806244313`; POSIX runtime remains on Unix and Windows PowerShell archive runtime passed. M003 completion definition remains satisfied. M003a closed on the ADR-0006 digest-fixture correction: five bootstrap fixtures used the all-zeros digest as a "wrong digest" placeholder, and CI M003l's tightened acceptance rule made that value illegal at manifest validation, so three tests aborted at setup and the installers' digest-mismatch coverage was silently not running | -| CI/release orchestration | active; M003j-M003n closed | `plans/subsystems/ci-release-orchestration-roadmap.md` | M003n producer implementation consolidation (closed) | M003n closed at `plans/closure/ci-release-orchestration/003n-status.md`: one drift comparison replaces three byte-identical copies, one staging-payload builder replaces two copies that were 85.5% identical, the 845-line `render_release_github_inner` is decomposed, and the CI crate's single 12,221-line source file became a 14-file module tree with a byte-identical public API and byte-identical rendered output. M003m closed on `bd73f5c` (cherry-picked `6a7cb4c`): the CI crate's consumer-validator execution now routes through the workspace's single bounded runner, which terminates the whole process group and bounds its reader-thread joins; the CI-local runner, its bounded readers, and its unbounded drain are deleted, and the CI production region contains no process-spawning code at all. M003l closed on `9cf0bf8` under accepted ADR-0006 (Option A): one SHA-256 hex acceptance rule, one host/target match rule, one floor-applicability rule, one exact-tag safety rule, and one file-digest authority | -| Eggup interoperability | active | `plans/subsystems/eggup-interoperability-roadmap.md` | Eggpack M001a + Eggup adapter M001/M001a + Eggup M003 real-consumer adoption + Eggup M004 registry promotion all closed | The whole producer/consumer package seam is closed end to end; Release Manifest M003a closed the remaining Eggpack-side planning drift, and no Eggpack work remains on this seam; Eggwork Operations M003 remains producer-only | -| Ecosystem adoption | active | `plans/subsystems/ecosystem-adoption-roadmap.md` | M001/M002/M003a/M003b closed | Closure `plans/closure/ecosystem-adoption/003b-status.md`. Paired plans: Eggpack `plans/implementation/ecosystem-adoption/003b-eggsearch-seven-target-eggpack-producer-cutover.md` (`325d44e`); Eggsearch `plans/implementation/eggpack-release-adoption/001-seven-target-eggpack-producer-cutover.md` (`377f9e8`, registry `6767062`). Implementation landed at `eggstack/eggsearch@eabbf80`; hosted run `37531104901` staged eggsearch `v0.4.2` as draft `405157598` with the exact 19-asset inventory, glibc 2.17 re-proven on all three GNU targets, ARMv7 required consumer validator green, Windows ARM64 required and green, and zero OIDC permission in generated jobs. Provenance attested the staged bytes in run `37561960304`; the draft was published 2026-10-07, closing the named condition | -| Planning hygiene | active | `plans/subsystems/planning-hygiene-roadmap.md` | M001-M003 closed | M003 closed at `plans/closure/planning-hygiene/003-status.md`: docs/evidence-only post-implementation-review baseline reconciliation — the `architecture/` citation set and line counts were re-based by symbol name against a measured tree SHA, the `ci-consumer-seam.md` and residual `cli.md` drift were closed, the `AGENTS.md` handoff was rewritten from the registry, the CLI command reference was verified, and the review chain was registered; empty production/package/workflow diff. M002 closed at `plans/closure/planning-hygiene/002-status.md`: docs/evidence-only post-M003a handoff reconciliation with an empty production/package/workflow diff; stale/duplicated control-surface text removed and the handoff bound to exact paired-plan paths | +| Release manifest | complete | `plans/subsystems/release-manifest-roadmap.md` | M001-M004 closed | M004 published the ADR-0006 `eggpack-manifest 0.1.1` patch release and wrote the compatibility record ADR-0006 §5.4 requires: crates.io, checksum `352c3e327159615b763298e911e239f1decc4a2c9e28c28be8ddd28e50515e37`, not yanked, from publication source commit `4ce4fb850ffa0e141f1a807b60c150173507a92b`, tagged `eggpack-manifest-v0.1.1`; hosted run `40263953007` green on all four lanes. Both narrowings of the published acceptance set — the ADR-0006 digest rule and the `3ef806f` document bound — are recorded as compatibility events. `0.1.0` remains published and resolvable. `eggup-eggpack` pins `=0.1.0` and is the named affected consumer; its bump is consumer-owned. M003 and M003a remain closed and no runtime/package requalification was performed or implied | +| Build and qualification | complete | `plans/subsystems/build-qualification-roadmap.md` | M001-M009a closed | M009 closed on `eb77d19` + `8950eb9`: six of the nine operator commands the canonical specification names now exist (`check`, `plan`, `package`, `qualify`, `collect`, `manifest`). The new commands and the `ci _*` runners call the same core functions and the same serialization helpers, and the byte-identity between them is proven by test; `eggpack-core` needed no change, which is the strongest evidence that the new surface is thin wiring rather than a second pipeline. M008 closed on `7e7cb6a`: a declared compatibility floor is no longer silently dropped — every target declaring one carries a finite, closed floor verification status on both the `ReleasePlan` and the `QualificationEvidence`, computed by bounded independent ELF `GLIBC_x.y` inspection. M007 closed on `e3c6192`: one canonical bounded file-digest authority in `eggpack-core`, retiring core's three divergent digest implementations | +| Bootstrap installers | complete | `plans/subsystems/bootstrap-installers-roadmap.md` | all Eggpack milestones closed | M002b implementation `88ddf2e`, hosted run `37806244313`; POSIX runtime remains on Unix and Windows PowerShell archive runtime passed. M003 completion definition remains satisfied. M003a closed on the ADR-0006 digest-fixture correction: five bootstrap fixtures used the all-zeros digest as a "wrong digest" placeholder, and CI M003l's tightened acceptance rule made that value illegal at manifest validation, so three tests aborted at setup and the installers' digest-mismatch coverage was silently not running | +| CI/release orchestration | complete | `plans/subsystems/ci-release-orchestration-roadmap.md` | M003pa closed; no milestone ready | M003k is closed at `plans/closure/ci-release-orchestration/003k-status.md`; M003p is closed at `plans/closure/ci-release-orchestration/003p-status.md`. M003pa is closed at `plans/closure/ci-release-orchestration/003pa-status.md` (implementation `329a3dfdb166580de4770b2c6b2f046358983003`; hosted run `44118309795` passed all four lanes on that exact SHA), correcting M003p by re-signalling after leader reaping and accepting only retry success or `ESRCH`. M003n is closed at `plans/closure/ci-release-orchestration/003n-status.md`: one drift comparison replaces three byte-identical copies, one staging-payload builder replaces two copies that were 85.5% identical, the 845-line `render_release_github_inner` is decomposed, and the CI crate's single 12,221-line source file became a 14-file module tree with a byte-identical public API and byte-identical rendered output. M003m closed on `bd73f5c` (cherry-picked `6a7cb4c`): the CI crate's consumer-validator execution now routes through the workspace's single bounded runner, which terminates the whole process group and bounds its reader-thread joins; the CI-local runner, its bounded readers, and its unbounded drain are deleted, and the CI production region contains no process-spawning code at all. M003l closed on `9cf0bf8` under accepted ADR-0006 (Option A): one SHA-256 hex acceptance rule, one host/target match rule, one floor-applicability rule, one exact-tag safety rule, and one file-digest authority | +| Eggup interoperability | complete | `plans/subsystems/eggup-interoperability-roadmap.md` | Eggpack M001a + Eggup adapter M001/M001a + Eggup M003 real-consumer adoption + Eggup M004 registry promotion all closed | The whole producer/consumer package seam is closed end to end; Release Manifest M003a closed the remaining Eggpack-side planning drift, and no Eggpack work remains on this seam; Eggwork Operations M003 remains producer-only | +| Ecosystem adoption | blocked | `plans/subsystems/ecosystem-adoption-roadmap.md` | M001/M002/M003a/M003b closed; M004-M006 blocked | Closure `plans/closure/ecosystem-adoption/003b-status.md`. Paired plans: Eggpack `plans/implementation/ecosystem-adoption/003b-eggsearch-seven-target-eggpack-producer-cutover.md` (`325d44e`); Eggsearch `plans/implementation/eggpack-release-adoption/001-seven-target-eggpack-producer-cutover.md` (`377f9e8`, registry `6767062`). Implementation landed at `eggstack/eggsearch@eabbf80`; hosted run `37531104901` staged eggsearch `v0.4.2` as draft `405157598` with the exact 19-asset inventory, glibc 2.17 re-proven on all three GNU targets, ARMv7 required consumer validator green, Windows ARM64 required and green, and zero OIDC permission in generated jobs. Provenance attested the staged bytes in run `37561960304`; the draft was published 2026-10-07, closing the named condition | +| Planning hygiene | complete | `plans/subsystems/planning-hygiene-roadmap.md` | M001-M003 closed | M003 closed at `plans/closure/planning-hygiene/003-status.md`: docs/evidence-only post-implementation-review baseline reconciliation — the `architecture/` citation set and line counts were re-based by symbol name against a measured tree SHA, the `ci-consumer-seam.md` and residual `cli.md` drift were closed, the `AGENTS.md` handoff was rewritten from the registry, the CLI command reference was verified, and the review chain was registered; empty production/package/workflow diff. M002 closed at `plans/closure/planning-hygiene/002-status.md`: docs/evidence-only post-M003a handoff reconciliation with an empty production/package/workflow diff; stale/duplicated control-surface text removed and the handoff bound to exact paired-plan paths | **Cross-repo M003 mapping:** Eggpack interoperability M003 is the producer/interface view of Eggup's `plans/implementation/eggpack-manifest-interoperability/003-eggsact-real-consumer-manifest-adoption.md`, and that consumer milestone is now closed (`eggstack/eggup@538e3e5`, `eggstack/eggsact@65c916b`, hosted CI `36902758482` + drift `36902758396`). Ecosystem M001 / Eggsact M005 established the live producer contract and published `release-manifest.json`; runtime manifest acquisition/projection and update semantics remain Eggup/Eggsact-owned. Eggup M004a moved the active producer prerequisite to Release Manifest M003: publish the already-qualified leaf crate `eggpack-manifest 0.1.0` under `plans/implementation/release-manifest/003-eggpack-manifest-0.1.0-publication-and-compatibility-baseline.md`. That publication is now closed: `eggpack-manifest 0.1.0` is live on crates.io, and the published `src/lib.rs` is byte-identical to the consumer-qualified pin `678bbf04`, so the Eggpack-owned prerequisite Eggup M004a identified is satisfied. That Eggup-owned chain has also completed: Eggup M004 published `eggup-acquisition 0.1.2` -> `eggup-eggfetch 0.1.2` -> `eggup-eggpack 0.1.2` in dependency order from publication source `eggstack/eggup@02a1d32931be29cc3d8980833643b2cd822f2d28` (hosted run `37090397398` green on Stable, MSRV, macOS, and Windows) and closed at `eggstack/eggup@ea1f1c5e29302e5feca4599db9342d3a5ac93915`, with Eggup's own stale blocked-state prose formally reconciled at `eggstack/eggup@3b82d5397e728649a666690868a1e2d0fe42460d`. The producer/consumer registry seam is therefore closed end to end, and Release Manifest M003a closed the remaining Eggpack-side planning drift against that downstream truth. No Eggpack implementation work is unlocked by it; the next downstream action is Eggsact's own Git-to-registry migration, owned and authorized in `eggstack/eggsact`. -## Dependency-ready implementation work +## Milestone status and closure index -Planning Hygiene M002, Ecosystem M003b, Bootstrap M002b, CI M003i, and CI M003j are closed. **CI M003k is closed** (`plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md`; PR `eggstack/eggpack#1` merged to `main` at `1103a1a`, followed by `eggstack/eggpack#2` at `a0fec98`; implementation `fb81aa1`), so it resolves the downstream wg-basic R001 pre-checkout and stage-environment gates while preserving M003j's safe dispatch handling. **Release Manifest M004 is closed** (`plans/implementation/release-manifest/004-eggpack-manifest-0.1.1-publication-and-compatibility-event.md`): ADR-0006's `eggpack-manifest 0.1.1` patch release is published and its compatibility event recorded, discharging the last obligation the 2026-10-23 review chain left outstanding. +Planning Hygiene M002/M003, Ecosystem M003b, Bootstrap M002b, CI M003i–M003k, and Release Manifest M004 are closed. **CI M003k** is recorded at `plans/closure/ci-release-orchestration/003k-status.md`: PR `eggstack/eggpack#1` merged at `1103a1affc62a210f1102a769457db80d9188bc8`; final implementation head `fb81aa1400e1f333f6500075f78d944a9242b673` passed hosted run `38027470046`; wg-basic R001 closed at `dbowm91/wg-basic@1e034d089ca62d9f4c22a562a3067227ad8beb9d` with exact-head runs `38108270370` and `38108270368`. The live tagged-stage preflight remains deferred to wg-basic R004. **Release Manifest M004** published `eggpack-manifest 0.1.1` and recorded both compatibility events, discharging the final ADR-0006 obligation. The post-implementation review of 2026-10-23 registered a corrective chain. **Build/Qualification M007 is closed** (`e3c6192`): `eggpack-core` now has one canonical bounded file-digest authority. **ADR-0006 is accepted (Option A)**: the all-zeros SHA-256 sentinel is refused everywhere, `ReleaseManifest` stays at `schema_version: 1`, and the published `eggpack-manifest` crate takes a `0.1.1` patch release carrying the tightened rule. **CI M003l is closed** (`9cf0bf8`): the duplicate host-match, floor-applicability, exact-tag, SHA-256 acceptance, and file-digest rules are gone, and the two exact-tag rule sets — disjoint in both directions — are replaced by their union. **Build/Qualification M008 is closed** (`7e7cb6a`): a declared compatibility floor is no longer silently dropped, and every target declaring one carries a finite, closed floor verification status computed by bounded independent ELF inspection. **Build/Qualification M009 is closed** (`eb77d19` + `8950eb9`): six of the nine operator commands the canonical specification names now exist, sharing one implementation with the `ci _*` runners. **CI M003m is closed** (`bd73f5c`): the CI crate's consumer-validator execution routes through the workspace's single bounded process-group runner, and its production region now contains no process-spawning code at all. **CI M003n is closed** (`bf0acfe` + `028db4a`): one drift comparison replaces three byte-identical copies, one staging-payload builder replaces two copies that were 85.5% identical, the 845-line `render_release_github_inner` is decomposed, and the CI crate's single source file became a 14-file module tree with byte-identical output. **Planning Hygiene M003** (docs-only) is closed as well. **Bootstrap M003a** (the ADR-0006 adversarial digest fixture corrective, closure `plans/closure/bootstrap-installers/003a-status.md`) is closed too: five bootstrap fixtures used the all-zeros digest as a stand-in, and the corrective replaced them with a real digest that must be refused. The whole 2026-10-23 review chain is closed. -**A follow-up review of the chain's own output found defects in the newly written code and registered a second corrective chain.** **Build/Qualification M007a is closed** (`c17bdbe`): the canonical digest helper refuses a read that produced zero bytes, so a zero-length digest record cannot exist. **Build/Qualification M008a is closed** (`c17bdbe`): the floor reader no longer abandons its scan at the first non-numeric `GLIBC_` name — which was masking a **contradicted** floor as an admissible `Unverified` status — and its virtual-address translation can no longer overflow. **Build/Qualification M009a is closed** (`d2fbd07`): the operator family no longer destroys its own input candidates when `--output-dir` equals `--artifacts-dir`, is equivalent to the CI path in emulated qualification, identity mode, consumer-validator support, and input encoding, and derives a self-checking manifest. **CI M003o is closed** (`b205de6`): the workflow renderer refuses an over-long generated directory instead of panicking on a legal 128-character contract target, and two digest diagnostics name the reason they refused. **CI M003p is closed** (`27cb16c`): the chain's first hosted CI run failed on macOS, where the shared bounded runner refuses to signal a process group holding the unreaped zombie of an exited child and reports the whole signal as `EPERM`; the runner now decides by observing whether the supervised child has exited, and hosted run `40263176191` is green on all four lanes. Both review chains are closed. The obligation ADR-0006 created for the published crate — the `eggpack-manifest 0.1.1` patch release and the compatibility record ADR-0006 §5.4 requires — was tracked by Release Manifest M004, which is now **closed**: `0.1.1` is published, and both narrowings the package carries are recorded as compatibility events. +**A follow-up review of the chain's own output found defects in the newly written code and registered a second corrective chain.** **Build/Qualification M007a is closed** (`c17bdbe`): the canonical digest helper refuses a read that produced zero bytes, so a zero-length digest record cannot exist. **Build/Qualification M008a is closed** (`c17bdbe`): the floor reader no longer abandons its scan at the first non-numeric `GLIBC_` name — which was masking a **contradicted** floor as an admissible `Unverified` status — and its virtual-address translation can no longer overflow. **Build/Qualification M009a is closed** (`d2fbd07`): the operator family no longer destroys its own input candidates when `--output-dir` equals `--artifacts-dir`, is equivalent to the CI path in emulated qualification, identity mode, consumer-validator support, and input encoding, and derives a self-checking manifest. **CI M003o is closed** (`b205de6`): the workflow renderer refuses an over-long generated directory instead of panicking on a legal 128-character contract target, and two digest diagnostics name the reason they refused. **CI M003p is closed** (`27cb16c`): the chain's first hosted CI run failed on macOS, where the shared bounded runner refuses to signal a process group holding the unreaped zombie of an exited child and reports the whole signal as `EPERM`; the runner now decides by observing whether the supervised child has exited, and hosted run `40263176191` is green on all four lanes. Both review chains are closed. The later M003pa corrective preserves M003p's history and closes the exited-leader inference: after reaping, only a successful retry or retry `ESRCH` is benign; hosted run `44118309795` passed all four lanes on implementation `329a3dfdb166580de4770b2c6b2f046358983003`. Its closure is recorded at `plans/closure/ci-release-orchestration/003pa-status.md`. The obligation ADR-0006 created for the published crate — the `eggpack-manifest 0.1.1` patch release and the compatibility record ADR-0006 §5.4 requires — was tracked by Release Manifest M004, which is now **closed**: `0.1.1` is published, and both narrowings the package carries are recorded as compatibility events. The two subsystems that were closed before this chain keep their closure records here so the index is complete rather than partial: **Contract and conformance M001** closed at `plans/closure/contract-conformance/001-status.md` (the @@ -119,14 +119,14 @@ closed at `plans/closure/external-backend-evaluation/001-status.md` (disposition C — design prior art with selected output normalization; no production backend was adopted). -The table below is the **milestone-to-closure index plus active ready work**, not an implication that every historical row is executable. +The table below is the **milestone-to-closure index**; it does not imply that every historical row is executable. No implementation plan is currently registered ready or active. | Subsystem | Milestone | Status | Plan | Dependencies | |---|---|---|---|---| | Bootstrap installers | M002b Windows POSIX archive-test portability | **closed** | `plans/implementation/bootstrap-installers/002b-windows-posix-archive-test-portability-corrective.md` | Closure `plans/closure/bootstrap-installers/002b-status.md`; implementation `88ddf2e`; hosted run `37806244313` all lanes green | | CI orchestration | M003i exact tag versus manifest release ID policy | **closed** | `plans/implementation/ci-release-orchestration/003i-explicit-tag-and-manifest-release-identity-corrective.md` | Closure `plans/closure/ci-release-orchestration/003i-status.md`; implementation `3ddac9d84fc2e10b8451d38672f66b02e06724df`; hosted run `37813044035` all four lanes green. wg-basic M003 may resume with this pin | | CI orchestration | M003j dispatch-tag Bash interpolation corrective | closed | `plans/implementation/ci-release-orchestration/003j-dispatch-tag-shell-injection-corrective.md` | Closure `plans/closure/ci-release-orchestration/003j-status.md`; implementation `559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce`; hosted run `37987890305` all four lanes green | -| CI orchestration | M003k pre-checkout tag resolution and stage approval gate | closed | `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` | PR `eggstack/eggpack#1` merged to `main` at `1103a1a` (followed by `eggstack/eggpack#2` at `a0fec98`); implementation `fb81aa1`; local gate and hosted run `38027143275` passed | +| CI orchestration | M003k pre-checkout tag resolution and stage approval gate | closed | `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` | closure `plans/closure/ci-release-orchestration/003k-status.md`; PR `eggstack/eggpack#1` merged at `1103a1affc62a210f1102a769457db80d9188bc8`; final implementation head `fb81aa1400e1f333f6500075f78d944a9242b673`, hosted run `38027470046` passed all four lanes; downstream wg-basic R001 closed at `1e034d089ca62d9f4c22a562a3067227ad8beb9d` with runs `38108270370` and `38108270368` | | CI orchestration | M003l producer rule authority convergence corrective | **closed** | `plans/implementation/ci-release-orchestration/003l-producer-rule-authority-convergence-corrective.md` | Closure `plans/closure/ci-release-orchestration/003l-status.md`; implementation `9cf0bf8`; accepted ADR-0006 Option A implemented. The duplicate host-match, floor-applicability, exact-tag, SHA-256 acceptance, and file-digest rules are gone; the two exact-tag rule sets were disjoint in both directions and their union is canonical | | Planning hygiene | M001 current evidence baseline + blocker reconciliation | closed | `plans/implementation/planning-hygiene/001-current-evidence-baseline-and-blocker-reconciliation.md` | Closure `plans/closure/planning-hygiene/001-status.md`; discharged CI M003b (eggsact `685fa373` + run `36886042696`) and closed Ecosystem M002 on stegoeggo `v0.5.0` (run `37181914252`); docs-only, zero production/package/workflow delta | | Planning hygiene | M002 post-M003a cross-repository handoff reconciliation | closed | `plans/implementation/planning-hygiene/002-post-m003a-cross-repository-handoff-reconciliation.md` | Closure `plans/closure/planning-hygiene/002-status.md`; docs/evidence-only; stale M003/M003a/M003b control-surface text reconciled against exact paired-plan paths; empty production/package/workflow diff | @@ -155,6 +155,7 @@ The table below is the **milestone-to-closure index plus active ready work**, no | Build and qualification | M009a local producer operator defects corrective | **closed** | `plans/implementation/build-qualification/009a-local-producer-operator-defects.md` | Closure `plans/closure/build-qualification/009a-status.md`; implementation `d2fbd07`. The operator family no longer destroys its own input candidates when `--output-dir` equals `--artifacts-dir`; it is equivalent to the CI path in emulated qualification (`--qemu-sysroot`), identity mode (`--identity-mode`), consumer-validator support (`--consumer-validators`), and input encoding (TOML or JSON); and `manifest` is self-checking — it reads archive members back out of the finalized archive and compares against the collected manifest, failing closed instead of reporting `manifest: ok` | | CI orchestration | M003o renderer panic and digest diagnostics corrective | **closed** | `plans/implementation/ci-release-orchestration/003o-renderer-panic-and-digest-diagnostics.md` | Closure `plans/closure/ci-release-orchestration/003o-status.md`; implementation `b205de6`. The workflow renderer's generated-directory check was an assertion that a legal 128-character contract target could trip — it is now a refusal. Two digest diagnostics named a formatting problem where ADR-0006 refuses the well-formed all-zeros digest; they now name the actual reason. The CI crate's 85 public items and every rendered byte are unchanged | | CI orchestration | M003p process-group termination of an already-exited group corrective | **closed** | `plans/implementation/ci-release-orchestration/003p-process-group-termination-of-an-already-exited-group.md` | Closure `plans/closure/ci-release-orchestration/003p-status.md`; implementation `27cb16c`; hosted run `40263176191` green on all four lanes after four failing runs. The first hosted CI run of the 2026-10-23 review chain (`40207520563`) failed on macOS: two CI-crate tests reported `Failed(InterpreterUnavailable)` where they expected `Failed(OutputLimit)`. macOS refuses to signal a process group that holds the unreaped zombie of an exited child and reports the whole signal as `EPERM`; Linux signals it successfully, so the local gate and the Linux lanes never saw it. The runner now decides by observing whether the supervised child has exited rather than by reading the errno: a failed signal is benign when there is nothing left to terminate, and a group holding a live process that cannot be signalled still fails the run closed | +| CI orchestration | M003pa process-group signal recheck corrective | **closed** | `plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md` | Closure `plans/closure/ci-release-orchestration/003pa-status.md`; implementation `329a3dfdb166580de4770b2c6b2f046358983003`; hosted run `44118309795` passed all four lanes on that exact SHA. After leader reaping, only retry success or `ESRCH` is benign; all other retry errors remain fail-closed | | Bootstrap installers | M001 generator/direct fixtures | closed | `plans/implementation/bootstrap-installers/001-direct-installer-generator.md` | Closure `plans/closure/bootstrap-installers/001-status.md` | | CI orchestration | M001 CIPlan/GitHub renderer | closed | `plans/implementation/ci-release-orchestration/001-ci-plan-and-github-renderer.md` | Closure `plans/closure/ci-release-orchestration/001-status.md`; hosted run 36040032768 passes all lanes | | CI orchestration | M002 qualification/aggregation gates + drift CLI | closed historically; corrective closed | `plans/implementation/ci-release-orchestration/002-qualification-aggregation-gates-and-drift-cli.md` | Historical closure retained; executable generated-workflow defect corrected and qualified by M002a (`plans/closure/ci-release-orchestration/002a-status.md`) | @@ -191,9 +192,9 @@ were removed rather than left to mislead. Build/Qualification M002a/M003/M004/M005 remain closed with hosted cross-platform evidence. CI M002 and Bootstrap M002 retain their historical implementation/closure records. Both M002a correctives are closed on implementation `4d2270a` with hosted run 36154905956 green. CI M003a retains its historical evidence (`36f1cc1`/36180399698); M003c corrected M003a/M003b's post-closure source-integrity and transfer findings in `5c28099`, qualified by hosted run 36213316240 (all four lanes green). CI M003d then closed the reusable consumer-composition/runtime-identity seam, and Build M005 closed deterministic cross-tool provisioning on `7a206ba` with hosted run 36256831000 green. -Ecosystem M001 and M002 are both closed. M001 stopped at its §20 condition before implementation, resumed after Build M006, and completed on eggsact `v1.2.7`; M002's cutover landed with no new Eggpack primitive and its live evidence arrived as stegoeggo `v0.5.0`. CI M003b is closed and Phase 8 is satisfied. Bootstrap M003 is closed at `plans/closure/bootstrap-installers/003-status.md` with zero production delta, so the adoption completion definition remains satisfied; the independent M002b Windows test-portability corrective is closed at `plans/closure/bootstrap-installers/002b-status.md`. Contract M003 is closed at `plans/closure/contract-conformance/003-status.md` on implementation `43fa2d7`, which completes the contract-conformance subsystem. **Ecosystem M003a is closed** at `plans/closure/ecosystem-adoption/003a-status.md` with no producer prerequisite. **Ecosystem M003b is closed** at `plans/closure/ecosystem-adoption/003b-status.md`: both paired plans were registered and the implementation landed in `eggstack/eggsearch`, with live staging evidence at eggsearch `v0.4.2` (run `37531104901`, draft `405157598`, exact 19-asset inventory, ARMv7 required validator green), provenance attestation of the staged bytes (run `37561960304`), and publication of that draft on 2026-10-07, which discharged the named condition. +Ecosystem M001 and M002 are both closed. M001 stopped at its §20 condition before implementation, resumed after Build M006, and completed on eggsact `v1.2.7`; M002's cutover landed with no new Eggpack primitive and its live evidence arrived as stegoeggo `v0.5.0`. CI M003b is closed and Phase 8 is satisfied. Bootstrap M003 is closed at `plans/closure/bootstrap-installers/003-status.md` with zero production delta, so the adoption completion definition remains satisfied; Bootstrap M002b Windows test-portability corrective is closed at `plans/closure/bootstrap-installers/002b-status.md`. Contract M003 is closed at `plans/closure/contract-conformance/003-status.md` on implementation `43fa2d7`, which completes the contract-conformance subsystem. **Ecosystem M003a is closed** at `plans/closure/ecosystem-adoption/003a-status.md` with no producer prerequisite. **Ecosystem M003b is closed** at `plans/closure/ecosystem-adoption/003b-status.md`: both paired plans were registered and the implementation landed in `eggstack/eggsearch`, with live staging evidence at eggsearch `v0.4.2` (run `37531104901`, draft `405157598`, exact 19-asset inventory, ARMv7 required validator green), provenance attestation of the staged bytes (run `37561960304`), and publication of that draft on 2026-10-07, which discharged the named condition. -## Immediate execution graph +## Completed dependency graph ```text Eggup distribution M003 [CLOSED / FROZEN PREDECESSOR] @@ -265,7 +266,7 @@ Manifest M001a corrective [CLOSED: target-local installs, global artifact filena | v v v | Bootstrap M003 [CLOSED: EVIDENCE/OWNERSHIP, NO M003a] Contract M003 [CLOSED] Ecosystem M003a eggsearch preflight [CLOSED] | (roadmap 11 completion satisfied) (bounded CLI surface) | - | `--> Ecosystem M003b adoption [CLOSED: plans/closure/ecosystem-adoption/003b-status.md] + | `--> Ecosystem M003b adoption [CLOSED: eggsearch v0.4.2 published 2026-10-07] | `--> bootstrap installers M001 [CLOSED; direct first-install generator] | @@ -291,7 +292,7 @@ Manifest M001a corrective [CLOSED: target-local installs, global artifact filena | `--> Release Manifest M003a status/closure reconciliation [CLOSED: DOCS ONLY] | - `--> Release Manifest M004 0.1.1 patch publication + compatibility event [ACTIVE] + `--> Release Manifest M004 0.1.1 patch publication + compatibility event [CLOSED: published and compatibility record written] External dist 0.33 spike [CLOSED, disposition C] --> prior art only @@ -334,6 +335,8 @@ The first hosted CI run of that chain found a further defect in the shared bound ``` CI M003p process-group termination of an already-exited group [CLOSED: 27cb16c] + | + `--> CI M003pa process-group signal recheck [CLOSED: 329a3df] ``` The obligation those two chains left outstanding is tracked by a third line: @@ -360,7 +363,9 @@ ADR-0006 [ACCEPTED 2026-10-23, Option A: digest acceptance set] ## Next handoff -Every closed milestone retains its closure record, so do not read this section as a shortlist: Contract M001/M002, Release Manifest M001/M001a/M002/M003/M003a, Build/Qualification M001–M006, CI M001/M002/M002a/M003a–M003h, Bootstrap M001/M002/M002a, Eggup Interoperability M001/M001a, Ecosystem M001/M002, External backend evaluation M001, and Planning Hygiene M001 all have accepted closure records under `plans/closure/`. Eggup Interoperability M003 is additionally closed downstream on the real Eggsact consumer. Per-subsystem detail is in `plans/subsystems/*-roadmap.md`; the milestone-to-closure index is the table above. +No implementation milestone is currently ready or active. CI/Release M003pa is closed at implementation `329a3dfdb166580de4770b2c6b2f046358983003`; hosted run `44118309795` passed all four lanes on that exact SHA, with the closure record at `plans/closure/ci-release-orchestration/003pa-status.md`. The entries under "Planned / blocked work" require named dependency evidence or further planning before they become eligible. + +Every closed milestone retains its closure record, so do not read this section as a shortlist: Contract M001/M002, Release Manifest M001/M001a/M002/M003/M003a, Build/Qualification M001–M006, CI M001/M002/M002a/M003a–M003pa (including M003k), Bootstrap M001/M002/M002a, Eggup Interoperability M001/M001a, Ecosystem M001/M002, External backend evaluation M001, and Planning Hygiene M001 all have accepted closure records under `plans/closure/`. Eggup Interoperability M003 is additionally closed downstream on the real Eggsact consumer. Per-subsystem detail is in `plans/subsystems/*-roadmap.md`; the milestone-to-closure index is the table above. M003h is closed on the synchronized, verified candidate. **Ecosystem M002 stegoeggo is closed** at `plans/closure/ecosystem-adoption/002-status.md` §9: consumer implementation `3b96fae` and closure `c75132a` prove the second-repo cutover without a new Eggpack producer primitive, and the live evidence arrived as stegoeggo `v0.5.0` — Eggpack run `37181914252`, published 2026-10-04T06:34:19Z from source `57ca94c9…`, exact 15-asset inventory, manual publication, real public `0.4.2 -> 0.5.0` updater transition. The `0.4.3` milestone earlier planning anticipated was stopped pre-publication by the consumer on semver grounds and superseded by `0.5.0`. @@ -376,13 +381,13 @@ Eggup completed that publication sequence and closed M004 at `eggstack/eggup@ea1 **Ecosystem M003a is closed** at `plans/closure/ecosystem-adoption/003a-status.md`. It was the last registered plan, and it closed read-only/scratch with zero production delta. The four compatibility gaps the split was created to resolve all resolved with existing producer capability: the Zig 0.13.0 archive-layout gap is real (confirmed 404 against ziglang.org for the name Eggpack constructs, 200 for the name that exists) but the pin is an unpublished implementation detail while the glibc 2.17 floor is the actual guarantee and is re-asserted post-build; ARMv7 keeps its runtime proof by classifying core qualification `Structural` and executing under a required product-owned consumer validator that still gates aggregation, while the alternative `Emulated` path renders a `--qemu-sysroot` flag while provisioning nothing; Artifact Attestations are preserved by a separate read-only product-owned workflow that attests exact already-staged bytes without requesting OIDC in any generated job; and no-clobber staging is strictly stronger than the `--clobber` it replaces. All seven targets rendered and `ci check` reported `match`. -**Historical pre-2026-10-08 snapshot (superseded by M002b/M003i handoff): no Eggpack plan was ready;** prior lines remain closed. **Ecosystem M003b is closed** at `plans/closure/ecosystem-adoption/003b-status.md`: the mirrored Eggsearch plan was registered at `eggstack/eggsearch@377f9e8` (registry `6767062`), the Eggsearch cutover landed on `eabbf80`, hosted run `37531104901` staged eggsearch `v0.4.2` as draft `405157598` with the exact 19-asset inventory and the ARMv7 required consumer validator green, run `37561960304` attested those staged bytes, and the draft was published on 2026-10-07 — discharging the condition that conditional closure had named. No OIDC permission was ever requested in a generated job. The current Eggpack action is M002b; this earlier plan-authoring statement is historical. +**Historical pre-2026-10-08 snapshot (superseded by M002b/M003i handoff): no Eggpack plan was ready;** prior lines remain closed. **Ecosystem M003b is closed** at `plans/closure/ecosystem-adoption/003b-status.md`: the mirrored Eggsearch plan was registered at `eggstack/eggsearch@377f9e8` (registry `6767062`), the Eggsearch cutover landed on `eabbf80`, hosted run `37531104901` staged eggsearch `v0.4.2` as draft `405157598` with the exact 19-asset inventory and the ARMv7 required consumer validator green, run `37561960304` attested those staged bytes, and the draft was published on 2026-10-07 — discharging the condition that conditional closure had named. No OIDC permission was ever requested in a generated job. At that historical point, M002b was the current Eggpack action; later handoffs and review chains superseded that status. -Eggsearch **M003b passed implementation and is conditionally closed.** M003a settled all five questions it was holding, and the Eggsearch implementation answered each one with existing producer capability and no new Eggpack primitive: the Zig/cargo-zigbuild pair migrated to the already-qualified 0.14.1/0.23.3 pair with the glibc 2.17 ceiling re-proven per GNU target on the exact staged bytes; ARMv7 kept its runtime proof through `Structural` core qualification plus a required product-owned consumer validator that gated `required_gate` and `aggregate`; Windows ARM64 stayed a required target on `windows-11-arm`; Artifact Attestation was preserved by a separate read-only product-owned workflow, leaving every generated job free of OIDC; and Eggpack's fail-closed staging superseded `--clobber`. The mirrored-plan precondition in planning process §9 was satisfied before any external edit, at `eggstack/eggsearch@377f9e8`. +Eggsearch **M003b is closed**, not conditionally closed: publication on 2026-10-07 discharged the only named condition. M003a settled all five questions it was holding, and the Eggsearch implementation answered each one with existing producer capability and no new Eggpack primitive: the Zig/cargo-zigbuild pair migrated to the already-qualified 0.14.1/0.23.3 pair with the glibc 2.17 ceiling re-proven per GNU target on the exact staged bytes; ARMv7 kept its runtime proof through `Structural` core qualification plus a required product-owned consumer validator that gated `required_gate` and `aggregate`; Windows ARM64 stayed a required target on `windows-11-arm`; Artifact Attestation was preserved by a separate read-only product-owned workflow, leaving every generated job free of OIDC; and Eggpack's fail-closed staging superseded `--clobber`. The mirrored-plan precondition in planning process §9 was satisfied before any external edit, at `eggstack/eggsearch@377f9e8`. Longer-horizon lines stay as recorded: Ecosystem M004-M007 behind completed Eggsearch adoption, Phase 12 provenance behind a dedicated trust ADR, Phase 13 package adapters behind broader native adoption, Phase 14 stabilization premature. Eggsact's Git-to-registry migration remains separately owned downstream. -**The 2026-10-23 post-implementation review registered a corrective chain.** It found that the workspace carries several rules and structures in more than one place, and that the two copies do not always agree: four file-digest implementations with different TOCTOU behaviour, three SHA-256 acceptance rules where the crate that stages bytes accepts a digest the CI crate refuses, two exact-tag rule sets that are disjoint in both directions, a CI process runner that kills only the direct child and joins its reader threads without a bound, and a drift comparison and a staging-payload builder that each exist in duplicate. It also found a declared-but-unenforced compatibility floor, and a CLI that exposes two of the nine operator commands the canonical specification names. The chain is registered above; it corrects closed milestones' behaviour without rewriting any closure record. **Build/Qualification M007 is closed** (`e3c6192`), **ADR-0006 is accepted (Option A)**, and **CI M003l is closed** (`9cf0bf8`), so the all-zeros SHA-256 sentinel is refused everywhere, `ReleaseManifest` stays at `schema_version: 1`, and the workspace carries one rule per producer concept. **Build/Qualification M008** (`7e7cb6a`), **Build/Qualification M009** (`eb77d19` + `8950eb9`), and **CI M003m** (`bd73f5c`) are also closed: a declared floor is recorded rather than dropped, six operator commands exist and share one implementation with the `ci _*` runners, and the CI crate no longer spawns a process of its own. **CI M003n** (`bf0acfe` + `028db4a`) and **Planning Hygiene M003** (docs-only) are closed as well, and so is **Bootstrap M003a** (the ADR-0006 adversarial digest fixture corrective, closure `plans/closure/bootstrap-installers/003a-status.md`), so the whole 2026-10-23 review chain is closed. +**The 2026-10-23 post-implementation review registered a corrective chain.** It found that the workspace carries several rules and structures in more than one place, and that the two copies do not always agree: four file-digest implementations with different TOCTOU behaviour, three SHA-256 acceptance rules where the crate that stages bytes accepts a digest the CI crate refuses, two exact-tag rule sets that are disjoint in both directions, a CI process runner that kills only the direct child and joins its reader threads without a bound, and a drift comparison and a staging-payload builder that each exist in duplicate. It also found a declared-but-unenforced compatibility floor, and a CLI that exposes two of the nine operator commands the canonical specification names. The chain is registered above; it corrects closed milestones' behaviour without rewriting any closure record. **Build/Qualification M007 is closed** (`e3c6192`), **ADR-0006 is accepted (Option A)**, and **CI M003l is closed** (`9cf0bf8`), so the all-zeros SHA-256 sentinel is refused everywhere, `ReleaseManifest` stays at `schema_version: 1`, and the workspace carries one rule per producer concept. **Build/Qualification M008** (`7e7cb6a`), **Build/Qualification M009** (`eb77d19` + `8950eb9`), and **CI M003m** (`bd73f5c`) are also closed: a declared floor is recorded rather than dropped, six operator commands exist and share one implementation with the `ci _*` runners, and the CI crate no longer spawns a process of its own. **CI M003n** (`bf0acfe` + `028db4a`) and **Planning Hygiene M003** (docs-only) are closed as well, and so is **Bootstrap M003a** (the ADR-0006 adversarial digest fixture corrective, closure `plans/closure/bootstrap-installers/003a-status.md`), so the whole 2026-10-23 review chain is closed. Release Manifest M004 is closed; the package publication and compatibility-record obligation were discharged. **A follow-up review of the chain's own output then found defects in the newly written code and registered a second corrective chain.** **Build/Qualification M007a** (`c17bdbe`) closes a zero-length digest record the consolidation could still produce. **Build/Qualification M008a** (`c17bdbe`) closes a fail-open in the floor reader, where abandoning the scan at the first non-numeric `GLIBC_` name masked a **contradicted** floor as an admissible `Unverified` status — the one defect in the chain that could let a release ship a binary violating its own declared floor. **Build/Qualification M009a** (`d2fbd07`) closes ten operator-command defects, the first of which destroyed the operator's own input candidate bytes. **CI M003o** (`b205de6`) closes a reachable panic in the workflow renderer and two digest diagnostics that misdescribed their refusal. The review found the CI crate otherwise sound — no rule weakened, no rendered byte changed, a byte-identical 85-item public API. Both review chains are closed, and the chain's first hosted CI run found a further defect that CI M003p closed; Release Manifest M004 discharged the ADR-0006 publication obligation the two chains left outstanding and is itself closed. diff --git a/plans/subsystems/bootstrap-installers-roadmap.md b/plans/subsystems/bootstrap-installers-roadmap.md index 7a00235..191690f 100644 --- a/plans/subsystems/bootstrap-installers-roadmap.md +++ b/plans/subsystems/bootstrap-installers-roadmap.md @@ -1,6 +1,6 @@ # Bootstrap Installers Roadmap -Status: active; M002b corrective closed +Status: complete Long-term references: @@ -123,6 +123,6 @@ Bootstrap has no remaining open work from the M003 decision pass. The only follo ## 13. 2026-10-08 corrective addendum — M002b -**M002b opening evidence (historical):** `plans/implementation/bootstrap-installers/002b-windows-posix-archive-test-portability-corrective.md`. At `3ef806fedc9d7683948e5678ec0d3c7b78c06f0e`, hosted Windows run 37649332862 fails to compile POSIX-only test uses of `std::os::unix::fs::PermissionsExt` in the PowerShell archive test lane; Linux stable/MSRV and macOS passed. This is test portability, not a reversal of M002/M002a/M003 historical closures, nor a new installer feature. Keep POSIX archive runtime coverage on Unix and PowerShell runtime coverage on Windows. Full four-lane strict closure at `plans/closure/bootstrap-installers/002b-status.md` was a hard gate for CI M003i. At the time, this addendum superseded prior 'no open bootstrap work' statements. +**Historical M002b ready handoff (closed below):** `plans/implementation/bootstrap-installers/002b-windows-posix-archive-test-portability-corrective.md`. At `3ef806fedc9d7683948e5678ec0d3c7b78c06f0e`, hosted Windows run 37649332862 fails to compile POSIX-only test uses of `std::os::unix::fs::PermissionsExt` in the PowerShell archive test lane; Linux stable/MSRV and macOS passed. This is test portability, not a reversal of M002/M002a/M003 historical closures, nor a new installer feature. Keep POSIX archive runtime coverage on Unix and PowerShell runtime coverage on Windows. Full four-lane strict closure at `plans/closure/bootstrap-installers/002b-status.md` is a hard gate for CI M003i. At that time, this addendum superseded prior 'no open bootstrap work' statements; M002b is now closed below. -**M002b closed** on implementation `88ddf2e796ac3674b306b51726c65ed7cc9bd29a`; hosted run `37806244313` passed Linux stable, Linux 1.89, macOS, and Windows. The POSIX archive runtime test is Unix-gated and still executes on both Unix lanes; the Windows `pwsh 7` + `tar.exe` PowerShell runtime test remains enabled and passed. Formal evidence: `plans/closure/bootstrap-installers/002b-status.md`. This strict closure unblocked CI M003i. +**M002b closed** on implementation `88ddf2e796ac3674b306b51726c65ed7cc9bd29a`; hosted run `37806244313` passed Linux stable, Linux 1.89, macOS, and Windows. The POSIX archive runtime test is Unix-gated and still executes on both Unix lanes; the Windows `pwsh 7` + `tar.exe` PowerShell runtime test remains enabled and passed. Formal evidence: `plans/closure/bootstrap-installers/002b-status.md`. This strict closure unblocks CI M003i. diff --git a/plans/subsystems/build-qualification-roadmap.md b/plans/subsystems/build-qualification-roadmap.md index 81686fe..6e8ccd2 100644 --- a/plans/subsystems/build-qualification-roadmap.md +++ b/plans/subsystems/build-qualification-roadmap.md @@ -1,6 +1,6 @@ # Build and Qualification Roadmap -Status: active +Status: complete Long-term references: diff --git a/plans/subsystems/ci-release-orchestration-roadmap.md b/plans/subsystems/ci-release-orchestration-roadmap.md index c55cf30..af5b6de 100644 --- a/plans/subsystems/ci-release-orchestration-roadmap.md +++ b/plans/subsystems/ci-release-orchestration-roadmap.md @@ -1,6 +1,6 @@ # CI and Release Orchestration Roadmap -Status: active +Status: complete Long-term references: @@ -100,9 +100,9 @@ M003h status-reconciliation/main-integration corrective plan: `plans/implementat M003i identity-separation corrective: `plans/implementation/ci-release-orchestration/003i-explicit-tag-and-manifest-release-identity-corrective.md` (**closed** at `plans/closure/ci-release-orchestration/003i-status.md`; implementation `3ddac9d84fc2e10b8451d38672f66b02e06724df`, hosted run `37813044035`, all four lanes green). The immutable producer pin unblocked the separate wg-basic Distribution M003 for its consumer-owned implementation and qualification. -M003j dispatch-tag shell-injection corrective: `plans/implementation/ci-release-orchestration/003j-dispatch-tag-shell-injection-corrective.md` (**closed** at `plans/closure/ci-release-orchestration/003j-status.md`; implementation `559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce`, hosted run `37987890305`, four platform lanes green). It removes executable interpolation and qualifies data-only tag validation. The separate pre-checkout ordering and stage-environment gaps are registered as M003k. +M003j dispatch-tag shell-injection corrective: `plans/implementation/ci-release-orchestration/003j-dispatch-tag-shell-injection-corrective.md` (**closed** at `plans/closure/ci-release-orchestration/003j-status.md`; implementation `559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce`, hosted run `37987890305`, four platform lanes green). It removes executable interpolation and qualifies data-only tag validation. The separate pre-checkout ordering and stage-environment gaps were registered and closed as M003k. -M003k pre-checkout tag resolution and stage-environment support: `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` (**in progress**; PR `eggstack/eggpack#1`, producer head `23d9f0347d89fd6ecd916692c145152e39de687f`, local gate and hosted run `38027143275` passed; independent review/merge and downstream qualification remain). +M003k pre-checkout tag resolution and stage-environment support: `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` (**closed** at `plans/closure/ci-release-orchestration/003k-status.md`). PR `eggstack/eggpack#1` merged at `1103a1affc62a210f1102a769457db80d9188bc8`; final producer head `fb81aa1400e1f333f6500075f78d944a9242b673` passed hosted run `38027470046` on all four lanes. wg-basic pinned the producer, regenerated the workflow with an exact `eggpack ci check` match (40,658 bytes), configured the stage environment, and closed R001 at `dbowm91/wg-basic@1e034d089ca62d9f4c22a562a3067227ad8beb9d`, with exact-head hosted CI run `38108270370` and Distribution Foundation run `38108270368`. The live tagged-stage preflight remains deferred to wg-basic R004 and was not required for M003k closure. The 2026-10-23 post-implementation review registered three further corrective milestones against this subsystem, chained behind M003k because each modifies `crates/eggpack-ci/src/lib.rs`. **M003l** converged the producer rules the CI crate re-derives — host/target matching, compatibility-floor applicability, exact-tag safety, the SHA-256 hex acceptance set, and the file digest — onto single owners in `eggpack-core` and `eggpack-manifest`; it closed on `9cf0bf8` under accepted ADR-0006 (Option A), and the two exact-tag rule sets that were disjoint in both directions are now replaced by their union. **M003m** converges the CI consumer-validator execution onto the workspace's single bounded process runner, which kills the whole process group and bounds its reader-thread joins; before it, the CI runner killed only the direct child and could therefore block indefinitely when a descendant held an inherited pipe, defeating the timeout, cancellation, and output bounds the same function implemented. It closed on `bd73f5c` (cherry-picked `6a7cb4c`). **M003n** removed the duplicated drift comparison and staging-payload builder, decomposed the 845-line `render_release_github_inner`, and turned the CI source file into a 14-file module tree; it closed on `bf0acfe` + `028db4a` (cherry-picked `4692bd5` + `e66c7d1`) with byte-identical outputs and a byte-identical public API throughout. @@ -110,6 +110,8 @@ A follow-up review of that chain's own output registered one further corrective The first hosted CI run of that chain — run `40207520563` on `d4d5e43` — failed on macOS, and registered one further corrective against this subsystem. **M003p** fixes the shared bounded runner's treatment of a process group that has already exited: macOS refuses to signal a group that still holds the unreaped zombie of an exited child and reports the whole signal as `EPERM`, where Linux signals it successfully. The runner treated any failed group signal as fatal, so an output-bound violation was reported as a launch failure on one platform and as an output-bound violation on the other. The rule is now that a failed group signal may be ignored when there is nothing left to terminate, decided by observing whether the supervised child has exited rather than by reading the errno; a group holding a live process that cannot be signalled still fails the run closed. It closed on `27cb16c`. +A review of M003p's group-empty assumption found that the supervised leader's exit does not prove the whole process group is empty: a surviving descendant may have closed its output pipes, and `EPERM` does not certify that the group has no live member. **M003pa** corrected that inference while preserving M003p's historical plan and closure. It keeps initial `ESRCH` benign; after another signal error, it reaps an exited leader and retries the group signal, accepting only retry success or retry `ESRCH`. A live/unverified leader or any other retry error remains a hard failure. M003pa closed on implementation `329a3dfdb166580de4770b2c6b2f046358983003`; exact hosted run `44118309795` passed Linux stable, Linux 1.89.0, macOS, and Windows. + ## 8. Cross-cutting requirements Least privilege, pinned actions, explicit timeouts, concurrency controls, artifact provenance, no secret leakage in generated summaries. @@ -150,13 +152,14 @@ Build/Qualification M001-M006 and CI M001/M002/M002a/M003c-M003g are closed on t | M003g live qualification failures corrective | closed | `plans/implementation/ci-release-orchestration/003g-live-qualification-corrective.md` | `plans/closure/ci-release-orchestration/003g-status.md`; implementations `5acda73`/`4b28820`/`5ac5b83`/`e5c81f2`; hosted runs 36638321253, 36642184204, 36646814734, 36652203168 all lanes | cross-tool PATH, invalid zigbuild check, artifact exec-bit stripping, consumer validation against failed evidence, stage arity, swallowed staging error, and boolean `make_latest` all corrected; live run 36652731202 staged a complete 15-asset draft for eggsact `v1.2.7`, which the maintainer then published | | M003h live qualification status reconciliation + main integration | closed | `plans/implementation/ci-release-orchestration/003h-live-qualification-status-reconciliation-and-main-integration.md` | `plans/closure/ci-release-orchestration/003h-status.md` | current `main@404f63ec` was merged by `609d5fb`; status reconciled, full verification passed, and `main` fast-forwarded without force | | M003i explicit tag and manifest release identity corrective | closed | `plans/implementation/ci-release-orchestration/003i-explicit-tag-and-manifest-release-identity-corrective.md` | `plans/closure/ci-release-orchestration/003i-status.md`; implementation `3ddac9d84fc2e10b8451d38672f66b02e06724df`; hosted run `37813044035` passed all four lanes | Finite checked-in opt-in stable-tag mapping with explicitly versioned runtime envelope; legacy exact-tag workflow bytes and ReleaseManifest v1 remain unchanged; wg-basic M003 may resume against the immutable producer SHA | -| M003j dispatch tag shell-injection corrective | closed | `plans/implementation/ci-release-orchestration/003j-dispatch-tag-shell-injection-corrective.md` | `plans/closure/ci-release-orchestration/003j-status.md`; implementation `559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce`; hosted run `37987890305` all four lanes green | Injection is fixed; pre-checkout ordering and stage environment remain M003k requirements | -| M003k pre-checkout tag resolution + stage approval gate | in progress | `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` | PR `eggstack/eggpack#1` at `23d9f0347d89fd6ecd916692c145152e39de687f`; run `38027143275` all four lanes green; independent review/merge and downstream `dbowm91/wg-basic` qualification pending | +| M003j dispatch tag shell-injection corrective | closed | `plans/implementation/ci-release-orchestration/003j-dispatch-tag-shell-injection-corrective.md` | `plans/closure/ci-release-orchestration/003j-status.md`; implementation `559d940af0fe6a2951eb17de1fcbecbf9e0bb6ce`; hosted run `37987890305` all four lanes green | Dispatch tags are data, not executable shell text; M003k separately closed the pre-checkout ordering and stage-environment gaps | +| M003k pre-checkout tag resolution + stage approval gate | closed | `plans/implementation/ci-release-orchestration/003k-precheckout-tag-resolution-and-stage-environment.md` | `plans/closure/ci-release-orchestration/003k-status.md`; PR `eggstack/eggpack#1` merged at `1103a1affc62a210f1102a769457db80d9188bc8`; implementation head `fb81aa1400e1f333f6500075f78d944a9242b673`, hosted run `38027470046` all four lanes green; downstream wg-basic R001 closed at `1e034d089ca62d9f4c22a562a3067227ad8beb9d` with runs `38108270370` and `38108270368` | | M003l producer rule authority convergence corrective | closed | `plans/implementation/ci-release-orchestration/003l-producer-rule-authority-convergence-corrective.md` | `plans/closure/ci-release-orchestration/003l-status.md`; implementation `9cf0bf8` | Accepted ADR-0006 Option A implemented. One owner each for host/target match, floor applicability, exact-tag safety, SHA-256 acceptance, and the file digest; the two exact-tag rule sets were disjoint in both directions and their union is canonical. `eggpack-manifest` `0.1.1`; `ReleaseManifest` v1 unchanged | | M003m bounded process execution convergence corrective | closed | `plans/implementation/ci-release-orchestration/003m-bounded-process-execution-convergence-corrective.md` | `plans/closure/ci-release-orchestration/003m-status.md`; implementation `bd73f5c` (cherry-picked `6a7cb4c`) | The CI consumer-validator runner routes through the workspace's single bounded process-group runner; the CI-local runner, its bounded readers, and its unbounded drain are deleted, and the CI production region contains no process-spawning code. The outcome mapping is asserted by test and the generated workflow bytes are unchanged | | M003n producer implementation consolidation corrective | closed | `plans/implementation/ci-release-orchestration/003n-producer-implementation-consolidation-corrective.md` | `plans/closure/ci-release-orchestration/003n-status.md`; implementations `bf0acfe` + `028db4a` (cherry-picked `4692bd5` + `e66c7d1`) | One drift comparison replaces three byte-identical copies; one staging-payload builder replaces two copies that were 85.5% identical (301 of 352 lines); `render_release_github_inner` (845 lines) is decomposed into named private helpers; the CI crate's 12,221-line source file became a 14-file module tree with a 59-line crate root. The public API is byte-identical before and after and every rendered workflow, drift report, and staging payload is byte-identical | | M003o renderer panic and digest diagnostics corrective | closed | `plans/implementation/ci-release-orchestration/003o-renderer-panic-and-digest-diagnostics.md` | `plans/closure/ci-release-orchestration/003o-status.md`; implementation `b205de6` | The workflow renderer's generated-directory check was an assertion that a legal 128-character contract target could trip; it is now a refusal, so a caller-supplied contract cannot panic the renderer. Two digest diagnostics named a formatting problem where ADR-0006 refuses the well-formed all-zeros digest; they now name the actual reason. The CI crate's 85 public items and every rendered byte are unchanged | | M003p process-group termination of an already-exited group corrective | closed | `plans/implementation/ci-release-orchestration/003p-process-group-termination-of-an-already-exited-group.md` | `plans/closure/ci-release-orchestration/003p-status.md`; implementation `27cb16c`; hosted run `40263176191` green on all four lanes | The first hosted CI run of the 2026-10-23 review chain (`40207520563`) failed on macOS. The shared bounded runner treated a failed process-group signal as fatal, but macOS reports `EPERM` for a group holding the unreaped zombie of an exited child, where Linux signals it successfully. A failed signal is now benign when there is nothing left to terminate, decided by observing the child rather than by reading the errno; a group holding a live process that cannot be signalled still fails closed. The CI crate's 85 public items and every rendered byte are unchanged | +| M003pa process-group signal recheck corrective | closed | `plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md` | `plans/closure/ci-release-orchestration/003pa-status.md`; implementation `329a3dfdb166580de4770b2c6b2f046358983003`; hosted run `44118309795` green on all four lanes | Corrects M003p's overbroad inference that an exited leader proves the group is empty. After leader reaping, only retry success or `ESRCH` is benign; other cases remain fail-closed | ## 13. 2026-10-08 corrective addendum — M003i diff --git a/plans/subsystems/contract-conformance-roadmap.md b/plans/subsystems/contract-conformance-roadmap.md index 2922a9f..2c3c07d 100644 --- a/plans/subsystems/contract-conformance-roadmap.md +++ b/plans/subsystems/contract-conformance-roadmap.md @@ -1,6 +1,6 @@ # Contract and Conformance Roadmap -Status: active +Status: complete Long-term references: diff --git a/plans/subsystems/ecosystem-adoption-roadmap.md b/plans/subsystems/ecosystem-adoption-roadmap.md index 16e7dfc..897e6b9 100644 --- a/plans/subsystems/ecosystem-adoption-roadmap.md +++ b/plans/subsystems/ecosystem-adoption-roadmap.md @@ -1,6 +1,6 @@ # Ecosystem Adoption Roadmap -Status: active +Status: blocked Long-term references: diff --git a/plans/subsystems/eggup-interoperability-roadmap.md b/plans/subsystems/eggup-interoperability-roadmap.md index cdf139d..18bc7e7 100644 --- a/plans/subsystems/eggup-interoperability-roadmap.md +++ b/plans/subsystems/eggup-interoperability-roadmap.md @@ -1,6 +1,6 @@ # Eggup Interoperability Roadmap -Status: active +Status: complete Long-term references: diff --git a/plans/subsystems/planning-hygiene-roadmap.md b/plans/subsystems/planning-hygiene-roadmap.md index 8ce3336..7611311 100644 --- a/plans/subsystems/planning-hygiene-roadmap.md +++ b/plans/subsystems/planning-hygiene-roadmap.md @@ -1,6 +1,6 @@ # Planning Hygiene Roadmap -Status: active +Status: complete Long-term references: diff --git a/plans/subsystems/release-manifest-roadmap.md b/plans/subsystems/release-manifest-roadmap.md index 622bcd3..8071cea 100644 --- a/plans/subsystems/release-manifest-roadmap.md +++ b/plans/subsystems/release-manifest-roadmap.md @@ -1,6 +1,6 @@ # Release Manifest Roadmap -Status: active +Status: complete Long-term references: