fix: knownTypes should only apply to imported types

knownTypes entries were being applied to all types regardless of whether
they were local to the source package or imported from another package.
This caused local types that appeared in knownTypes to be rendered with
external links rather than local anchor links, breaking in-page
navigation when rendered locally.

Move the lookup inside the IsBasic/Imported branch so that it only
applies to types that cannot resolve to a local anchor.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Author: stephenfin

renderer/functions.go

@@ -75,11 +75,10 @@ func (f *Functions) LinkForType(t *types.Type) (link string, local bool) {
 		return f.LinkForKubeType(t), false
 	}
 
-	if kt, ok := f.IsKnownType(t); ok {
-		return f.LinkForKnownType(kt), false
-	}
-
 	if t.IsBasic() || t.Imported {
+		if kt, ok := f.IsKnownType(t); ok {
+			return f.LinkForKnownType(kt), false
+		}
 		return "", false
 	}
 

renderer/functions_test.go

@@ -55,11 +55,8 @@ func TestLinkForType(t *testing.T) {
 		{
 			name:      "local type ignores knownTypes and gets local link",
 			typ:       &types.Type{Name: "Foo", Package: "example.com/pkg", Imported: false},
-			// FIXME: This is incorrect and should be a relative link
-			// wantLink:  "example-com-pkg-foo",
-			// wantLocal: true,
-			wantLink:  "https://example.com/docs#foo",
-			wantLocal: false,
+			wantLink:  "example-com-pkg-foo",
+			wantLocal: true,
 		},
 		{
 			name:      "kube type gets kubernetes.io link even when also in knownTypes",