From 11902f08a00ccbe13f2b38115bf57d182bd8325a Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 12:49:52 +0000 Subject: [PATCH 1/7] ci: run required checks on every pull request The Perl test matrix and the perlcritic check were limited by paths filters on pull_request. Branch protection requires these checks, so PRs that only touch other files (e.g. renovate.json) never got a result and stayed BLOCKED. Remove the pull_request path filters so the required checks always report. Push triggers are unchanged. --- .github/workflows/fhem_test.yml | 13 ++----------- .github/workflows/perlCritic.yml | 6 +----- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/.github/workflows/fhem_test.yml b/.github/workflows/fhem_test.yml index 24ff8c1..771c327 100644 --- a/.github/workflows/fhem_test.yml +++ b/.github/workflows/fhem_test.yml @@ -4,18 +4,9 @@ permissions: contents: read on: + # Kein paths-Filter bei pull_request: Required Status Checks müssen auf jedem PR + # gemeldet werden, sonst bleiben reine Renovate-/Doku-PRs auf BLOCKED stehen. pull_request: - paths: - - 'FHEM/**' - - 'lib/**' - - 'CHANGED' - - 'controls_WebAuth.txt' - - 'README.md' - - '.devcontainer/svn-manifest.txt' - - 't/**' - - 'cpanfile' - - 'scripts/**' - - '.github/workflows/fhem_test.yml' push: paths: - 'FHEM/**' diff --git a/.github/workflows/perlCritic.yml b/.github/workflows/perlCritic.yml index 8cf9bf4..56cd396 100644 --- a/.github/workflows/perlCritic.yml +++ b/.github/workflows/perlCritic.yml @@ -5,13 +5,9 @@ concurrency: cancel-in-progress: true on: + # Kein paths-Filter: Der Check "perlcritic" ist Required und muss auf jedem PR gemeldet werden. pull_request: types: [opened, synchronize, reopened] - paths: - - 'FHEM/**' - - 'lib/**' - - '.perlcritic' - - '.github/workflows/perlCritic.yml' workflow_dispatch: jobs: From 695f11f06efc9db64c8d45eed7666e73a349da71 Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 12:54:23 +0000 Subject: [PATCH 2/7] ci(perlcritic): install RequireExplicitPackage before the policy task Task::PerlCriticAllPolicies pulls in the ObjectPad policy, which needs Perl::Critic::Policy::Modules::RequireExplicitPackage >= 1.134. cpanm resolved an older 1.132 through the task and bailed out, so the job failed before linting. Install the module explicitly first; no policies are dropped. --- .github/workflows/perlCritic.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/perlCritic.yml b/.github/workflows/perlCritic.yml index 56cd396..e968a27 100644 --- a/.github/workflows/perlCritic.yml +++ b/.github/workflows/perlCritic.yml @@ -20,7 +20,9 @@ jobs: with: perl-version: '5.38' install-modules-with: cpanm - install-modules: Perl::Critic Task::PerlCriticAllPolicies + # RequireExplicitPackage explizit vorab installieren: Die ObjectPad-Policy verlangt + # >= 1.134, cpanm holt sonst über den Task eine ältere Version und bricht ab. + install-modules: Perl::Critic::Policy::Modules::RequireExplicitPackage Perl::Critic Task::PerlCriticAllPolicies install-modules-args: --notest - uses: reviewdog/action-setup@v1 with: From cdc2c474ba83a95351b9f59aed8e030cf4430fef Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 12:58:03 +0000 Subject: [PATCH 3/7] Revert "ci(perlcritic): install RequireExplicitPackage before the policy task" This reverts commit 695f11f06efc9db64c8d45eed7666e73a349da71. --- .github/workflows/perlCritic.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/perlCritic.yml b/.github/workflows/perlCritic.yml index e968a27..56cd396 100644 --- a/.github/workflows/perlCritic.yml +++ b/.github/workflows/perlCritic.yml @@ -20,9 +20,7 @@ jobs: with: perl-version: '5.38' install-modules-with: cpanm - # RequireExplicitPackage explizit vorab installieren: Die ObjectPad-Policy verlangt - # >= 1.134, cpanm holt sonst über den Task eine ältere Version und bricht ab. - install-modules: Perl::Critic::Policy::Modules::RequireExplicitPackage Perl::Critic Task::PerlCriticAllPolicies + install-modules: Perl::Critic Task::PerlCriticAllPolicies install-modules-args: --notest - uses: reviewdog/action-setup@v1 with: From 16111cce7bb831c2571479b9761e658da98c0a63 Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 12:58:45 +0000 Subject: [PATCH 4/7] ci(perlcritic): install Perl::Critic::Grape before the policy task Task::PerlCriticAllPolicies pulls in Perl::Critic::Grape, which cpanm does not treat as installed after the bundle run, so the job bails out before linting. Install Grape explicitly first; no policies are dropped. Same fix as fhem/mod_RSL#141. --- .github/workflows/perlCritic.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/perlCritic.yml b/.github/workflows/perlCritic.yml index 56cd396..b326691 100644 --- a/.github/workflows/perlCritic.yml +++ b/.github/workflows/perlCritic.yml @@ -20,7 +20,9 @@ jobs: with: perl-version: '5.38' install-modules-with: cpanm - install-modules: Perl::Critic Task::PerlCriticAllPolicies + # Perl::Critic::Grape vorab installieren: Task::PerlCriticAllPolicies bricht sonst + # in cpanm ab, weil Grape nach dem Lauf nicht als installiert gilt (siehe fhem/mod_RSL#141). + install-modules: Perl::Critic::Grape Perl::Critic Task::PerlCriticAllPolicies install-modules-args: --notest - uses: reviewdog/action-setup@v1 with: From 61abd37f1a9843194284d402ad74f124e0343673 Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 13:01:40 +0000 Subject: [PATCH 5/7] ci(perlcritic): install Perl::Critic before Grape and the policy task Installing Grape first let cpanm pull an older Perl::Critic (1.132) through its dependencies, which the policy bundle then rejected. Install Perl::Critic first, then Grape, then the task. No policies are dropped. --- .github/workflows/perlCritic.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/perlCritic.yml b/.github/workflows/perlCritic.yml index b326691..2be094b 100644 --- a/.github/workflows/perlCritic.yml +++ b/.github/workflows/perlCritic.yml @@ -20,9 +20,9 @@ jobs: with: perl-version: '5.38' install-modules-with: cpanm - # Perl::Critic::Grape vorab installieren: Task::PerlCriticAllPolicies bricht sonst - # in cpanm ab, weil Grape nach dem Lauf nicht als installiert gilt (siehe fhem/mod_RSL#141). - install-modules: Perl::Critic::Grape Perl::Critic Task::PerlCriticAllPolicies + # Perl::Critic zuerst in aktueller Version, dann Grape: Die Abhängigkeiten der Task + # verlangen sonst eine neuere Perl::Critic-Version, als cpanm vorab installiert hat. + install-modules: Perl::Critic Perl::Critic::Grape Task::PerlCriticAllPolicies install-modules-args: --notest - uses: reviewdog/action-setup@v1 with: From 4bcc26ad16d8d4e9ac0023ff697abb59906ea4a4 Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 13:55:42 +0000 Subject: [PATCH 6/7] ci: trigger checks after enabling FHEM Unit Tests workflow From c2ea318381137b80df374c54f9d4ec4426eff102 Mon Sep 17 00:00:00 2001 From: Codex Date: Sun, 8 Nov 2026 13:56:36 +0000 Subject: [PATCH 7/7] ci(fhem_test): use setup-fhem v1.0.2 v1.0.1 stores the ASCII-armored debian.fhem.de key as .key, which the current apt rejects, so the Perl matrix fails before any test runs. v1.0.2 stores it as .asc. --- .github/workflows/fhem_test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/fhem_test.yml b/.github/workflows/fhem_test.yml index 771c327..ace704f 100644 --- a/.github/workflows/fhem_test.yml +++ b/.github/workflows/fhem_test.yml @@ -43,7 +43,7 @@ jobs: - name: Install CPAN dependencies run: cpanm --installdeps . --notest - name: Install FHEM via debian nightly - uses: fhem/setup-fhem@v1.0.1 + uses: fhem/setup-fhem@v1.0.2 - name: Change ownership of /opt/fhem run: sudo chown -R --reference=cpanfile /opt/fhem - name: Run helper module tests