From 3a2e7f06cc81b3d2fad643e4b311835920d4ed05 Mon Sep 17 00:00:00 2001 From: Raghu Betina Date: Fri, 6 Nov 2026 12:11:27 -0500 Subject: [PATCH] Use the consolidated cross-review plugin cross-review 0.9.0 merged its codex-review and claude-review plugins into one cross-review plugin. Claude Code would rewrite the old tracked key in a contributor's checkout, leaving a modified file, and Codex ignores a stale key without saying so, so a contributor could lose the review plugin with no error. The agent instructions also pointed at Skills that no longer exist. --- .claude/settings.json | 2 +- .codex/config.toml | 2 +- AGENTS.md | 4 ++-- CONTRIBUTING.md | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.claude/settings.json b/.claude/settings.json index 32fe7f4..e4057d3 100644 --- a/.claude/settings.json +++ b/.claude/settings.json @@ -8,7 +8,7 @@ } }, "enabledPlugins": { - "codex-review@cross-review": true + "cross-review@cross-review": true }, "attribution": { "commit": "", diff --git a/.codex/config.toml b/.codex/config.toml index 5388868..f3cf69c 100644 --- a/.codex/config.toml +++ b/.codex/config.toml @@ -2,5 +2,5 @@ source_type = "git" source = "https://github.com/raghubetina/cross-review.git" -[plugins."claude-review@cross-review"] +[plugins."cross-review@cross-review"] enabled = true diff --git a/AGENTS.md b/AGENTS.md index 70089af..0ac53b2 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -12,8 +12,8 @@ handled-error recovery in `docs/errors.md`, publication mechanics in `RELEASING. owns the Skill and plugin packaging. - Changes to the accepted API-contract range, accepted Plan formats, command names or flags, handled `error` values, exit statuses, `AGENTS.md`, `CLAUDE.md`, `CONTRIBUTING.md`, `RELEASING.md`, `.claude/settings.json`, or - `.codex/config.toml` get an independent review through cross-review: `codex-review` from Claude Code, - `$claude-review` from Codex. Pass the service repository's `docs/review-focus.md` as `--focus-file` (see + `.codex/config.toml` get an independent review through the `cross-review` Skill, with `codex` as the reviewer from + Claude Code and `claude` from Codex. Pass the service repository's `docs/review-focus.md` as `--focus-file` (see `CONTRIBUTING.md`). Put the reviewer, verdict, and finding counts in the pull request body, not the findings. - `firstdraft plan compile` defaults to local output in the current directory. GitHub publication requires `--github`; Codespaces is a fallback. Keep Skill callers and recovery instructions aligned with this boundary. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8fe5e49..3d20d96 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -51,11 +51,11 @@ tracked in open Issue #123 instead. The [pull request template](.github/pull_req The reviewer is the other vendor's agent, through [cross-review](https://github.com/raghubetina/cross-review): Codex reviews from Claude Code, and Claude Code reviews from Codex. Install both and sign in to each (`claude auth login` -and `codex login`). In Claude Code, ask for a Codex review or run `/codex-review:codex-review`; in Codex, use -`$claude-review`. Neither is a shell command. +and `codex login`). The plugin takes the reviewer as its first argument: in Claude Code, ask for a Codex review or +run `/cross-review codex`; in Codex, use `$cross-review claude`. Neither is a shell command. -The tracked `.claude/settings.json` and `.codex/config.toml` enable both plugins once you trust the main checkout, -and linked worktrees inherit that trust. The cross-review README covers installing them by hand. +The tracked `.claude/settings.json` and `.codex/config.toml` enable the plugin once you trust the main checkout, and +linked worktrees inherit that trust. The cross-review README covers installing it by hand. To run a review: