Skip to content
This repository was archived by the owner on Jan 27, 2024. It is now read-only.
This repository was archived by the owner on Jan 27, 2024. It is now read-only.

Registering filters 3 times #23

Description

@Timvissers

Hello,

You are registring the filters in the underscore, the filters and the specific filter (per name) module. This means a filter with the same name is registered 3 times.
Of course you can choose what module you are loading as a dependency of an application.

I just wanted to mention that I think it's not good practice to load a filter with a certain name 3 times. And scripts like stop-angular-overrides are treating this as errors (which is good imho).

Best regards,
Tim

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions