net: phy: as21xxx: apply a default LED configuration

The driver never programs the VEND1_LED_REG() event field on its own, it
only reacts to the LED class devices instantiated by of_phy_leds(). Two
things follow from that and both end up with dark RJ45 LEDs.

Without a "leds" node in the PHY device tree node the event registers keep
their post firmware-load reset value, which is not a link or activity
pattern. With a "leds" node the situation is worse: of_phy_leds() runs from
phy_probe(), long before phy_attach_direct() populates phydev->attached_dev,
so phy_led_hw_control_get_device() returns NULL, the netdev trigger falls
back to software mode with no interface bound and the initial brightness
update writes EVENT_OFF to the PHY.

Program a default from config_init(), which runs on phy_init_hw() and
therefore after of_phy_leds(). Keep LED0 as link-plus-activity and change
LED1 to indicate any link speed, matching the expected board behavior where
yellow is solid when link is up.
Userspace and the netdev trigger can still override this at any time
through the LED class devices.

While at it register config_init on the AS212xx and AS215xx entries too, so
the default applies to every supported variant instead of only AS2101x.

Signed-off-by: Pietro Ameruoso <p.ameruoso@live.it>

Author: pameruoso

drivers/net/phy/as21xxx.c

@@ -640,8 +640,53 @@ static int as21xxx_probe(struct phy_device *phydev)
 	return 0;
 }
 
+static int as21xxx_led_set_event(struct phy_device *phydev, u8 index,
+				 enum as21xxx_led_event event)
+{
+	return phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+			      VEND1_LED_REG(index),
+			      VEND1_LED_REG_A_EVENT,
+			      FIELD_PREP(VEND1_LED_REG_A_EVENT, event));
+}
+
+#define AS21XXX_LED_BLINK_RATE_15_6HZ	0x1
+
+/* Default LED setup:
+ *   LED0  On: link detected, blink: Rx/Tx activity
+ *   LED1  On: any link detected
+ *
+ * The firmware leaves the LED event registers unconfigured and registering
+ * the DT LED class devices drives them to EVENT_OFF, so program the defaults
+ * here. config_init() runs after of_phy_leds(), and userspace or the netdev
+ * trigger can still override them later.
+ */
+static int as21xxx_led_config_default(struct phy_device *phydev)
+{
+	int ret;
+
+	ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1, VEND1_LED_CONF,
+			     VEND1_LED_CONFG_BLINK,
+			     FIELD_PREP(VEND1_LED_CONFG_BLINK,
+					AS21XXX_LED_BLINK_RATE_15_6HZ));
+	if (ret)
+		return ret;
+
+	ret = as21xxx_led_set_event(phydev, 0,
+				    VEND1_LED_REG_A_EVENT_ON_LINK_BLINK_ACT);
+	if (ret)
+		return ret;
+
+	return as21xxx_led_set_event(phydev, 1, VEND1_LED_REG_A_EVENT_ON_LINK);
+}
+
 static int as21xxx_config_init(struct phy_device *phydev)
 {
+	int ret;
+
+	ret = as21xxx_led_config_default(phydev);
+	if (ret)
+		return ret;
+
 	if (phydev->interface == PHY_INTERFACE_MODE_USXGMII)
 		return aeon_dpc_ra_enable(phydev);
 
@@ -1159,6 +1204,7 @@ static struct phy_driver as21xxx_drivers[] = {
 		.name		= "Aeonsemi AS21210PB1",
 		.probe		= as21xxx_probe,
 		.match_phy_device = as21xxx_match_phy_device,
+		.config_init	= as21xxx_config_init,
 		.read_status	= as21xxx_read_status,
 		.read_mmd	= as21xxx_read_mmd,
 		.led_brightness_set = as21xxx_led_brightness_set,
@@ -1173,6 +1219,7 @@ static struct phy_driver as21xxx_drivers[] = {
 		.name		= "Aeonsemi AS21510JB1",
 		.probe		= as21xxx_probe,
 		.match_phy_device = as21xxx_match_phy_device,
+		.config_init	= as21xxx_config_init,
 		.read_status	= as21xxx_read_status,
 		.read_mmd	= as21xxx_read_mmd,
 		.led_brightness_set = as21xxx_led_brightness_set,
@@ -1187,6 +1234,7 @@ static struct phy_driver as21xxx_drivers[] = {
 		.name		= "Aeonsemi AS21510PB1",
 		.probe		= as21xxx_probe,
 		.match_phy_device = as21xxx_match_phy_device,
+		.config_init	= as21xxx_config_init,
 		.read_status	= as21xxx_read_status,
 		.read_mmd	= as21xxx_read_mmd,
 		.led_brightness_set = as21xxx_led_brightness_set,
@@ -1201,6 +1249,7 @@ static struct phy_driver as21xxx_drivers[] = {
 		.name		= "Aeonsemi AS21511JB1",
 		.probe		= as21xxx_probe,
 		.match_phy_device = as21xxx_match_phy_device,
+		.config_init	= as21xxx_config_init,
 		.read_status	= as21xxx_read_status,
 		.read_mmd	= as21xxx_read_mmd,
 		.led_brightness_set = as21xxx_led_brightness_set,
@@ -1215,6 +1264,7 @@ static struct phy_driver as21xxx_drivers[] = {
 		.name		= "Aeonsemi AS21210JB1",
 		.probe		= as21xxx_probe,
 		.match_phy_device = as21xxx_match_phy_device,
+		.config_init	= as21xxx_config_init,
 		.read_status	= as21xxx_read_status,
 		.read_mmd	= as21xxx_read_mmd,
 		.led_brightness_set = as21xxx_led_brightness_set,
@@ -1229,6 +1279,7 @@ static struct phy_driver as21xxx_drivers[] = {
 		.name		= "Aeonsemi AS21511PB1",
 		.probe		= as21xxx_probe,
 		.match_phy_device = as21xxx_match_phy_device,
+		.config_init	= as21xxx_config_init,
 		.read_status	= as21xxx_read_status,
 		.read_mmd	= as21xxx_read_mmd,
 		.led_brightness_set = as21xxx_led_brightness_set,