From e21f48d740a2dd9af12c8000171b8ac092007b00 Mon Sep 17 00:00:00 2001 From: Hugo Extrat Date: Wed, 18 Nov 2026 11:30:15 +0100 Subject: [PATCH 1/2] fix(core): Remove web Replay and Feedback from native bundles by default `includeWebReplay` and `includeWebFeedback` defaulted to `true`, and the Metro resolvers were only installed when the option was explicitly `false`. The resolver's `undefined` branch, which removes these packages on Android and iOS only, could never run, even though the 5.32.0 changelog announced Web Replay removal from native bundles by default. Install both resolvers unless the option is `true`: - `undefined` (default): removed on Android and iOS, kept on web - `true`: kept on all platforms - `false`: removed on all platforms Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 6 ++ packages/core/src/js/tools/metroconfig.ts | 27 ++++--- packages/core/test/tools/metroconfig.test.ts | 77 ++++++++++++++++++++ 3 files changed, 100 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3be3017e6e..b183100eaf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,12 @@ ## Unreleased +### Fixes + +- Remove the web Session Replay and User Feedback packages from Android and iOS bundles by default, as announced in 5.32.0 ([#TBD](https://github.com/getsentry/sentry-react-native/pull/TBD)) + - Before this fix, `includeWebReplay` and `includeWebFeedback` defaulted to `true`, so these packages stayed in native bundles even though they never run there. + - Web bundles keep both packages. Set the option to `true` to keep a package on all platforms, or to `false` to remove it on all platforms, including web. + ### Dependencies - Bump Android SDK from v8.64.0 to v8.65.0 ([#7058](https://github.com/getsentry/sentry-react-native/pull/7058)) diff --git a/packages/core/src/js/tools/metroconfig.ts b/packages/core/src/js/tools/metroconfig.ts index bb8a59d65e..64a245f489 100644 --- a/packages/core/src/js/tools/metroconfig.ts +++ b/packages/core/src/js/tools/metroconfig.ts @@ -56,13 +56,20 @@ export interface SentryMetroConfigOptions { textComponentNames?: string[]; }; /** - * Adds the Sentry replay package for web. - * @default true + * Adds the Sentry web replay package (`@sentry-internal/replay`) to the bundle. + * + * - `undefined` (default): removed from Android and iOS bundles, where it is never used, and kept on web. + * - `true`: kept on all platforms. + * - `false`: removed on all platforms, including web. */ includeWebReplay?: boolean; /** - * Adds the Sentry user feedback widget package. - * @default true + * Adds the Sentry web user feedback widget package (`@sentry-internal/feedback`) to the bundle. + * It does not affect the React Native feedback widget (`feedbackIntegration`). + * + * - `undefined` (default): removed from Android and iOS bundles, where it is never used, and kept on web. + * - `true`: kept on all platforms. + * - `false`: removed on all platforms, including web. */ includeWebFeedback?: boolean; /** @@ -134,8 +141,8 @@ export function withSentryConfig( config: MetroConfig, { annotateReactComponents = false, - includeWebReplay = true, - includeWebFeedback = true, + includeWebReplay, + includeWebFeedback, enableSourceContextInDevelopment = true, optionsFile = true, autoWrapExpoRouterErrorBoundary = false, @@ -152,10 +159,10 @@ export function withSentryConfig( if (annotateReactComponents || autoWrapExpoRouterErrorBoundary) { newConfig = withSentryBabelTransformer(newConfig, annotateReactComponents, autoWrapExpoRouterErrorBoundary); } - if (includeWebReplay === false) { + if (includeWebReplay !== true) { newConfig = withSentryResolver(newConfig, includeWebReplay); } - if (includeWebFeedback === false) { + if (includeWebFeedback !== true) { newConfig = withSentryFeedbackResolver(newConfig, includeWebFeedback); } newConfig = withSentryExcludeServerOnlyResolver(newConfig); @@ -202,10 +209,10 @@ export function getSentryExpoConfig( ); } - if (options.includeWebReplay === false) { + if (options.includeWebReplay !== true) { newConfig = withSentryResolver(newConfig, options.includeWebReplay); } - if (options.includeWebFeedback === false) { + if (options.includeWebFeedback !== true) { newConfig = withSentryFeedbackResolver(newConfig, options.includeWebFeedback); } newConfig = withSentryExcludeServerOnlyResolver(newConfig); diff --git a/packages/core/test/tools/metroconfig.test.ts b/packages/core/test/tools/metroconfig.test.ts index dd1da0bba5..e035897f56 100644 --- a/packages/core/test/tools/metroconfig.test.ts +++ b/packages/core/test/tools/metroconfig.test.ts @@ -122,6 +122,83 @@ describe('metroconfig', () => { }); }); + describe('web replay and feedback exclusion', () => { + const SENTRY_BROWSER_BARREL = '/project/node_modules/@sentry/browser/build/npm/esm/prod/index.js'; + const WEB_ONLY_PACKAGES = ['@sentry-internal/replay', '@sentry-internal/feedback']; + + type ExclusionOptions = Pick; + + let originalResolverMock: jest.Mock; + + beforeEach(() => { + originalResolverMock = jest.fn(); + }); + + describe.each([ + [ + 'withSentryConfig', + (options: ExclusionOptions) => + withSentryConfig( + { resolver: { resolveRequest: originalResolverMock } }, + { ...options, enableSourceContextInDevelopment: false, optionsFile: false }, + ), + ], + [ + 'getSentryExpoConfig', + (options: ExclusionOptions) => + getSentryExpoConfig('/project/root', { + ...options, + injectReleaseForWeb: false, + enableSourceContextInDevelopment: false, + optionsFile: false, + getDefaultConfig: jest.fn().mockReturnValue({ resolver: { resolveRequest: originalResolverMock } }), + }), + ], + ])('%s', (_name, buildConfig) => { + const resolve = (options: ExclusionOptions, moduleName: string, platform: string) => { + const context = { resolveRequest: jest.fn(), originModulePath: SENTRY_BROWSER_BARREL }; + return buildConfig(options).resolver?.resolveRequest?.(context as never, moduleName, platform); + }; + + describe.each(WEB_ONLY_PACKAGES)('with %s', moduleName => { + test.each(['android', 'ios'])('removes it on %s by default', platform => { + expect(resolve({}, moduleName, platform)).toEqual({ type: 'empty' }); + expect(originalResolverMock).not.toHaveBeenCalled(); + }); + + test('keeps it on web by default', () => { + resolve({}, moduleName, 'web'); + expect(originalResolverMock).toHaveBeenCalledWith(expect.anything(), moduleName, 'web'); + }); + + test('keeps it on android when the option is true', () => { + resolve({ includeWebReplay: true, includeWebFeedback: true }, moduleName, 'android'); + expect(originalResolverMock).toHaveBeenCalledWith(expect.anything(), moduleName, 'android'); + }); + + test('removes it on web when the option is false', () => { + expect(resolve({ includeWebReplay: false, includeWebFeedback: false }, moduleName, 'web')).toEqual({ + type: 'empty', + }); + expect(originalResolverMock).not.toHaveBeenCalled(); + }); + }); + + test.each(['./feedbackSync.js', './feedbackAsync.js'])( + 'removes the @sentry/browser %s wrapper on android by default', + moduleName => { + expect(resolve({}, moduleName, 'android')).toEqual({ type: 'empty' }); + expect(originalResolverMock).not.toHaveBeenCalled(); + }, + ); + + test('keeps other @sentry/browser modules on android by default', () => { + resolve({}, './sdk.js', 'android'); + expect(originalResolverMock).toHaveBeenCalledWith(expect.anything(), './sdk.js', 'android'); + }); + }); + }); + describe('withSentryFramesCollapsed', () => { test('adds customizeFrames if undefined ', () => { const config = withSentryFramesCollapsed({}); From c82ac812c31f5d14189996be70f045ee4015e552 Mon Sep 17 00:00:00 2001 From: Hugo Extrat Date: Wed, 18 Nov 2026 11:32:36 +0100 Subject: [PATCH 2/2] Add PR number to changelog Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b183100eaf..861b2c7a50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ ### Fixes -- Remove the web Session Replay and User Feedback packages from Android and iOS bundles by default, as announced in 5.32.0 ([#TBD](https://github.com/getsentry/sentry-react-native/pull/TBD)) +- Remove the web Session Replay and User Feedback packages from Android and iOS bundles by default, as announced in 5.32.0 ([#7062](https://github.com/getsentry/sentry-react-native/pull/7062)) - Before this fix, `includeWebReplay` and `includeWebFeedback` defaulted to `true`, so these packages stayed in native bundles even though they never run there. - Web bundles keep both packages. Set the option to `true` to keep a package on all platforms, or to `false` to remove it on all platforms, including web.