diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 65e5814..018c2d8 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -29,7 +29,7 @@ Default behavior to preserve unless a training scenario says otherwise: - Favorite count includes unread favorites. - Empty-state copy should mention changing the search term, genre, or reading status. -Use the current Node.js LTS. The app declares `engines.node` as `^20.19.0 || >=22.12.0`. CI uses Node 22. +Use the current Node.js LTS. The app declares `engines.node` as `>=24.0.0`. CI uses Node 24. ## Validation diff --git a/.github/workflows/book-app-web.yml b/.github/workflows/book-app-web.yml index bfe611e..44b4caf 100644 --- a/.github/workflows/book-app-web.yml +++ b/.github/workflows/book-app-web.yml @@ -20,7 +20,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 with: - node-version: "22" + node-version: "24" cache: npm cache-dependency-path: samples/book-app-web/package-lock.json diff --git a/appendices/training-github-scenarios.md b/appendices/training-github-scenarios.md index 30778f0..6bf13d4 100644 --- a/appendices/training-github-scenarios.md +++ b/appendices/training-github-scenarios.md @@ -175,7 +175,7 @@ This matches the script's conversation comment. Do not create an inline review t ## Manual fallback: Create a failing check example -The repository includes the [Book app web workflow](../.github/workflows/book-app-web.yml). It uses Node.js 22, installs dependencies with `npm ci`, runs `npm test -- --run`, and builds `samples/book-app-web` with `npm run build`. +The repository includes the [Book app web workflow](../.github/workflows/book-app-web.yml). It uses Node.js 24, installs dependencies with `npm ci`, runs `npm test -- --run`, and builds `samples/book-app-web` with `npm run build`. The **Failing stats check practice** PR created above is the failing-check example. Do not create a second branch or PR for it. diff --git a/samples/book-app-web/package-lock.json b/samples/book-app-web/package-lock.json index 5412bbd..2f61470 100644 --- a/samples/book-app-web/package-lock.json +++ b/samples/book-app-web/package-lock.json @@ -22,7 +22,7 @@ "vitest": "^5.0.3" }, "engines": { - "node": "^20.19.0 || >=22.12.0" + "node": ">=24.0.0" } }, "node_modules/@acemir/cssom": { diff --git a/samples/book-app-web/package.json b/samples/book-app-web/package.json index 3a79288..75855f7 100644 --- a/samples/book-app-web/package.json +++ b/samples/book-app-web/package.json @@ -4,7 +4,7 @@ "private": true, "type": "module", "engines": { - "node": "^20.19.0 || >=22.12.0" + "node": ">=24.0.0" }, "scripts": { "dev": "vite",